Skip to content

Commit cd1c97a

Browse files
committed
Address comments
1 parent 227a405 commit cd1c97a

File tree

3 files changed

+7
-36
lines changed

3 files changed

+7
-36
lines changed

electron_demo/manipulator/README.md

Lines changed: 6 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,6 @@ An interactive Electron application demonstrating a two-joint robotic manipulato
4242
## 📜 Available Scripts
4343

4444
- **`npm start`** - Run demo (requires manual ROS2 environment setup)
45-
- **`npm run start-with-ros2`** - Run demo with automatic ROS2 environment setup (recommended)
4645
- **`npm run rebuild`** - Rebuild native modules after dependency changes
4746

4847
## 🚀 Quick Start
@@ -58,18 +57,7 @@ npm start
5857
-**Pure visualization and manual control**
5958
- ⚠️ No ROS2 topic publishing (local mode only)
6059

61-
### Option 2: Full ROS2 Integration (Recommended)
62-
63-
```bash
64-
npm run start-with-ros2
65-
```
66-
67-
-**Automatically sources ROS2 environment**
68-
-**Publishes to `/joint_states` topic**
69-
-**Full ROS2 ecosystem integration**
70-
-**No manual environment setup needed**
71-
72-
### Option 3: Manual ROS2 Setup
60+
### Option 2: Manual ROS2 Setup (Recommended for ROS2 Integration)
7361

7462
1. **Source your ROS2 environment**:
7563

@@ -82,6 +70,10 @@ npm run start-with-ros2
8270
npm start
8371
```
8472

73+
-**Publishes to `/joint_states` topic**
74+
-**Full ROS2 ecosystem integration**
75+
-**Real-time ROS2 message monitoring**
76+
8577
## 🎮 Usage
8678

8779
### Interactive Controls
@@ -259,10 +251,7 @@ manipulator/
259251
1. **"librcl.so not found"**
260252

261253
```bash
262-
# Use the convenient script (recommended)
263-
npm run start-with-ros2
264-
265-
# Or manually source ROS2
254+
# Source ROS2 environment manually
266255
source /opt/ros/humble/setup.bash # or your ROS2 installation path
267256
npm start
268257
```

electron_demo/manipulator/package.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
"main": "main.js",
66
"scripts": {
77
"start": "electron .",
8-
"start-with-ros2": "./start-demo.sh",
98
"rebuild": "electron-rebuild"
109
},
1110
"keywords": [
@@ -27,4 +26,4 @@
2726
"@electron/rebuild": "^3.7.2",
2827
"electron": "^31.7.7"
2928
}
30-
}
29+
}

electron_demo/manipulator/start-demo.sh

Lines changed: 0 additions & 17 deletions
This file was deleted.

0 commit comments

Comments
 (0)