Skip to content

Commit d2f3c44

Browse files
author
Minggang Wang
committed
Don't login docker hub anonymous
Becasue rate limits anonymous and free authenticated use of Docker Hub went into effect (https://www.docker.com/increase-rate-limits), we need to login docker with an account. This patch sets two environment variables (DOCKER_PASSWORD & DOCKER_USERNAME) for the travis-ci that will be used to login to the docker hub, thus, we could break the limiting. Please be aware, the PR submitted from a fork repo will not use this account due to https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions Fix #766
1 parent 88940b2 commit d2f3c44

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

.travis.yml

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,8 @@ branches:
77
only:
88
- foxy-fitzroy
99

10-
before_install:
10+
script:
11+
- 'if [ "$DOCKER_USERNAME" != "" ]; then sudo docker login -u $DOCKER_USERNAME -p $DOCKER_PASSWORD; fi'
1112
- sudo docker pull ubuntu:focal
1213
- sudo docker build -t rcldocker .
13-
14-
script:
1514
- sudo docker run -v $(pwd):/root/rclnodejs --rm rcldocker bash -i -c 'cd /root/rclnodejs && cppcheck --suppress=syntaxError --enable=all src/*.cpp src/*.hpp && ./scripts/build.sh && npm test'

0 commit comments

Comments
 (0)