Skip to content

Commit e9d72aa

Browse files
committed
Generate UUID by crypto
Fix: #1081
1 parent 59d758c commit e9d72aa

File tree

4 files changed

+2
-6
lines changed

4 files changed

+2
-6
lines changed

lib/action/uuid.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@
1515
'use strict';
1616

1717
const ActionInterfaces = require('./interfaces.js');
18-
const { v4: uuidv4 } = require('uuid');
1918

2019
/**
2120
* @class - Represents a unique identifier used by actions.
@@ -37,7 +36,7 @@ class ActionUuid {
3736
this._bytes = bytes;
3837
} else {
3938
// Generate random UUID.
40-
let uuid = uuidv4().replace(/-/g, '');
39+
let uuid = crypto.randomUUID().replace(/-/g, '');
4140
this._bytes = Uint8Array.from(Buffer.from(uuid, 'hex'));
4241
}
4342
}

package.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,6 @@
8181
"nan": "^2.22.0",
8282
"prettier": "^3.4.2",
8383
"rimraf": "^6.0.1",
84-
"uuid": "^11.0.3",
8584
"walk": "^2.3.15"
8685
},
8786
"husky": {

test/test-action-client.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@
1616

1717
const assert = require('assert');
1818
const sinon = require('sinon');
19-
const { v4: uuidv4 } = require('uuid');
2019
const assertUtils = require('./utils.js');
2120
const rclnodejs = require('../index.js');
2221
const { ActionUuid } = require('../index.js');

test/test-action-server.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@
1616

1717
const assert = require('assert');
1818
const deepEqual = require('deep-equal');
19-
const { v4: uuidv4 } = require('uuid');
2019
const assertUtils = require('./utils.js');
2120
const rclnodejs = require('../index.js');
2221

@@ -34,7 +33,7 @@ describe('rclnodejs action server', function () {
3433
}
3534

3635
function createUuid() {
37-
let uuid = uuidv4().replace(/-/g, '');
36+
let uuid = crypto.randomUUID().replace(/-/g, '');
3837
let bytes = Uint8Array.from(Buffer.from(uuid, 'hex'));
3938

4039
let UUID = rclnodejs.require('unique_identifier_msgs/msg/UUID');

0 commit comments

Comments
 (0)