Adapt C++20 #1020
Merged
Adapt C++20 #1020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minggangw
added a commit
that referenced
this pull request
Jan 24, 2025
Currently, we adapt C++17 to compile the C++ addon, but nodejs 23.X needs C++20 to develop addon, this patch: 1. Adapt C++20 for Windows & Linux platforms, keeping macOS as C++17. 2. Add checking for nodejs 23.X into actions for Linux platform. Fix: #1019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we adapt C++17 to compile the C++ addon, but nodejs 23.X needs C++20 to develop addon, this patch: