Move rimraf to dependencies #1067
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
PR Overview
This PR moves rimraf to dependencies and updates the Github Actions workflow to ensure the workspace is cleaned post-build.
- Moves rimraf to dependencies to ensure it is available during runtime.
- Adds "npm run clean" as the final step in the Linux build and test workflow.
Reviewed Changes
| File | Description |
|---|---|
| .github/workflows/linux-build-and-test.yml | Adds "npm run clean" after test execution to clean up the workspace. |
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
.github/workflows/linux-build-and-test.yml:55
- Consider using 'if: always()' on the clean step to ensure the clean command runs even if previous test steps fail.
npm run clean
minggangw
added a commit
that referenced
this pull request
Mar 8, 2025
This patch moves `rimraf` to `dependencies` in package.json as it's still needed. Meanwhile, add `npm run clean` as the last step for Github Actions to clean up the workspace for Linux platform. Fix: #1065
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch moves
rimraftodependenciesin package.json as it's still needed. Meanwhile, addnpm run cleanas the last step for Github Actions to clean up the workspace for Linux platform.Fix: #1065