From c41eeddf233b949433c93a5d84c0258ef80256db Mon Sep 17 00:00:00 2001 From: Minggang Wang Date: Mon, 26 May 2025 12:42:40 +0800 Subject: [PATCH 01/12] Include all LTS ROS2 on develop branch --- .github/workflows/linux-build-and-test.yml | 23 +++++++++++++++------- 1 file changed, 16 insertions(+), 7 deletions(-) diff --git a/.github/workflows/linux-build-and-test.yml b/.github/workflows/linux-build-and-test.yml index 87d1eed9..4ae6c941 100644 --- a/.github/workflows/linux-build-and-test.yml +++ b/.github/workflows/linux-build-and-test.yml @@ -38,17 +38,27 @@ jobs: build: needs: [identify-ros-distro, matrix-prep] - runs-on: ubuntu-${{ matrix.ubuntu-version }} + runs-on: ubuntu-latest container: - image: ${{ needs.identify-ros-distro.outputs.linuxos }} + image: ${{ matrix.docker_image }} strategy: fail-fast: false matrix: node-version: [20.X, 22.X, 24.X] architecture: [x64] - ubuntu-version: [latest] - # Include arm64 configuration from matrix-prep job - include: ${{ fromJSON(needs.matrix-prep.outputs.arm64-matrix) }} + include: + # Humble Hawksbill (May 2022 - May 2027) + - docker_image: ubuntu:jammy + ros_distribution: humble + # Jazzy Jalisco (May 2024 - May 2029) + - docker_image: ubuntu:noble + ros_distribution: jazzy + # Kilted Kaiju (May 2025 - Dec 2026) + - docker_image: ubuntu:noble + ros_distribution: rolling + # Rolling Ridley (No End-Of-Life) + - docker_image: ubuntu:noble + ros_distribution: rolling steps: - name: Setup Node.js ${{ matrix.node-version }} on ${{ matrix.architecture }} uses: actions/setup-node@v4 @@ -59,8 +69,7 @@ jobs: - name: Setup ROS2 uses: ros-tooling/setup-ros@v0.7 with: - required-ros-distributions: ${{ needs.identify-ros-distro.outputs.distro }} - use-ros2-testing: true + required-ros-distributions: ${{ matrix.ros_distribution }} - name: Install test-msgs on Linux run: | From 78e7cd43709963f0599b6803d05d0b43e9619e30 Mon Sep 17 00:00:00 2001 From: Minggang Wang Date: Mon, 26 May 2025 12:54:50 +0800 Subject: [PATCH 02/12] Add ros_distribution --- .github/workflows/linux-build-and-test.yml | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/.github/workflows/linux-build-and-test.yml b/.github/workflows/linux-build-and-test.yml index 4ae6c941..72d90fa0 100644 --- a/.github/workflows/linux-build-and-test.yml +++ b/.github/workflows/linux-build-and-test.yml @@ -46,6 +46,11 @@ jobs: matrix: node-version: [20.X, 22.X, 24.X] architecture: [x64] + ros_distribution: + - humble + - jazzy + - kilted + - rolling include: # Humble Hawksbill (May 2022 - May 2027) - docker_image: ubuntu:jammy @@ -55,7 +60,7 @@ jobs: ros_distribution: jazzy # Kilted Kaiju (May 2025 - Dec 2026) - docker_image: ubuntu:noble - ros_distribution: rolling + ros_distribution: kilted # Rolling Ridley (No End-Of-Life) - docker_image: ubuntu:noble ros_distribution: rolling @@ -73,14 +78,14 @@ jobs: - name: Install test-msgs on Linux run: | - sudo apt install ros-${{ needs.identify-ros-distro.outputs.distro }}-test-msgs + sudo apt install ros-${{ matrix.ros_distribution }}-test-msgs - uses: actions/checkout@v4 - name: Build and test rclnodejs run: | uname -a - source /opt/ros/${{ needs.identify-ros-distro.outputs.distro }}/setup.bash + source /opt/ros/${{ matrix.ros_distribution }}/setup.bash npm i npm run lint npm test From be8c395a6a03724a28dc03b92684128f1e0db21b Mon Sep 17 00:00:00 2001 From: Minggang Wang Date: Mon, 26 May 2025 13:16:56 +0800 Subject: [PATCH 03/12] Separate arm64 platform --- .../workflows/linux-arm64-build-and-test.yml | 92 +++++++++++++++++++ ...-test.yml => linux-x64-build-and-test.yml} | 17 ---- 2 files changed, 92 insertions(+), 17 deletions(-) create mode 100644 .github/workflows/linux-arm64-build-and-test.yml rename .github/workflows/{linux-build-and-test.yml => linux-x64-build-and-test.yml} (79%) diff --git a/.github/workflows/linux-arm64-build-and-test.yml b/.github/workflows/linux-arm64-build-and-test.yml new file mode 100644 index 00000000..47252af4 --- /dev/null +++ b/.github/workflows/linux-arm64-build-and-test.yml @@ -0,0 +1,92 @@ +name: Linux arm64 + +on: + push: + branches: + - develop + - kilted + - jazzy + - humble-hawksbill + pull_request: + branches: + - develop + - kilted + - jazzy + - humble-hawksbill + workflow_dispatch: + +defaults: + run: + shell: bash + +jobs: + build: + runs-on: ubuntu-latest + container: + image: ${{ matrix.docker_image }} + strategy: + fail-fast: false + matrix: + node-version: [20.X, 22.X, 24.X] + architecture: [arm64] + ros_distribution: + - humble + - jazzy + - kilted + - rolling + include: + # Humble Hawksbill (May 2022 - May 2027) + - docker_image: ubuntu:jammy + ros_distribution: humble + # Jazzy Jalisco (May 2024 - May 2029) + - docker_image: ubuntu:noble + ros_distribution: jazzy + # Kilted Kaiju (May 2025 - Dec 2026) + - docker_image: ubuntu:noble + ros_distribution: kilted + # Rolling Ridley (No End-Of-Life) + - docker_image: ubuntu:noble + ros_distribution: rolling + steps: + - name: Setup Node.js ${{ matrix.node-version }} on ${{ matrix.architecture }} + uses: actions/setup-node@v4 + with: + node-version: ${{ matrix.node-version }} + architecture: ${{ matrix.architecture }} + + - name: Setup ROS2 + uses: ros-tooling/setup-ros@v0.7 + with: + required-ros-distributions: ${{ matrix.ros_distribution }} + + - name: Install test-msgs on Linux + run: | + sudo apt install ros-${{ matrix.ros_distribution }}-test-msgs + + - uses: actions/checkout@v4 + + - name: Build and test rclnodejs + run: | + uname -a + source /opt/ros/${{ matrix.ros_distribution }}/setup.bash + npm i + npm run lint + npm test + npm run clean + + - name: Coveralls Parallel + uses: coverallsapp/github-action@v2 + with: + github-token: ${{ secrets.GITHUB_TOKEN }} + flag-name: run-${{ matrix.node-version }}-${{ matrix.architecture }} + parallel: true + + finish: + needs: build + runs-on: ubuntu-latest + steps: + - name: Coveralls Finished + uses: coverallsapp/github-action@v2 + with: + github-token: ${{ secrets.GITHUB_TOKEN }} + parallel-finished: true diff --git a/.github/workflows/linux-build-and-test.yml b/.github/workflows/linux-x64-build-and-test.yml similarity index 79% rename from .github/workflows/linux-build-and-test.yml rename to .github/workflows/linux-x64-build-and-test.yml index 72d90fa0..e5cc97dc 100644 --- a/.github/workflows/linux-build-and-test.yml +++ b/.github/workflows/linux-x64-build-and-test.yml @@ -20,24 +20,7 @@ defaults: shell: bash jobs: - identify-ros-distro: - uses: ./.github/workflows/identify-ros-distro.yml - - matrix-prep: - runs-on: ubuntu-latest - outputs: - arm64-matrix: ${{ steps.set-matrix.outputs.arm64-matrix }} - steps: - - id: set-matrix - run: | - if ${{ contains(github.base_ref, 'develop') || contains(github.ref, 'develop') }}; then - echo "arm64-matrix=[{\"architecture\":\"arm64\",\"node-version\":\"22.X\",\"ubuntu-version\":\"24.04-arm\"}]" >> $GITHUB_OUTPUT - else - echo "arm64-matrix=[]" >> $GITHUB_OUTPUT - fi - build: - needs: [identify-ros-distro, matrix-prep] runs-on: ubuntu-latest container: image: ${{ matrix.docker_image }} From 503839322e2f8a68d98ff8ab7c3567a5f430e305 Mon Sep 17 00:00:00 2001 From: Minggang Wang Date: Mon, 26 May 2025 13:29:20 +0800 Subject: [PATCH 04/12] User arm image for docker --- .github/workflows/linux-arm64-build-and-test.yml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/linux-arm64-build-and-test.yml b/.github/workflows/linux-arm64-build-and-test.yml index 47252af4..e8934103 100644 --- a/.github/workflows/linux-arm64-build-and-test.yml +++ b/.github/workflows/linux-arm64-build-and-test.yml @@ -36,16 +36,16 @@ jobs: - rolling include: # Humble Hawksbill (May 2022 - May 2027) - - docker_image: ubuntu:jammy + - docker_image: ubuntu:jammy-arm ros_distribution: humble # Jazzy Jalisco (May 2024 - May 2029) - - docker_image: ubuntu:noble + - docker_image: ubuntu:noble-arm ros_distribution: jazzy # Kilted Kaiju (May 2025 - Dec 2026) - - docker_image: ubuntu:noble + - docker_image: ubuntu:noble-arm ros_distribution: kilted # Rolling Ridley (No End-Of-Life) - - docker_image: ubuntu:noble + - docker_image: ubuntu:noble-arm ros_distribution: rolling steps: - name: Setup Node.js ${{ matrix.node-version }} on ${{ matrix.architecture }} From 18485866dabb107d163091704853ea8553e1461a Mon Sep 17 00:00:00 2001 From: Minggang Wang Date: Mon, 26 May 2025 13:37:20 +0800 Subject: [PATCH 05/12] Use ubuntu arm --- .github/workflows/linux-arm64-build-and-test.yml | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/.github/workflows/linux-arm64-build-and-test.yml b/.github/workflows/linux-arm64-build-and-test.yml index e8934103..1b4ee916 100644 --- a/.github/workflows/linux-arm64-build-and-test.yml +++ b/.github/workflows/linux-arm64-build-and-test.yml @@ -21,7 +21,7 @@ defaults: jobs: build: - runs-on: ubuntu-latest + runs-on: ubuntu-latest-arm container: image: ${{ matrix.docker_image }} strategy: @@ -36,16 +36,16 @@ jobs: - rolling include: # Humble Hawksbill (May 2022 - May 2027) - - docker_image: ubuntu:jammy-arm + - docker_image: ubuntu:jammy ros_distribution: humble # Jazzy Jalisco (May 2024 - May 2029) - - docker_image: ubuntu:noble-arm + - docker_image: ubuntu:noble ros_distribution: jazzy # Kilted Kaiju (May 2025 - Dec 2026) - - docker_image: ubuntu:noble-arm + - docker_image: ubuntu:noble ros_distribution: kilted # Rolling Ridley (No End-Of-Life) - - docker_image: ubuntu:noble-arm + - docker_image: ubuntu:noble ros_distribution: rolling steps: - name: Setup Node.js ${{ matrix.node-version }} on ${{ matrix.architecture }} From 8df71875816cc2d6dfac6213d2b1008b292a05bb Mon Sep 17 00:00:00 2001 From: Minggang Wang Date: Mon, 26 May 2025 14:08:15 +0800 Subject: [PATCH 06/12] Only target on node 22.x for arm --- .../workflows/linux-arm64-build-and-test.yml | 21 ++----------------- 1 file changed, 2 insertions(+), 19 deletions(-) diff --git a/.github/workflows/linux-arm64-build-and-test.yml b/.github/workflows/linux-arm64-build-and-test.yml index 1b4ee916..75cb2b50 100644 --- a/.github/workflows/linux-arm64-build-and-test.yml +++ b/.github/workflows/linux-arm64-build-and-test.yml @@ -21,13 +21,13 @@ defaults: jobs: build: - runs-on: ubuntu-latest-arm + runs-on: ubuntu-24.04-arm container: image: ${{ matrix.docker_image }} strategy: fail-fast: false matrix: - node-version: [20.X, 22.X, 24.X] + node-version: [22.X] architecture: [arm64] ros_distribution: - humble @@ -73,20 +73,3 @@ jobs: npm run lint npm test npm run clean - - - name: Coveralls Parallel - uses: coverallsapp/github-action@v2 - with: - github-token: ${{ secrets.GITHUB_TOKEN }} - flag-name: run-${{ matrix.node-version }}-${{ matrix.architecture }} - parallel: true - - finish: - needs: build - runs-on: ubuntu-latest - steps: - - name: Coveralls Finished - uses: coverallsapp/github-action@v2 - with: - github-token: ${{ secrets.GITHUB_TOKEN }} - parallel-finished: true From 03c2ab10605d9f84a4f44373721b199efe2efa5c Mon Sep 17 00:00:00 2001 From: Minggang Wang Date: Mon, 26 May 2025 14:38:56 +0800 Subject: [PATCH 07/12] Change windows accordingly --- .github/workflows/windows-build-and-test.yml | 38 +++++++++++--------- 1 file changed, 22 insertions(+), 16 deletions(-) diff --git a/.github/workflows/windows-build-and-test.yml b/.github/workflows/windows-build-and-test.yml index 02ce319f..e560a71e 100644 --- a/.github/workflows/windows-build-and-test.yml +++ b/.github/workflows/windows-build-and-test.yml @@ -16,16 +16,30 @@ on: workflow_dispatch: jobs: - identify-ros-distro: - uses: ./.github/workflows/identify-ros-distro.yml - build: - needs: identify-ros-distro runs-on: windows-2019 strategy: fail-fast: false matrix: node-version: [22.X] + ros_distribution: + - humble + - jazzy + - kilted + - rolling + include: + # Humble Hawksbill (May 2022 - May 2027) + - docker_image: ubuntu:jammy + ros_distribution: humble + # Jazzy Jalisco (May 2024 - May 2029) + - docker_image: ubuntu:noble + ros_distribution: jazzy + # Kilted Kaiju (May 2025 - Dec 2026) + - docker_image: ubuntu:noble + ros_distribution: kilted + # Rolling Ridley (No End-Of-Life) + - docker_image: ubuntu:noble + ros_distribution: rolling steps: - name: Setup Node.js ${{ matrix.node-version }} uses: actions/setup-node@v4 @@ -35,16 +49,9 @@ jobs: - name: Setup ROS2 uses: ros-tooling/setup-ros@v0.7 with: - required-ros-distributions: ${{ needs.identify-ros-distro.outputs.distro }} + required-ros-distributions: ${{ matrix.ros_distribution }} use-ros2-testing: true - - name: Install ROS2 Rolling (Conditional) - if: ${{ needs.identify-ros-distro.outputs.distro == 'rolling' }} - shell: bash - run: | - wget --quiet https://ci.ros2.org/view/packaging/job/packaging_windows/lastSuccessfulBuild/artifact/ws/ros2-package-windows-AMD64.zip -O rolling.zip - 7z x rolling.zip -y -o/c/dev/rolling - - name: Prebuild - Setup VS Dev Environment uses: seanmiddleditch/gha-setup-vsdevenv@v4 @@ -53,7 +60,7 @@ jobs: - name: Build rclnodejs shell: cmd run: | - call "c:\dev\${{ needs.identify-ros-distro.outputs.distro }}\ros2-windows\setup.bat" + call "c:\dev\${{ matrix.ros_distribution }}\ros2-windows\setup.bat" npm i # On the windows/foxy combination the Eclipse CycloneDDS RMW implementation is used to workaround @@ -61,6 +68,5 @@ jobs: - name: Test rclnodejs shell: cmd run: | - call "c:\dev\${{ needs.identify-ros-distro.outputs.distro }}\ros2-windows\setup.bat" - cmd /c "if ${{ needs.identify-ros-distro.outputs.distro }}==foxy (set RMW_IMPLEMENTATION=rmw_cyclonedds_cpp&&npm test)" - cmd /c "if NOT ${{ needs.identify-ros-distro.outputs.distro }}==foxy if NOT ${{ needs.identify-ros-distro.outputs.distro }}==rolling if NOT ${{ needs.identify-ros-distro.outputs.distro }}==kilted (npm test)" + call "c:\dev\${{ matrix.ros_distribution }}\ros2-windows\setup.bat" + cmd /c "if NOT ${{ matrix.ros_distribution }}==rolling if NOT ${{ matrix.ros_distribution }}==kilted (npm test)" From 04b894058be4f1e9f213fe844f850267486462e1 Mon Sep 17 00:00:00 2001 From: Minggang Wang Date: Mon, 26 May 2025 15:15:48 +0800 Subject: [PATCH 08/12] Fix rolling error for Windows --- .github/workflows/windows-build-and-test.yml | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/.github/workflows/windows-build-and-test.yml b/.github/workflows/windows-build-and-test.yml index e560a71e..2c4f9a80 100644 --- a/.github/workflows/windows-build-and-test.yml +++ b/.github/workflows/windows-build-and-test.yml @@ -50,7 +50,13 @@ jobs: uses: ros-tooling/setup-ros@v0.7 with: required-ros-distributions: ${{ matrix.ros_distribution }} - use-ros2-testing: true + + - name: Install ROS2 Rolling (Conditional) + if: ${{ matrix.ros_distribution == 'rolling' }} + shell: bash + run: | + wget --quiet https://ci.ros2.org/view/packaging/job/packaging_windows/lastSuccessfulBuild/artifact/ws/ros2-package-windows-AMD64.zip -O rolling.zip + 7z x rolling.zip -y -o/c/dev/rolling - name: Prebuild - Setup VS Dev Environment uses: seanmiddleditch/gha-setup-vsdevenv@v4 From 7e2b843d87e7acc21280b22bbf20a3874509203a Mon Sep 17 00:00:00 2001 From: Minggang Wang Date: Mon, 26 May 2025 16:37:07 +0800 Subject: [PATCH 09/12] Update badges in README --- .github/workflows/linux-x64-build-and-test.yml | 4 ++-- README.md | 9 +++------ 2 files changed, 5 insertions(+), 8 deletions(-) diff --git a/.github/workflows/linux-x64-build-and-test.yml b/.github/workflows/linux-x64-build-and-test.yml index e5cc97dc..b6d98231 100644 --- a/.github/workflows/linux-x64-build-and-test.yml +++ b/.github/workflows/linux-x64-build-and-test.yml @@ -1,4 +1,4 @@ -name: Linux x64/arm64 +name: Linux x64 on: push: @@ -27,7 +27,7 @@ jobs: strategy: fail-fast: false matrix: - node-version: [20.X, 22.X, 24.X] + node-version: [22.X, 24.X] architecture: [x64] ros_distribution: - humble diff --git a/README.md b/README.md index 0476fccf..ed926f3e 100644 --- a/README.md +++ b/README.md @@ -2,12 +2,9 @@ [![npm](https://img.shields.io/npm/v/rclnodejs.svg)](https://www.npmjs.com/package/rclnodejs)[![Coverage Status](https://coveralls.io/repos/github/RobotWebTools/rclnodejs/badge.svg?branch=develop)](https://coveralls.io/github/RobotWebTools/rclnodejs?branch=develop)[![npm](https://img.shields.io/npm/dm/rclnodejs)](https://www.npmjs.com/package/rclnodejs)[![GitHub license](https://img.shields.io/github/license/RobotWebTools/rclnodejs.svg)](https://github.com/RobotWebTools/rclnodejs/blob/develop/LICENSE)[![node](https://img.shields.io/node/v/rclnodejs.svg)](https://nodejs.org/en/download/releases/)[![npm type definitions](https://img.shields.io/npm/types/rclnodejs)](https://www.npmjs.com/package/rclnodejs)[![code style: prettier](https://img.shields.io/badge/code_style-prettier-ff69b4.svg?style=flat-square)](https://github.com/prettier/prettier) -| **ROS Distro\*** | **Status** | -| :--------------: | :-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------: | -| Rolling | [![Linux](https://github.com/RobotWebTools/rclnodejs/actions/workflows/linux-build-and-test.yml/badge.svg?branch=develop)](https://github.com/RobotWebTools/rclnodejs/actions/workflows/linux-build-and-test.yml?query=branch%3Adevelop)
[![Windows](https://github.com/RobotWebTools/rclnodejs/actions/workflows/windows-build-and-test.yml/badge.svg?branch=develop)](https://github.com/RobotWebTools/rclnodejs/actions/workflows/windows-build-and-test.yml?query=branch%3Adevelop) | -| Kilted | [![Linux](https://github.com/RobotWebTools/rclnodejs/actions/workflows/linux-build-and-test.yml/badge.svg?branch=kilted)](https://github.com/RobotWebTools/rclnodejs/actions/workflows/linux-build-and-test.yml?query=branch%3Akilted)
[![Windows](https://github.com/RobotWebTools/rclnodejs/actions/workflows/windows-build-and-test.yml/badge.svg?branch=kilted)](https://github.com/RobotWebTools/rclnodejs/actions/workflows/windows-build-and-test.yml?query=branch%3Akilted) | -| Jazzy | [![Linux](https://github.com/RobotWebTools/rclnodejs/actions/workflows/linux-build-and-test.yml/badge.svg?branch=jazzy)](https://github.com/RobotWebTools/rclnodejs/actions/workflows/linux-build-and-test.yml?query=branch%3Ajazzy)
[![Windows](https://github.com/RobotWebTools/rclnodejs/actions/workflows/windows-build-and-test.yml/badge.svg?branch=jazzy)](https://github.com/RobotWebTools/rclnodejs/actions/workflows/windows-build-and-test.yml?query=branch%3Ajazzy) | -| Humble | [![Linux](https://github.com/RobotWebTools/rclnodejs/actions/workflows/linux-build-and-test.yml/badge.svg?branch=humble-hawksbill)](https://github.com/RobotWebTools/rclnodejs/actions/workflows/linux-build-and-test.yml?query=branch%3Ahumble-hawksbill)
[![Windows](https://github.com/RobotWebTools/rclnodejs/actions/workflows/windows-build-and-test.yml/badge.svg?branch=humble-hawksbill)](https://github.com/RobotWebTools/rclnodejs/actions/workflows/windows-build-and-test.yml?query=branch%3Ahumble-hawksbill) | +| **ROS Distro\*** | **Status** | +| :----------------------------------: | :----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------: | +| Rolling
Kilted
Jazzy
Humble | [![Linux](https://github.com/RobotWebTools/rclnodejs/actions/workflows/linux-x64-build-and-test.yml/badge.svg?branch=develop)](https://github.com/RobotWebTools/rclnodejs/actions/workflows/linux-x64-build-and-test.yml?query=branch%3Adevelop)
[![Linux](https://github.com/RobotWebTools/rclnodejs/actions/workflows/linux-arm64-build-and-test.yml/badge.svg?branch=develop)](https://github.com/RobotWebTools/rclnodejs/actions/workflows/linux-arm64-build-and-test.yml?query=branch%3Adevelop)
[![Windows](https://github.com/RobotWebTools/rclnodejs/actions/workflows/windows-build-and-test.yml/badge.svg?branch=develop)](https://github.com/RobotWebTools/rclnodejs/actions/workflows/windows-build-and-test.yml?query=branch%3Adevelop) | \* rclnodejs development and maintenance is limited to the ROS 2 LTS releases and the Rolling development branch From 3889eefb8dd683fa924d7073161cf113e8e0755d Mon Sep 17 00:00:00 2001 From: Minggang Wang Date: Mon, 26 May 2025 16:40:18 +0800 Subject: [PATCH 10/12] Address comments --- .github/workflows/windows-build-and-test.yml | 14 +++++--------- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/.github/workflows/windows-build-and-test.yml b/.github/workflows/windows-build-and-test.yml index 2c4f9a80..d8dc2d9f 100644 --- a/.github/workflows/windows-build-and-test.yml +++ b/.github/workflows/windows-build-and-test.yml @@ -28,18 +28,14 @@ jobs: - kilted - rolling include: - # Humble Hawksbill (May 2022 - May 2027) - - docker_image: ubuntu:jammy - ros_distribution: humble + # Humble Hawksbill (May 2022 - May 2027) + - ros_distribution: humble # Jazzy Jalisco (May 2024 - May 2029) - - docker_image: ubuntu:noble - ros_distribution: jazzy + - ros_distribution: jazzy # Kilted Kaiju (May 2025 - Dec 2026) - - docker_image: ubuntu:noble - ros_distribution: kilted + - ros_distribution: kilted # Rolling Ridley (No End-Of-Life) - - docker_image: ubuntu:noble - ros_distribution: rolling + - ros_distribution: rolling steps: - name: Setup Node.js ${{ matrix.node-version }} uses: actions/setup-node@v4 From 80314a4e7a676be56fc2e2d4aab81d641c395957 Mon Sep 17 00:00:00 2001 From: Minggang Wang Date: Mon, 26 May 2025 17:22:09 +0800 Subject: [PATCH 11/12] Address comments --- .github/workflows/linux-arm64-build-and-test.yml | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/.github/workflows/linux-arm64-build-and-test.yml b/.github/workflows/linux-arm64-build-and-test.yml index 75cb2b50..dbca41ca 100644 --- a/.github/workflows/linux-arm64-build-and-test.yml +++ b/.github/workflows/linux-arm64-build-and-test.yml @@ -30,23 +30,16 @@ jobs: node-version: [22.X] architecture: [arm64] ros_distribution: - - humble - jazzy - kilted - - rolling include: - # Humble Hawksbill (May 2022 - May 2027) - - docker_image: ubuntu:jammy - ros_distribution: humble # Jazzy Jalisco (May 2024 - May 2029) - docker_image: ubuntu:noble ros_distribution: jazzy # Kilted Kaiju (May 2025 - Dec 2026) - docker_image: ubuntu:noble ros_distribution: kilted - # Rolling Ridley (No End-Of-Life) - - docker_image: ubuntu:noble - ros_distribution: rolling + steps: - name: Setup Node.js ${{ matrix.node-version }} on ${{ matrix.architecture }} uses: actions/setup-node@v4 From 8156bcd54c1a580325720d8c11c80a3cfde4d11a Mon Sep 17 00:00:00 2001 From: Minggang Wang Date: Mon, 26 May 2025 18:09:13 +0800 Subject: [PATCH 12/12] Format --- .github/workflows/linux-x64-build-and-test.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/linux-x64-build-and-test.yml b/.github/workflows/linux-x64-build-and-test.yml index b6d98231..5889459f 100644 --- a/.github/workflows/linux-x64-build-and-test.yml +++ b/.github/workflows/linux-x64-build-and-test.yml @@ -35,7 +35,7 @@ jobs: - kilted - rolling include: - # Humble Hawksbill (May 2022 - May 2027) + # Humble Hawksbill (May 2022 - May 2027) - docker_image: ubuntu:jammy ros_distribution: humble # Jazzy Jalisco (May 2024 - May 2029)