Skip to content

Conversation

@minggangw
Copy link
Member

@minggangw minggangw commented Sep 19, 2025

This PR introduces a comprehensive tutorial for content filtering subscription functionality in rclnodejs. Content filtering allows subscribers to filter messages at the DDS middleware level using SQL-like expressions, reducing network traffic and computational overhead.

Key Changes

  • Added complete tutorial documentation for content filtering subscription feature
  • Provided practical examples covering temperature monitoring, robot motion filtering, and multi-sensor data processing
  • Included compatibility checks, troubleshooting guidance, and best practices

Fix: #1269

Copilot AI review requested due to automatic review settings September 19, 2025 09:50
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a comprehensive tutorial for content filtering subscription functionality in rclnodejs. Content filtering allows subscribers to filter messages at the DDS middleware level using SQL-like expressions, reducing network traffic and computational overhead.

Key Changes

  • Added complete tutorial documentation for content filtering subscription feature
  • Provided practical examples covering temperature monitoring, robot motion filtering, and multi-sensor data processing
  • Included compatibility checks, troubleshooting guidance, and best practices
Comments suppressed due to low confidence (1)

tutorials/content-filtering-subscription.md:1

  • The emoji character '🌡️' may not render correctly in all environments. Consider using a text alternative like 'TEMP' or removing the emoji.
# Content Filtering Subscription in rclnodejs

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

};
```

````
Copy link

Copilot AI Sep 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incorrect markdown code block closing. Should use three backticks (```) instead of four.

Suggested change
````

Copilot uses AI. Check for mistakes.

// ✅ Correct - string comparison with quotes in parameter
{ expression: "status = %0", parameters: ["'active'"] }
````
Copy link

Copilot AI Sep 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incorrect markdown code block closing. Should use three backticks (```) instead of four.

Suggested change
````

Copilot uses AI. Check for mistakes.
parameters: [minRange, maxRange],
};

if (this.subscription.setContentFilter(newFilter)) {
Copy link

Copilot AI Sep 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The variable this.subscription is used but was never assigned in the updateRange method. It should reference the subscription created in the start method.

Copilot uses AI. Check for mistakes.
@coveralls
Copy link

coveralls commented Sep 19, 2025

Coverage Status

coverage: 84.337%. remained the same
when pulling e86ed07 on minggangw:fix-1269
into 8aaa068 on RobotWebTools:develop.

@minggangw minggangw merged commit 3220a56 into RobotWebTools:develop Sep 22, 2025
18 checks passed
minggangw added a commit that referenced this pull request Oct 13, 2025
This PR introduces a comprehensive tutorial for content filtering subscription functionality in rclnodejs. Content filtering allows subscribers to filter messages at the DDS middleware level using SQL-like expressions, reducing network traffic and computational overhead.

### Key Changes
- Added complete tutorial documentation for content filtering subscription feature
- Provided practical examples covering temperature monitoring, robot motion filtering, and multi-sensor data processing
- Included compatibility checks, troubleshooting guidance, and best practices

Fix: #1269
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add tutorial for content filtering subscription

2 participants