-
Notifications
You must be signed in to change notification settings - Fork 79
Add tutorial for content filtering subscription #1270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces a comprehensive tutorial for content filtering subscription functionality in rclnodejs. Content filtering allows subscribers to filter messages at the DDS middleware level using SQL-like expressions, reducing network traffic and computational overhead.
Key Changes
- Added complete tutorial documentation for content filtering subscription feature
- Provided practical examples covering temperature monitoring, robot motion filtering, and multi-sensor data processing
- Included compatibility checks, troubleshooting guidance, and best practices
Comments suppressed due to low confidence (1)
tutorials/content-filtering-subscription.md:1
- The emoji character '🌡️' may not render correctly in all environments. Consider using a text alternative like 'TEMP' or removing the emoji.
# Content Filtering Subscription in rclnodejs
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| }; | ||
| ``` | ||
|
|
||
| ```` |
Copilot
AI
Sep 19, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Incorrect markdown code block closing. Should use three backticks (```) instead of four.
| ```` |
|
|
||
| // ✅ Correct - string comparison with quotes in parameter | ||
| { expression: "status = %0", parameters: ["'active'"] } | ||
| ```` |
Copilot
AI
Sep 19, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Incorrect markdown code block closing. Should use three backticks (```) instead of four.
| ```` |
| parameters: [minRange, maxRange], | ||
| }; | ||
|
|
||
| if (this.subscription.setContentFilter(newFilter)) { |
Copilot
AI
Sep 19, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The variable this.subscription is used but was never assigned in the updateRange method. It should reference the subscription created in the start method.
This PR introduces a comprehensive tutorial for content filtering subscription functionality in rclnodejs. Content filtering allows subscribers to filter messages at the DDS middleware level using SQL-like expressions, reducing network traffic and computational overhead. ### Key Changes - Added complete tutorial documentation for content filtering subscription feature - Provided practical examples covering temperature monitoring, robot motion filtering, and multi-sensor data processing - Included compatibility checks, troubleshooting guidance, and best practices Fix: #1269
This PR introduces a comprehensive tutorial for content filtering subscription functionality in rclnodejs. Content filtering allows subscribers to filter messages at the DDS middleware level using SQL-like expressions, reducing network traffic and computational overhead.
Key Changes
Fix: #1269