Skip to content

Commit 1d78c29

Browse files
committed
Properly handle POINTS for highlight logic
1 parent 505508c commit 1d78c29

File tree

5 files changed

+9
-9
lines changed

5 files changed

+9
-9
lines changed

build/ros3d.cjs.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -57884,7 +57884,7 @@ Highlighter.prototype.renderHighlights = function renderHighlights (scene, rende
5788457884
Highlighter.prototype.makeEverythingInvisible = function makeEverythingInvisible (scene) {
5788557885
scene.traverse(function(currentObject) {
5788657886
if ( currentObject instanceof THREE.Mesh || currentObject instanceof THREE.Line
57887-
|| currentObject instanceof THREE.Sprite ) {
57887+
|| currentObject instanceof THREE.Sprite || currentObject instanceof THREE.Points ) {
5788857888
currentObject.previousVisibility = currentObject.visible;
5788957889
currentObject.visible = false;
5789057890
}
@@ -57900,7 +57900,7 @@ Highlighter.prototype.makeEverythingInvisible = function makeEverythingInvisible
5790057900
Highlighter.prototype.makeHighlightedVisible = function makeHighlightedVisible (scene) {
5790157901
var makeVisible = function(currentObject) {
5790257902
if ( currentObject instanceof THREE.Mesh || currentObject instanceof THREE.Line
57903-
|| currentObject instanceof THREE.Sprite ) {
57903+
|| currentObject instanceof THREE.Sprite || currentObject instanceof THREE.Points ) {
5790457904
currentObject.visible = true;
5790557905
}
5790657906
};

build/ros3d.esm.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -57860,7 +57860,7 @@ Highlighter.prototype.renderHighlights = function renderHighlights (scene, rende
5786057860
Highlighter.prototype.makeEverythingInvisible = function makeEverythingInvisible (scene) {
5786157861
scene.traverse(function(currentObject) {
5786257862
if ( currentObject instanceof THREE.Mesh || currentObject instanceof THREE.Line
57863-
|| currentObject instanceof THREE.Sprite ) {
57863+
|| currentObject instanceof THREE.Sprite || currentObject instanceof THREE.Points ) {
5786457864
currentObject.previousVisibility = currentObject.visible;
5786557865
currentObject.visible = false;
5786657866
}
@@ -57876,7 +57876,7 @@ Highlighter.prototype.makeEverythingInvisible = function makeEverythingInvisible
5787657876
Highlighter.prototype.makeHighlightedVisible = function makeHighlightedVisible (scene) {
5787757877
var makeVisible = function(currentObject) {
5787857878
if ( currentObject instanceof THREE.Mesh || currentObject instanceof THREE.Line
57879-
|| currentObject instanceof THREE.Sprite ) {
57879+
|| currentObject instanceof THREE.Sprite || currentObject instanceof THREE.Points ) {
5788057880
currentObject.visible = true;
5788157881
}
5788257882
};

build/ros3d.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -58374,7 +58374,7 @@ var ROS3D = (function (exports, ROSLIB) {
5837458374
makeEverythingInvisible(scene) {
5837558375
scene.traverse(function(currentObject) {
5837658376
if ( currentObject instanceof THREE.Mesh || currentObject instanceof THREE.Line
58377-
|| currentObject instanceof THREE.Sprite ) {
58377+
|| currentObject instanceof THREE.Sprite || currentObject instanceof THREE.Points ) {
5837858378
currentObject.previousVisibility = currentObject.visible;
5837958379
currentObject.visible = false;
5838058380
}
@@ -58391,7 +58391,7 @@ var ROS3D = (function (exports, ROSLIB) {
5839158391
makeHighlightedVisible(scene) {
5839258392
var makeVisible = function(currentObject) {
5839358393
if ( currentObject instanceof THREE.Mesh || currentObject instanceof THREE.Line
58394-
|| currentObject instanceof THREE.Sprite ) {
58394+
|| currentObject instanceof THREE.Sprite || currentObject instanceof THREE.Points ) {
5839558395
currentObject.visible = true;
5839658396
}
5839758397
};

build/ros3d.min.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/visualization/interaction/Highlighter.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ ROS3D.Highlighter.prototype.renderHighlights = function(scene, renderer, camera)
9494
ROS3D.Highlighter.prototype.makeEverythingInvisible = function (scene) {
9595
scene.traverse(function(currentObject) {
9696
if ( currentObject instanceof THREE.Mesh || currentObject instanceof THREE.Line
97-
|| currentObject instanceof THREE.Sprite ) {
97+
|| currentObject instanceof THREE.Sprite || currentObject instanceof THREE.Points ) {
9898
currentObject.previousVisibility = currentObject.visible;
9999
currentObject.visible = false;
100100
}
@@ -111,7 +111,7 @@ ROS3D.Highlighter.prototype.makeEverythingInvisible = function (scene) {
111111
ROS3D.Highlighter.prototype.makeHighlightedVisible = function (scene) {
112112
var makeVisible = function(currentObject) {
113113
if ( currentObject instanceof THREE.Mesh || currentObject instanceof THREE.Line
114-
|| currentObject instanceof THREE.Sprite ) {
114+
|| currentObject instanceof THREE.Sprite || currentObject instanceof THREE.Points ) {
115115
currentObject.visible = true;
116116
}
117117
};

0 commit comments

Comments
 (0)