Ban function binding (#1076)

* Ban function binding

* Fix missing generic type

Author: EzraBrooks

eslint.config.ts

@@ -31,6 +31,14 @@ export default defineConfig(
       "@typescript-eslint/no-empty-function": 0,
       "prefer-template": 2,
       "@typescript-eslint/consistent-type-imports": 2,
+      "no-restricted-syntax": [
+        "error",
+        {
+          selector: "CallExpression[callee.property.name='bind']",
+          message:
+            "Prefer arrow functions over invoking Function.prototype.bind",
+        },
+      ],
     },
   },
   {

src/core/Action.ts

@@ -125,8 +125,8 @@ export default class Action<
     this.#actionCallback = actionCallback;
     this.#cancelCallback = cancelCallback;
     this.ros.on(this.name, (msg) => {
-      if (isRosbridgeSendActionGoalMessage(msg)) {
-        this.#executeAction.bind(this);
+      if (isRosbridgeSendActionGoalMessage<TGoal>(msg)) {
+        this.#executeAction(msg);
       } else {
         throw new Error(
           "Received unrelated message on Action server event stream!",

src/types/protocol.ts

@@ -260,9 +260,9 @@ export interface RosbridgeSendActionGoalMessage<TArgs = unknown>
   compression?: string;
 }
 
-export function isRosbridgeSendActionGoalMessage(
+export function isRosbridgeSendActionGoalMessage<TArgs = unknown>(
   message: RosbridgeMessageBase,
-): message is RosbridgeSendActionGoalMessage {
+): message is RosbridgeSendActionGoalMessage<TArgs> {
   return message.op === "send_action_goal";
 }