Skip to content

Commit 8085048

Browse files
Add namespace support for the new version of Rosbridge_suite
1 parent 16c44fa commit 8085048

File tree

2 files changed

+19
-18
lines changed

2 files changed

+19
-18
lines changed

src/core/Param.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -36,11 +36,11 @@ export default class Param {
3636
get(callback, failedCallback) {
3737
var paramClient = new Service({
3838
ros: this.ros,
39-
name: 'rosapi/get_param',
39+
name: this.ros.namespace + 'rosapi/get_param',
4040
serviceType: 'rosapi/GetParam'
4141
});
4242

43-
var request = {name: this.name};
43+
var request = { name: this.name };
4444

4545
paramClient.callService(
4646
request,
@@ -69,7 +69,7 @@ export default class Param {
6969
set(value, callback, failedCallback) {
7070
var paramClient = new Service({
7171
ros: this.ros,
72-
name: 'rosapi/set_param',
72+
name: this.ros.namespace + 'rosapi/set_param',
7373
serviceType: 'rosapi/SetParam'
7474
});
7575

@@ -89,7 +89,7 @@ export default class Param {
8989
delete(callback, failedCallback) {
9090
var paramClient = new Service({
9191
ros: this.ros,
92-
name: 'rosapi/delete_param',
92+
name: this.ros.namespace + 'rosapi/delete_param',
9393
serviceType: 'rosapi/DeleteParam'
9494
});
9595

src/core/Ros.js

Lines changed: 15 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@ export default class Ros extends EventEmitter {
2929
idCounter = 0;
3030
isConnected = false;
3131
groovyCompatibility = true;
32+
namespace = '';
3233
/**
3334
* @param {Object} [options]
3435
* @param {string} [options.url] - The WebSocket URL for rosbridge. Can be specified later with `connect`.
@@ -180,7 +181,7 @@ export default class Ros extends EventEmitter {
180181
/** @satisfies {Service<any, any>} */
181182
var getActionServers = new Service({
182183
ros: this,
183-
name: 'rosapi/action_servers',
184+
name: this.namespace + 'rosapi/action_servers',
184185
serviceType: 'rosapi/GetActionServers'
185186
});
186187

@@ -220,7 +221,7 @@ export default class Ros extends EventEmitter {
220221
getTopics(callback, failedCallback) {
221222
var topicsClient = new Service({
222223
ros: this,
223-
name: 'rosapi/topics',
224+
name: this.namespace + 'rosapi/topics',
224225
serviceType: 'rosapi/Topics'
225226
});
226227

@@ -259,7 +260,7 @@ export default class Ros extends EventEmitter {
259260
getTopicsForType(topicType, callback, failedCallback) {
260261
var topicsForTypeClient = new Service({
261262
ros: this,
262-
name: 'rosapi/topics_for_type',
263+
name: this.namespace + 'rosapi/topics_for_type',
263264
serviceType: 'rosapi/TopicsForType'
264265
});
265266

@@ -299,7 +300,7 @@ export default class Ros extends EventEmitter {
299300
getServices(callback, failedCallback) {
300301
var servicesClient = new Service({
301302
ros: this,
302-
name: 'rosapi/services',
303+
name: this.namespace + 'rosapi/services',
303304
serviceType: 'rosapi/Services'
304305
});
305306

@@ -338,7 +339,7 @@ export default class Ros extends EventEmitter {
338339
getServicesForType(serviceType, callback, failedCallback) {
339340
var servicesForTypeClient = new Service({
340341
ros: this,
341-
name: 'rosapi/services_for_type',
342+
name: this.namespace + 'rosapi/services_for_type',
342343
serviceType: 'rosapi/ServicesForType'
343344
});
344345

@@ -380,7 +381,7 @@ export default class Ros extends EventEmitter {
380381
getServiceRequestDetails(type, callback, failedCallback) {
381382
var serviceTypeClient = new Service({
382383
ros: this,
383-
name: 'rosapi/service_request_details',
384+
name: this.namespace + 'rosapi/service_request_details',
384385
serviceType: 'rosapi/ServiceRequestDetails'
385386
});
386387
var request = {
@@ -422,7 +423,7 @@ export default class Ros extends EventEmitter {
422423
/** @satisfies {Service<{},{typedefs: string[]}>} */
423424
var serviceTypeClient = new Service({
424425
ros: this,
425-
name: 'rosapi/service_response_details',
426+
name: this.namespace + 'rosapi/service_response_details',
426427
serviceType: 'rosapi/ServiceResponseDetails'
427428
});
428429
var request = {
@@ -462,7 +463,7 @@ export default class Ros extends EventEmitter {
462463
getNodes(callback, failedCallback) {
463464
var nodesClient = new Service({
464465
ros: this,
465-
name: 'rosapi/nodes',
466+
name: this.namespace + 'rosapi/nodes',
466467
serviceType: 'rosapi/Nodes'
467468
});
468469

@@ -522,7 +523,7 @@ export default class Ros extends EventEmitter {
522523
getNodeDetails(node, callback, failedCallback) {
523524
var nodesClient = new Service({
524525
ros: this,
525-
name: 'rosapi/node_details',
526+
name: this.namespace + 'rosapi/node_details',
526527
serviceType: 'rosapi/NodeDetails'
527528
});
528529

@@ -563,7 +564,7 @@ export default class Ros extends EventEmitter {
563564
getParams(callback, failedCallback) {
564565
var paramsClient = new Service({
565566
ros: this,
566-
name: 'rosapi/get_param_names',
567+
name: this.namespace + 'rosapi/get_param_names',
567568
serviceType: 'rosapi/GetParamNames'
568569
});
569570
var request = {};
@@ -601,7 +602,7 @@ export default class Ros extends EventEmitter {
601602
getTopicType(topic, callback, failedCallback) {
602603
var topicTypeClient = new Service({
603604
ros: this,
604-
name: 'rosapi/topic_type',
605+
name: this.namespace + 'rosapi/topic_type',
605606
serviceType: 'rosapi/TopicType'
606607
});
607608
var request = {
@@ -642,7 +643,7 @@ export default class Ros extends EventEmitter {
642643
getServiceType(service, callback, failedCallback) {
643644
var serviceTypeClient = new Service({
644645
ros: this,
645-
name: 'rosapi/service_type',
646+
name: this.namespace + 'rosapi/service_type',
646647
serviceType: 'rosapi/ServiceType'
647648
});
648649
var request = {
@@ -683,7 +684,7 @@ export default class Ros extends EventEmitter {
683684
getMessageDetails(message, callback, failedCallback) {
684685
var messageDetailClient = new Service({
685686
ros: this,
686-
name: 'rosapi/message_details',
687+
name: this.namespace + 'rosapi/message_details',
687688
serviceType: 'rosapi/MessageDetails'
688689
});
689690
var request = {
@@ -775,7 +776,7 @@ export default class Ros extends EventEmitter {
775776
getTopicsAndRawTypes(callback, failedCallback) {
776777
var topicsAndRawTypesClient = new Service({
777778
ros: this,
778-
name: 'rosapi/topics_and_raw_types',
779+
name: this.namespace + 'rosapi/topics_and_raw_types',
779780
serviceType: 'rosapi/TopicsAndRawTypes'
780781
});
781782

0 commit comments

Comments
 (0)