Enable noImplicitOverride (#1045)

Author: EzraBrooks

src/tf/ROS2TFClient.ts

@@ -31,7 +31,7 @@ export default class ROS2TFClient extends BaseTFClient {
    * Create and send a new goal (or service request) to the tf2_web_republisher
    * based on the current list of TFs.
    */
-  updateGoal() {
+  override updateGoal() {
     const goalMessage = {
       source_frames: Object.keys(this.frameInfos),
       target_frame: this.fixedFrame,

src/tf/TFClient.ts

@@ -59,7 +59,7 @@ export default class TFClient extends BaseTFClient {
    * Create and send a new goal (or service request) to the tf2_web_republisher
    * based on the current list of TFs.
    */
-  updateGoal() {
+  override updateGoal() {
     const goalMessage: tf2_web_republisher.TFSubscriptionGoal = {
       source_frames: Object.keys(this.frameInfos),
       target_frame: this.fixedFrame,

tsconfig.build.json

@@ -41,11 +41,11 @@
     "strictBindCallApply": true /* Check that the arguments for `bind`, `call`, and `apply` methods match the original function. */,
     "strictBuiltinIteratorReturn": true /* Built-in iterators are instantiated with a 'TReturn' type of 'undefined' instead of 'any'. */,
     "useUnknownInCatchVariables": true /* Default catch clause variables as `unknown` instead of `any`. */,
+    "noImplicitOverride": true /* Ensure overriding members in derived classes are marked with an override modifier. */,
 
     /* Rules to be enabled */
     "exactOptionalPropertyTypes": false /* Differentiate between undefined and not present when type checking */,
     "noImplicitAny": false /* Enable error reporting for expressions and declarations with an implied 'any' type. */,
-    "noImplicitOverride": false /* Ensure overriding members in derived classes are marked with an override modifier. */,
     "noUncheckedIndexedAccess": false /* Add `undefined` to a type when accessed using an index. */,
     "strictFunctionTypes": false /* When assigning functions, check to ensure parameters and the return values are subtype-compatible. */,
     "strictPropertyInitialization": false /* Check for class properties that are declared but not set in the constructor. */,