Fix JSON encoding of double parameter values #903
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EzraBrooks
reviewed
Aug 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Public API Changes
Adds an optional parameter
numberTypeHintto hint when parameter values should be encoded as doublesDescription
JSON stringification will cause a whole double value (e.g. 1.0) to be encoded as an int value ("1"). This will cause a rejection from the ros2 parameter service call unless dynamic typing is enabled, because it incorrectly interprets it as an int when the parameter type is Double.
This PR adds a JSON replacer to the parameter encode to make sure that even if it's whole it has a decimal point.