Skip to content

Commit 7ec6a2f

Browse files
Review changes
Signed-off-by: Aleksander Kamiński <[email protected]>
1 parent 54e60db commit 7ec6a2f

File tree

2 files changed

+6
-4
lines changed

2 files changed

+6
-4
lines changed

Code/Source/Utilities/BlockCompression.h

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,21 +14,23 @@
1414
*/
1515

1616
#pragma once
17-
#include <AzCore/Math/Color.h>
1817
#include <Atom/RPI.Public/BlockCompression.h>
18+
#include <AzCore/Math/Color.h>
1919
#include <AzCore/base.h>
2020

2121
namespace RGL::Utils
2222
{
23+
//! Structure used for decompressing images compressed using BC3.
24+
//! To learn more about BC3 compression see
25+
//! https://learn.microsoft.com/en-us/windows/win32/direct3d10/d3d10-graphics-programming-guide-resources-block-compression#bc3.
2326
struct BC3Block
2427
{
2528
static AZStd::pair<size_t, size_t> GetBlockIndices(uint32_t width, uint32_t x, uint32_t y);
2629

2730
[[nodiscard]] AZ::Color GetBlockColor(size_t pixelIndex) const;
2831
[[nodiscard]] AZ::u8 GetAlpha(size_t pixelIndex) const;
2932

30-
union
31-
{
33+
union {
3234
AZ::u64 m_alphaData;
3335
struct
3436
{

Code/Source/Wrappers/RglTexture.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -166,7 +166,7 @@ namespace RGL::Wrappers
166166
AZ_Warning(
167167
ConstructTraceWindowName(__func__).c_str(),
168168
false,
169-
"Image \"%s\" is of unsupported type: %s. Only BC1 and BC4 formats are currently supported. Skipping...",
169+
"Image \"%s\" is of unsupported type: %s. Only BC1, BC3 and BC4 formats are currently supported. Skipping...",
170170
imageAsset.ToString<AZStd::string>().c_str(),
171171
ToString(imageDescriptor.m_format));
172172
}

0 commit comments

Comments
 (0)