Bugfix for MultiDeviceSwapChain which did not properly recreate images (o3de#17648)

Signed-off-by: Martin Winter <[email protected]>
Co-authored-by: Martin Winter <[email protected]>

Author: jhmueller-huawei

Gems/Atom/RHI/Code/Include/Atom/RHI/SwapChain.h

@@ -75,7 +75,8 @@ namespace AZ::RHI
 
         //! Recreate the swapchain if it becomes invalid during presenting. This should happen at the end of the frame
         //! due to images being used as attachments in the frame graph.
-        virtual void ProcessRecreation() {};
+        virtual bool ProcessRecreation(){ return false; };
+
     protected:
         SwapChain();
 

Gems/Atom/RHI/Code/Source/RHI/MultiDeviceSwapChain.cpp

@@ -238,10 +238,18 @@ namespace AZ::RHI
 
     void MultiDeviceSwapChain::ProcessRecreation()
     {
-        IterateObjects<SwapChain>([]([[maybe_unused]] auto deviceIndex, auto deviceSwapChain)
+        auto recreated{ false };
+        IterateObjects<SwapChain>(
+            [&recreated]([[maybe_unused]] auto deviceIndex, auto deviceSwapChain)
+            {
+                recreated = deviceSwapChain->ProcessRecreation();
+            });
+
+        if (recreated)
         {
-            deviceSwapChain->ProcessRecreation();
-        });
+            ShutdownImages();
+            InitImages();
+        }
     }
 
     uint32_t MultiDeviceSwapChain::GetImageCount() const

Gems/Atom/RHI/Vulkan/Code/Source/RHI/SwapChain.cpp

@@ -70,7 +70,7 @@ namespace AZ
             m_swapChainBarrier.m_isValid = true;
         }
 
-        void SwapChain::ProcessRecreation()
+        bool SwapChain::ProcessRecreation()
         {
             if (m_pendingRecreation)
             {
@@ -82,7 +82,9 @@ namespace AZ
                 InitImages();
 
                 m_pendingRecreation = false;
+                return true;
             }
+            return false;
         }
 
         void SwapChain::SetVerticalSyncIntervalInternal(uint32_t previousVsyncInterval)

Gems/Atom/RHI/Vulkan/Code/Source/RHI/SwapChain.h

@@ -51,7 +51,7 @@ namespace AZ
 
             void QueueBarrier(const VkPipelineStageFlags src, const VkPipelineStageFlags dst, const VkImageMemoryBarrier& imageBarrier);
 
-            void ProcessRecreation() override;
+            bool ProcessRecreation() override;
         private:
             SwapChain() = default;