Fixes the bug causing asset browser to be unable to delete/move/etc. (o3de#17568)

* Fixes o3de#15671 - [Bug Report] Asset Browser cannot delete asset
* Adds missing functionality from the Linux ProcessWatcher to indicate
  the difference between a different problem launching program, and
  the program not being found.
* Fixes the workflow of the Move/Delete/Rename operations in the Asset
  Browser to properly return the appropriate error when Source Control
  is not properly configured.
* Adds a toggle for source control notification in AP, so that if you
  toggle the Editor to not use Source Control, the AP will not either.
* Uses the same setting in AP as the Editor, to determine whether Source
  Control should be used or not, and sets it to false by default, just
  like the Editor.

Signed-off-by: Nicholas Lawson <[email protected]>

Author: nick-l-o3de

Code/Editor/MainStatusBar.cpp

@@ -12,6 +12,8 @@
 #include "MainStatusBar.h"
 
 #include <AzCore/Utils/Utils.h>
+#include <AzFramework/Asset/AssetSystemBus.h>
+
 // AzQtComponents
 #include <AzQtComponents/Components/Widgets/CheckBox.h>
 #include <AzQtComponents/Components/Style.h>
@@ -305,8 +307,21 @@ void SourceControlItem::UpdateAndShowMenu()
 
 void SourceControlItem::ConnectivityStateChanged(const AzToolsFramework::SourceControlState state)
 {
+    AzToolsFramework::SourceControlState oldState = m_SourceControlState;
     m_SourceControlState = state;
     UpdateMenuItems();
+
+    if (oldState != m_SourceControlState)
+    {
+        // if the user has turned the system on or off, signal the asset processor
+        // we know the user has turned the system off if the old state was disabled
+        // or if the new state is disabled (when the state changed)
+        if ((oldState == AzToolsFramework::SourceControlState::Disabled) || (m_SourceControlState == AzToolsFramework::SourceControlState::Disabled))
+        {
+            bool enabled = m_SourceControlState != AzToolsFramework::SourceControlState::Disabled;
+            AzFramework::AssetSystemRequestBus::Broadcast(&AzFramework::AssetSystem::AssetSystemRequests::UpdateSourceControlStatus, enabled);
+        }
+    }
 }
 
 void SourceControlItem::InitMenu()
@@ -342,7 +357,19 @@ void SourceControlItem::InitMenu()
 
         connect(m_settingsAction, &QAction::triggered, this, [&]()
         {
-            GetIEditor()->GetSourceControl()->ShowSettings();
+            // LEGACY note - GetIEditor and GetSourceControl are both legacy functions
+            // but are currently the only way to actually show the source control settings.
+            // They come from an editor plugin which should be moved to a gem eventually instead.
+            // For now, the actual function of the p4 plugin (so for example, checking file status, checking out files, etc)
+            // lives in AzToolsFramework, and is always available,
+            // but the settings dialog lives in the plugin, which is not always available, on all platforms, and thus
+            // this pointer could be null despite P4 still functioning.  (For example, it can function via command line on linux,
+            // and its settings can come from the P4 ENV or P4 Client env, without having to show the GUI).  Therefore
+            // it is still valid to have m_sourceControlAvailable be true yet GetIEditor()->GetSourceControl() be null.
+            if (auto sourceControl = GetIEditor()->GetSourceControl())
+            {
+                sourceControl->ShowSettings();
+            }
         });
 
         connect(m_checkBox, &QCheckBox::stateChanged, this, [this](int state) {SetSourceControlEnabledState(state); });
@@ -367,6 +394,7 @@ void SourceControlItem::UpdateMenuItems()
     QString toolTip;
     bool disabled = false;
     bool errorIcon = false;
+    bool invalidConfig = false;
 
     switch (m_SourceControlState)
     {
@@ -377,6 +405,7 @@ void SourceControlItem::UpdateMenuItems()
         break;
     case AzToolsFramework::SourceControlState::ConfigurationInvalid:
         errorIcon = true;
+        invalidConfig = true;
         toolTip = tr("Perforce configuration invalid");
         break;
     case AzToolsFramework::SourceControlState::Active:
@@ -386,7 +415,7 @@ void SourceControlItem::UpdateMenuItems()
 
     m_settingsAction->setEnabled(!disabled);
     m_checkBox->setChecked(!disabled);
-    m_checkBox->setText(disabled ? tr("Status: Offline") : tr("Status: Online"));
+    m_checkBox->setText(disabled ? tr("Status: Offline") : invalidConfig ? tr("Status: Invalid Configuration - check the console log") : tr("Status: Online"));
     SetIcon(errorIcon ? disabled ? m_scIconDisabled : m_scIconWarning : m_scIconOk);
     SetToolTip(toolTip);
 }

Code/Editor/Plugins/PerforcePlugin/Platform/Linux/PAL_linux.cmake

@@ -6,4 +6,4 @@
 #
 #
 
-set(PAL_TRAIT_BUILD_P4PLUGIN_SUPPORTED FALSE)
+set(PAL_TRAIT_BUILD_P4PLUGIN_SUPPORTED TRUE)

Code/Framework/AzFramework/AzFramework/Asset/AssetProcessorMessages.cpp

@@ -621,6 +621,26 @@ namespace AzFramework
 
         //---------------------------------------------------------------------
 
+        unsigned int UpdateSourceControlStatusRequest::GetMessageType() const
+        {
+            return MessageType;
+        }
+
+        void UpdateSourceControlStatusRequest::Reflect(AZ::ReflectContext* context)
+        {
+            auto serialize = azrtti_cast<AZ::SerializeContext*>(context);
+            if (serialize)
+            {
+                serialize->Class<UpdateSourceControlStatusRequest>()
+                    ->Version(1)
+                    ->Field("SourceControlEnabled", &UpdateSourceControlStatusRequest::m_sourceControlEnabled);
+            }
+        }
+
+        //---------------------------------------------------------------------
+
+        //---------------------------------------------------------------------
+
         unsigned int ShowAssetInAssetProcessorRequest::GetMessageType() const
         {
             return MessageType;
@@ -1543,8 +1563,9 @@ namespace AzFramework
             }
         }
 
-        AssetChangeReportResponse::AssetChangeReportResponse(AZStd::vector<AZStd::string> lines)
+        AssetChangeReportResponse::AssetChangeReportResponse(AZStd::vector<AZStd::string> lines, bool success)
             : m_lines(lines)
+            , m_success(success)
         {
         }
 
@@ -1559,8 +1580,9 @@ namespace AzFramework
             if (serialize)
             {
                 serialize->Class<AssetChangeReportResponse, BaseAssetProcessorMessage>()
-                    ->Version(1)
-                    ->Field("Report", &AssetChangeReportResponse::m_lines);
+                    ->Version(2)
+                    ->Field("Report", &AssetChangeReportResponse::m_lines)
+                    ->Field("Success", &AssetChangeReportResponse::m_success);
             }
         }
 

Code/Framework/AzFramework/AzFramework/Asset/AssetProcessorMessages.h

@@ -573,6 +573,23 @@ namespace AzFramework
             unsigned int GetMessageType() const override;
         };
 
+        //! Sent from any tool to the AP, notifying it to toggle the state of source control to either on or off.
+        //! This avoids the need for AP to restart.
+        class UpdateSourceControlStatusRequest
+            : public BaseAssetProcessorMessage
+        {
+        public:
+            AZ_CLASS_ALLOCATOR(UpdateSourceControlStatusRequest, AZ::OSAllocator);
+            AZ_RTTI(UpdateSourceControlStatusRequest, "{B313400A-3E5D-496F-BD91-09B9C10EBDF0}", BaseAssetProcessorMessage);
+            static void Reflect(AZ::ReflectContext* context);
+            static constexpr unsigned int MessageType = AZ_CRC("AssetSystem::UpdateSourceControlStatusRequest", 0x42f7a516);
+
+            UpdateSourceControlStatusRequest() = default;
+            unsigned int GetMessageType() const override;
+
+            bool m_sourceControlEnabled = false;
+        };
+
         //////////////////////////////////////////////////////////////////////////
         //ShowAssetInAssetProcessorRequest
         class ShowAssetInAssetProcessorRequest
@@ -1310,10 +1327,11 @@ namespace AzFramework
 
             // The default constructor is only required for the SerializeContext.
             AssetChangeReportResponse() = default;
-            AssetChangeReportResponse(AZStd::vector<AZStd::string> lines);
+            AssetChangeReportResponse(AZStd::vector<AZStd::string> lines, bool success);
             unsigned int GetMessageType() const override;
 
             AZStd::vector<AZStd::string> m_lines;
+            bool m_success = false;
         };
 
     } // namespace AssetSystem

Code/Framework/AzFramework/AzFramework/Asset/AssetSystemBus.h

@@ -268,6 +268,7 @@ namespace AzFramework
 
             //! Show the AssetProcessor App
             virtual void ShowAssetProcessor() = 0;
+            virtual void UpdateSourceControlStatus(bool newStatus) = 0;
             //! Show an asset in the AssetProcessor App
             virtual void ShowInAssetProcessor(const AZStd::string& assetPath) = 0;
 

Code/Framework/AzFramework/AzFramework/Asset/AssetSystemComponent.cpp

@@ -264,6 +264,7 @@ namespace AzFramework
             RegisterSourceAssetRequest::Reflect(context);
             UnregisterSourceAssetRequest::Reflect(context);
             ShowAssetProcessorRequest::Reflect(context);
+            UpdateSourceControlStatusRequest::Reflect(context);
             ShowAssetInAssetProcessorRequest::Reflect(context);
             FileOpenRequest::Reflect(context);
             FileCloseRequest::Reflect(context);

Code/Framework/AzFramework/AzFramework/Asset/AssetSystemComponent.h

@@ -147,6 +147,7 @@ namespace AzFramework
             bool EscalateAssetBySearchTerm(AZStd::string_view searchTerm) override;
 
             void ShowAssetProcessor() override;
+            void UpdateSourceControlStatus(bool newStatus) override;
             void ShowInAssetProcessor(const AZStd::string& assetPath) override;
 
             void GetUnresolvedProductReferences(AZ::Data::AssetId assetId, AZ::u32& unresolvedAssetIdReferences, AZ::u32& unresolvedPathReferences) override;

Code/Framework/AzFramework/AzFramework/Asset/AssetSystemComponentHelper.cpp

@@ -43,6 +43,13 @@ namespace AzFramework
             SendRequest(request);
         }
 
+        void AssetSystemComponent::UpdateSourceControlStatus(bool newStatus)
+        {
+            UpdateSourceControlStatusRequest request;
+            request.m_sourceControlEnabled = newStatus;
+            SendRequest(request);
+        }
+
         void AssetSystemComponent::ShowInAssetProcessor(const AZStd::string& assetPath)
         {
             AllowAssetProcessorToForeground();

Code/Framework/AzFramework/Platform/Linux/AzFramework/Process/ProcessWatcher_Linux.cpp

@@ -368,6 +368,10 @@ namespace AzFramework
             {
                 AZ_TracePrintf("Process Watcher", "ProcessLauncher::LaunchProcess: Unable to launch process %s : errno = %s\n", commandAndArgs[0], strerror(errorCodeFromChild));
                 processData.m_childProcessIsDone = true;
+                if (errorCodeFromChild == ENOENT)
+                {
+                    processLaunchInfo.m_launchResult = PLR_MissingFile; // Note for future maintainers, m_launchResult is mutable
+                }
                 child_pid = -1;
             }
         }
@@ -382,7 +386,13 @@ namespace AzFramework
         delete [] commandAndArgs;
 
         // If an error occurs, exit the application.
-        return child_pid >= 0;
+        if (child_pid >= 0)
+        {
+            processLaunchInfo.m_launchResult = PLR_Success; // Note for future maintainers, m_launchResult is mutable
+            return true;
+        }
+        
+        return false;
     }
 
     StdProcessCommunicator* ProcessWatcher::CreateStdCommunicator()

Code/Framework/AzQtComponents/AzQtComponents/Components/Widgets/AssetFolderThumbnailView.cpp

@@ -275,22 +275,24 @@ namespace AzQtComponents
         QLineEdit* lineEdit = qobject_cast<QLineEdit*>(widget);
         if (lineEdit)
         {
-            connect(
-                lineEdit,
-                &QLineEdit::editingFinished,
-                this,
-                [this]()
-                {
-                    auto sendingLineEdit = qobject_cast<QLineEdit*>(sender());
-                    if (sendingLineEdit)
-                    {
-                        emit RenameThumbnail(sendingLineEdit->text());
-                    }
-                });
+            connect(lineEdit, &QLineEdit::editingFinished, this, &AssetFolderThumbnailViewDelegate::editingFinished);
         }
         return widget;
     }
 
+    void AssetFolderThumbnailViewDelegate::editingFinished()
+    {
+        if (auto sendingLineEdit = qobject_cast<QLineEdit*>(sender()); sendingLineEdit)
+        {
+            // debounce this call by disconnecting from the signal immediately.
+            // This is because editingFinished is triggered repeatedly, for example,
+            // when the user presses enter but also when the line edit loses focus.  
+            // If the user presses enter, both happen, causing a double send if we don't debounce like this.
+            QObject::disconnect(sendingLineEdit, &QLineEdit::editingFinished, this, &AssetFolderThumbnailViewDelegate::editingFinished); 
+            emit RenameThumbnail(sendingLineEdit->text());
+        }
+    }
+
     void AssetFolderThumbnailViewDelegate::updateEditorGeometry(QWidget* editor, const QStyleOptionViewItem& option, const QModelIndex& index) const
     {
         if (QLineEdit* lineEdit = qobject_cast<QLineEdit*>(editor))