Skip to content

Commit bcb096d

Browse files
gralcogralco
committed
MiniAudio: Make script node parameter names consistent with method names
* Change Get & Set Fixed Direction tooltips to use lowercase letters per MR request Signed-off-by: Eric Kuzmenko <[email protected]>
1 parent b0c890b commit bcb096d

File tree

4 files changed

+27
-27
lines changed

4 files changed

+27
-27
lines changed

‎Gems/MiniAudio/Code/Source/Clients/MiniAudioListenerComponent.cpp‎

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -41,10 +41,10 @@ namespace MiniAudio
4141
->Attribute(AZ::Script::Attributes::Scope, AZ::Script::Attributes::ScopeFlags::Common);
4242

4343
AZ::BehaviorParameterOverrides GetChannelCountParam = {"Channel Count", "Get Channel Count"};
44-
AZ::BehaviorParameterOverrides GetGlobalVolumeParam = {"Global Volume", "Get Percent Global Volume"};
45-
AZ::BehaviorParameterOverrides SetGlobalVolumeParam = {"Global Volume", "Set Percent Global Volume"};
46-
AZ::BehaviorParameterOverrides GetGlobalVolumeDecibelsParam = {"Global Volume Decibels", "Get Decibels Global Volume"};
47-
AZ::BehaviorParameterOverrides SetGlobalVolumeDecibelsParam = {"Global Volume Decibels", "Set Decibels Global Volume"};
44+
AZ::BehaviorParameterOverrides GetGlobalVolumeParam = {"Global Volume", "Get Global Volume Percent"};
45+
AZ::BehaviorParameterOverrides SetGlobalVolumeParam = {"Global Volume", "Set Global Volume Percent"};
46+
AZ::BehaviorParameterOverrides GetGlobalVolumeDecibelsParam = {"Global Volume Decibels", "Get Global Volume Decibels"};
47+
AZ::BehaviorParameterOverrides SetGlobalVolumeDecibelsParam = {"Global Volume Decibels", "Set Global Volume Decibels"};
4848
AZ::BehaviorParameterOverrides GetInnerConeAngleInRadiansParam = {"Inner Cone Angle In Radians", "Get Inner Cone Angle In Radians"};
4949
AZ::BehaviorParameterOverrides SetInnerConeAngleInRadiansParam = {"Inner Cone Angle In Radians", "Set Inner Cone Angle In Radians"};
5050
AZ::BehaviorParameterOverrides GetInnerConeAngleInDegreesParam = {"Inner Cone Angle In Degrees", "Get Inner Cone Angle In Degrees"};
@@ -53,10 +53,10 @@ namespace MiniAudio
5353
AZ::BehaviorParameterOverrides SetOuterConeAngleInRadiansParam = {"Outer Cone Angle In Radians", "Set Outer Cone Angle In Radians"};
5454
AZ::BehaviorParameterOverrides GetOuterConeAngleInDegreesParam = {"Outer Cone Angle In Degrees", "Get Outer Cone Angle In Degrees"};
5555
AZ::BehaviorParameterOverrides SetOuterConeAngleInDegreesParam = {"Outer Cone Angle In Degrees", "Set Outer Cone Angle In Degrees"};
56-
AZ::BehaviorParameterOverrides GetOuterVolumeParam = {"Outer Volume", "Get Percent Volume Outside Outer Cone"};
57-
AZ::BehaviorParameterOverrides SetOuterVolumeParam = {"Outer Volume", "Set Percent Volume Outside Outer Cone"};
58-
AZ::BehaviorParameterOverrides GetOuterVolumeDecibelsParam = {"Outer Volume Decibels", "Get Decibels Volume Outside Outer Cone"};
59-
AZ::BehaviorParameterOverrides SetOuterVolumeDecibelsParam = {"Outer Volume Decibels", "Set Decibels Volume Outside Outer Cone"};
56+
AZ::BehaviorParameterOverrides GetOuterVolumeParam = {"Outer Volume", "Get Volume Percent Outside Outer Cone"};
57+
AZ::BehaviorParameterOverrides SetOuterVolumeParam = {"Outer Volume", "Set Volume Percent Outside Outer Cone"};
58+
AZ::BehaviorParameterOverrides GetOuterVolumeDecibelsParam = {"Outer Volume Decibels", "Get Volume Decibels Outside Outer Cone"};
59+
AZ::BehaviorParameterOverrides SetOuterVolumeDecibelsParam = {"Outer Volume Decibels", "Set Volume Decibels Outside Outer Cone"};
6060
behaviorContext->EBus<MiniAudioListenerRequestBus>("MiniAudioListenerRequestBus")
6161
->Attribute(AZ::Script::Attributes::Scope, AZ::Script::Attributes::ScopeFlags::Common)
6262
->Attribute(AZ::Script::Attributes::Module, "audio")

‎Gems/MiniAudio/Code/Source/Clients/MiniAudioPlaybackComponent.cpp‎

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -46,10 +46,10 @@ namespace MiniAudio
4646
->Attribute(AZ::Script::Attributes::Module, "MiniAudio")
4747
->Attribute(AZ::Script::Attributes::Scope, AZ::Script::Attributes::ScopeFlags::Common);
4848

49-
AZ::BehaviorParameterOverrides GetVolumeParam = {"Volume", "Get Percent Volume"};
50-
AZ::BehaviorParameterOverrides SetVolumeParam = {"Volume", "Set Percent Volume"};
51-
AZ::BehaviorParameterOverrides GetVolumeDecibelsParam = {"Volume Decibels", "Get Decibels Volume"};
52-
AZ::BehaviorParameterOverrides SetVolumeDecibelsParam = {"Volume Decibels", "Set Decibels Volume"};
49+
AZ::BehaviorParameterOverrides GetVolumeParam = {"Volume", "Get Volume Percent"};
50+
AZ::BehaviorParameterOverrides SetVolumeParam = {"Volume", "Set Volume Percent"};
51+
AZ::BehaviorParameterOverrides GetVolumeDecibelsParam = {"Volume Decibels", "Get Volume Decibels"};
52+
AZ::BehaviorParameterOverrides SetVolumeDecibelsParam = {"Volume Decibels", "Set Volume Decibels"};
5353
AZ::BehaviorParameterOverrides GetInnerConeAngleInRadiansParam = {"Inner Cone Angle In Radians", "Get Inner Cone Angle In Radians"};
5454
AZ::BehaviorParameterOverrides SetInnerConeAngleInRadiansParam = {"Inner Cone Angle In Radians", "Set Inner Cone Angle In Radians"};
5555
AZ::BehaviorParameterOverrides GetInnerConeAngleInDegreesParam = {"Inner Cone Angle In Degrees", "Get Inner Cone Angle In Degrees"};
@@ -58,12 +58,12 @@ namespace MiniAudio
5858
AZ::BehaviorParameterOverrides SetOuterConeAngleInRadiansParam = {"Outer Cone Angle In Radians", "Set Outer Cone Angle In Radians"};
5959
AZ::BehaviorParameterOverrides GetOuterConeAngleInDegreesParam = {"Outer Cone Angle In Degrees", "Get Outer Cone Angle In Degrees"};
6060
AZ::BehaviorParameterOverrides SetOuterConeAngleInDegreesParam = {"Outer Cone Angle In Degrees", "Set Outer Cone Angle In Degrees"};
61-
AZ::BehaviorParameterOverrides GetOuterVolumeParam = {"Outer Volume", "Get Percent Volume Outside Outer Cone"};
62-
AZ::BehaviorParameterOverrides SetOuterVolumeParam = {"Outer Volume", "Set Percent Volume Outside Outer Cone"};
63-
AZ::BehaviorParameterOverrides GetOuterVolumeDecibelsParam = {"Outer Volume Decibels", "Get Decibels Volume Outside Outer Cone"};
64-
AZ::BehaviorParameterOverrides SetOuterVolumeDecibelsParam = {"Outer Volume Decibels", "Set Decibels Volume Outside Outer Cone"};
65-
AZ::BehaviorParameterOverrides GetFixedDirectionParam = {"Fixed Direction", "Get Whether Direction Is Fixed"};
66-
AZ::BehaviorParameterOverrides SetFixedDirectionParam = {"Fixed Direction", "Set Whether Direction Is Fixed"};
61+
AZ::BehaviorParameterOverrides GetOuterVolumeParam = {"Outer Volume", "Get Volume Percent Outside Outer Cone"};
62+
AZ::BehaviorParameterOverrides SetOuterVolumeParam = {"Outer Volume", "Set Volume Percent Outside Outer Cone"};
63+
AZ::BehaviorParameterOverrides GetOuterVolumeDecibelsParam = {"Outer Volume Decibels", "Get Volume Decibels Outside Outer Cone"};
64+
AZ::BehaviorParameterOverrides SetOuterVolumeDecibelsParam = {"Outer Volume Decibels", "Set Volume Decibels Outside Outer Cone"};
65+
AZ::BehaviorParameterOverrides GetFixedDirectionParam = {"Fixed Direction", "Get whether Direction is fixed"};
66+
AZ::BehaviorParameterOverrides SetFixedDirectionParam = {"Fixed Direction", "Set whether Direction is fixed"};
6767
AZ::BehaviorParameterOverrides GetDirectionalAttenuationFactorParam = {"Directional Attenuation Factor", "Get Directional Attenuation Factor"};
6868
AZ::BehaviorParameterOverrides SetDirectionalAttenuationFactorParam = {"Directional Attenuation Factor", "Set Directional Attenuation Factor"};
6969
AZ::BehaviorParameterOverrides GetDirectionParam = {"Direction", "Get Playback Direction"};

‎Gems/ScriptCanvas/Assets/TranslationAssets/EBus/Senders/MiniAudioListenerRequestBus.names‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@
7373
"typeid": "{EA2C3E90-AFBE-44D4-A90D-FAAF79BAF93D}",
7474
"details": {
7575
"name": "Outer Volume Decibels",
76-
"tooltip": "Set Decibels Volume Outside Outer Cone"
76+
"tooltip": "Set Volume Decibels Outside Outer Cone"
7777
}
7878
}
7979
]
@@ -143,7 +143,7 @@
143143
"typeid": "{EA2C3E90-AFBE-44D4-A90D-FAAF79BAF93D}",
144144
"details": {
145145
"name": "Global Volume Decibels",
146-
"tooltip": "Set Decibels Global Volume"
146+
"tooltip": "Set Global Volume Decibels"
147147
}
148148
}
149149
]
@@ -190,7 +190,7 @@
190190
"typeid": "{EA2C3E90-AFBE-44D4-A90D-FAAF79BAF93D}",
191191
"details": {
192192
"name": "Outer Volume",
193-
"tooltip": "Set Percent Volume Outside Outer Cone"
193+
"tooltip": "Set Volume Percent Outside Outer Cone"
194194
}
195195
}
196196
]
@@ -214,7 +214,7 @@
214214
"typeid": "{EA2C3E90-AFBE-44D4-A90D-FAAF79BAF93D}",
215215
"details": {
216216
"name": "Global Volume",
217-
"tooltip": "Set Percent Global Volume"
217+
"tooltip": "Set Global Volume Percent"
218218
}
219219
}
220220
]

‎Gems/ScriptCanvas/Assets/TranslationAssets/EBus/Senders/MiniAudioPlaybackRequestBus.names‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@
5050
"typeid": "{EA2C3E90-AFBE-44D4-A90D-FAAF79BAF93D}",
5151
"details": {
5252
"name": "Outer Volume",
53-
"tooltip": "Set Percent Volume Outside Outer Cone"
53+
"tooltip": "Set Volume Percent Outside Outer Cone"
5454
}
5555
}
5656
]
@@ -97,7 +97,7 @@
9797
"typeid": "{EA2C3E90-AFBE-44D4-A90D-FAAF79BAF93D}",
9898
"details": {
9999
"name": "Volume",
100-
"tooltip": "Set Percent Volume"
100+
"tooltip": "Set Volume Percent"
101101
}
102102
}
103103
]
@@ -121,7 +121,7 @@
121121
"typeid": "{EA2C3E90-AFBE-44D4-A90D-FAAF79BAF93D}",
122122
"details": {
123123
"name": "Volume Decibels",
124-
"tooltip": "Set Decibels Volume"
124+
"tooltip": "Set Volume Decibels"
125125
}
126126
}
127127
]
@@ -191,7 +191,7 @@
191191
"typeid": "{A0CA880C-AFE4-43CB-926C-59AC48496112}",
192192
"details": {
193193
"name": "Fixed Direction",
194-
"tooltip": "Set Whether Direction Is Fixed"
194+
"tooltip": "Set whether Direction is fixed"
195195
}
196196
}
197197
]
@@ -427,7 +427,7 @@
427427
"typeid": "{EA2C3E90-AFBE-44D4-A90D-FAAF79BAF93D}",
428428
"details": {
429429
"name": "Outer Volume Decibels",
430-
"tooltip": "Set Decibels Volume Outside Outer Cone"
430+
"tooltip": "Set Volume Decibels Outside Outer Cone"
431431
}
432432
}
433433
]

0 commit comments

Comments
 (0)