The Editor does not crash if UIPass doesn't exist (o3de#17651)

* The Editor does not crash if UIPass doesn't exist

1. Improved DynamicDrawContext.cpp by replacing `AZ_Asserts` with `AZ_WarningOnce`.
   This allows graphics developers to use render pipelines that do not include the `UIPass`.

2. Replaced several deprecation `AZ_Warning` for `AZ_WarningOnce` in `Application.cpp`
   because they were overwhelming the console with the message:
   "'IsPrefabSystemEnabled' is deprecated, the editor only supports prefabs for level editing."

3. Add comment in `Gems/Atom/RHI/Vulkan/Code/Source/RHI/RenderPass.h`, on top of the function:
   `static Descriptor ConvertRenderAttachmentLayout`. This is a breadcrumb for RHI developers
   on what's the ultimate purpose of this function.

---------

Signed-off-by: galibzon <[email protected]>

Author: galibzon

Code/Framework/AzFramework/AzFramework/Application/Application.cpp

@@ -770,7 +770,7 @@ namespace AzFramework
 
     bool Application::IsPrefabSystemEnabled() const
     {
-        AZ_Warning("Application", false, "'IsPrefabSystemEnabled' is deprecated, the editor only supports prefabs for level editing.");
+        AZ_WarningOnce("Application", false, "'IsPrefabSystemEnabled' is deprecated, the editor only supports prefabs for level editing.");
         return true;
     }
 
@@ -786,12 +786,12 @@ namespace AzFramework
 
     void Application::SetPrefabSystemEnabled(bool /* enable */)
     {
-        AZ_Warning("Application", false, "'SetPrefabSystemEnabled' is deprecated, the editor only supports prefabs for level editing.");
+        AZ_WarningOnce("Application", false, "'SetPrefabSystemEnabled' is deprecated, the editor only supports prefabs for level editing.");
     }
 
     bool Application::IsPrefabSystemForLevelsEnabled() const
     {
-        AZ_Warning("Application", false, "'IsPrefabSystemForLevelsEnabled' is deprecated, the editor only supports prefabs for level editing.");
+        AZ_WarningOnce("Application", false, "'IsPrefabSystemForLevelsEnabled' is deprecated, the editor only supports prefabs for level editing.");
         return true;
     }
 

Gems/Atom/RHI/Vulkan/Code/Source/RHI/RenderPass.h

@@ -109,6 +109,12 @@ namespace AZ
             const Descriptor& GetDescriptor() const;
             uint32_t GetAttachmentCount() const;
 
+            //! Typically the returned descriptor is only used to create a dummy VkRenderPass (cached and reusable)
+            //! that will be associated with one or more PSOs. The PSO will use such VkRenderPass as a data source
+            //! to better optimize the layout of the PSO. In the end the real VkRenderPass is built (cached and reusable)
+            //! at runtime by the FrameGraph and used with VkCmdBeginRenderPass.
+            //! This is possible because, per the Vulkan spec, it is only required that the PSO VkRenderPass and the VkCmdBeginRenderPass
+            //! VkRenderPass to be "compatible", but they don't have to be the same object.
             static Descriptor ConvertRenderAttachmentLayout(
                 Device& device,
                 const RHI::RenderAttachmentLayout& layout,

Gems/Atom/RPI/Code/Source/RPI.Public/DynamicDraw/DynamicDrawContext.cpp

@@ -179,7 +179,6 @@ namespace AZ
         {
             AZ_Warning("RPI", m_pipelineState, "Failed to initialize shader for DynamicDrawContext");
             AZ_Warning("RPI", m_drawListTag.IsValid(), "DynamicDrawContext doesn't have a valid DrawListTag");
-
             if (!m_drawListTag.IsValid() || m_pipelineState == nullptr)
             {
                 return;
@@ -298,13 +297,12 @@ namespace AZ
 
         ShaderVariantId DynamicDrawContext::UseShaderVariant(const ShaderOptionList& optionAndValues)
         {
-            AZ_Assert(m_initialized && m_supportShaderVariants, "DynamicDrawContext is not initialized or unable to support shader variants. "
-                "Check if it was initialized with InitShaderWithVariant");
-
             ShaderVariantId variantId;
 
-            if (!m_supportShaderVariants)
+            if (!m_initialized || !m_supportShaderVariants)
             {
+                AZ_WarningOnce("DynamicDrawContext", false, "%s DynamicDrawContext is not initialized or unable to support shader variants. "
+                                                            "Check if it was initialized with InitShaderWithVariant", __FUNCTION__);
                 return variantId;
             }
 
@@ -446,16 +444,21 @@ namespace AZ
 
         void DynamicDrawContext::SetShaderVariant(ShaderVariantId shaderVariantId)
         {
-            AZ_Assert( m_initialized && m_supportShaderVariants, "DynamicDrawContext is not initialized or unable to support shader variants. "
-                "Check if it was initialized with InitShaderWithVariant");
+            if (!m_initialized || !m_supportShaderVariants)
+            {
+                AZ_WarningOnce("DynamicDrawContext", false, "%s DynamicDrawContext is not initialized or unable to support shader variants. "
+                                                            "Check if it was initialized with InitShaderWithVariant.\n", __FUNCTION__);
+                return;
+            }
+
             m_currentShaderVariantId = shaderVariantId;
         }
 
         void DynamicDrawContext::DrawIndexed(const void* vertexData, uint32_t vertexCount, const void* indexData, uint32_t indexCount, RHI::IndexFormat indexFormat, Data::Instance < ShaderResourceGroup> drawSrg)
         {
             if (!m_initialized)
             {
-                AZ_Assert(false, "DynamicDrawContext isn't initialized");
+                AZ_WarningOnce("DynamicDrawContext", false, "%s This function has been disabled because of failed initialization.\n", __FUNCTION__);
                 return;
             }
 
@@ -553,7 +556,7 @@ namespace AZ
         {
             if (!m_initialized)
             {
-                AZ_Assert(false, "DynamicDrawContext isn't initialized");
+                AZ_WarningOnce("DynamicDrawContext", false, "%s This function has been disabled because of failed initialization.\n", __FUNCTION__);
                 return;
             }