Fix clang-16 compile errors (o3de#17428)

* Fix clang-16 compile errors
* Use PAL instead of AZ_PLATFORM_WINDOWS query

Signed-off-by: Markus Prettner <[email protected]>

Author: mprettner-huawei

Code/Framework/AzCore/AzCore/Component/Component.h

@@ -23,6 +23,7 @@
 #include <AzCore/Memory/SystemAllocator.h> // Used as the allocator for most components.
 #include <AzCore/Memory/ChildAllocatorSchema.h>
 #include <AzCore/Outcome/Outcome.h>
+#include <AzCore/PlatformDef.h> // Needed for Component_Platform.inl include
 #include <AzCore/std/containers/unordered_set.h>
 
 namespace AZ
@@ -467,6 +468,15 @@ namespace AZ
     //! The `AZ_CLASS` is a placeholder macro that is used to substitute `class` template parameters
     //! For non-type template parameters such as `size_t` or `int` the `AZ_AUTO` placeholder can be used
 
+    // Include the platform specific implementation of AZ_RTTI_NO_TYPE_INFO_IMPL_VA_OPT_HELPER
+    #include <AzCore/Component/Component_Platform.inl>
+
+    // If there was no platform specific implementation defined, use a default one:
+    #if !defined(AZ_RTTI_NO_TYPE_INFO_IMPL_VA_OPT_HELPER)
+    #define AZ_RTTI_NO_TYPE_INFO_IMPL_VA_OPT_HELPER(_ComponentClassOrTemplate, _BaseClass, ...) \
+        AZ_RTTI_NO_TYPE_INFO_IMPL(_ComponentClassOrTemplate, __VA_ARGS__ AZ_VA_OPT(AZ_COMMA_SEPARATOR, __VA_ARGS__) _BaseClass)
+    #endif
+
     #define AZ_COMPONENT_IMPL_WITH_ALLOCATOR(_ComponentClassOrTemplate, _DisplayName, _Uuid, _Allocator, ...) \
     AZ_COMPONENT_MACRO_CALL(AZ_TYPE_INFO_WITH_NAME_IMPL, \
         AZ_USE_FIRST_ARG(AZ_UNWRAP(_ComponentClassOrTemplate)), \
@@ -475,7 +485,7 @@ namespace AZ
         AZ_VA_OPT(AZ_COMMA_SEPARATOR, AZ_SKIP_FIRST_ARG(AZ_UNWRAP(_ComponentClassOrTemplate))) \
         AZ_SKIP_FIRST_ARG(AZ_UNWRAP(_ComponentClassOrTemplate)) \
     ) \
-    AZ_RTTI_NO_TYPE_INFO_IMPL(_ComponentClassOrTemplate, __VA_ARGS__ AZ_VA_OPT(AZ_COMMA_SEPARATOR, __VA_ARGS__) AZ::Component) \
+    AZ_RTTI_NO_TYPE_INFO_IMPL_VA_OPT_HELPER(_ComponentClassOrTemplate, AZ::Component, __VA_ARGS__) \
     AZ_COMPONENT_MACRO_CALL(AZ_COMPONENT_BASE_IMPL, \
         AZ_USE_FIRST_ARG(AZ_UNWRAP(_ComponentClassOrTemplate)) \
         AZ_VA_OPT(AZ_COMMA_SEPARATOR, AZ_SKIP_FIRST_ARG(AZ_UNWRAP(_ComponentClassOrTemplate))) \

Code/Framework/AzCore/Platform/Android/AzCore/Component/Component_Platform.inl

@@ -0,0 +1,7 @@
+/*
+ * Copyright (c) Contributors to the Open 3D Engine Project.
+ * For complete copyright and license terms please see the LICENSE at the root of this distribution.
+ *
+ * SPDX-License-Identifier: Apache-2.0 OR MIT
+ *
+ */

Code/Framework/AzCore/Platform/Linux/AzCore/Component/Component_Platform.inl

@@ -0,0 +1,7 @@
+/*
+ * Copyright (c) Contributors to the Open 3D Engine Project.
+ * For complete copyright and license terms please see the LICENSE at the root of this distribution.
+ *
+ * SPDX-License-Identifier: Apache-2.0 OR MIT
+ *
+ */

Code/Framework/AzCore/Platform/Mac/AzCore/Component/Component_Platform.inl

@@ -0,0 +1,7 @@
+/*
+ * Copyright (c) Contributors to the Open 3D Engine Project.
+ * For complete copyright and license terms please see the LICENSE at the root of this distribution.
+ *
+ * SPDX-License-Identifier: Apache-2.0 OR MIT
+ *
+ */

Code/Framework/AzCore/Platform/Windows/AzCore/Component/Component_Platform.inl

@@ -0,0 +1,14 @@
+/*
+ * Copyright (c) Contributors to the Open 3D Engine Project.
+ * For complete copyright and license terms please see the LICENSE at the root of this distribution.
+ *
+ * SPDX-License-Identifier: Apache-2.0 OR MIT
+ *
+ */
+
+// Clang on Windows uses the preprocessor in MSVC compatibility mode, which cannot parse the AZ_VA_OPT macro in some instances, but
+// since the comma after __VA_ARGS__ is removed automatically if __VA_ARGS__ is empty, it does not have to be used.
+#if defined(AZ_COMPILER_CLANG)
+#define AZ_RTTI_NO_TYPE_INFO_IMPL_VA_OPT_HELPER(_ComponentClassOrTemplate, _BaseClass, ...) \
+    AZ_RTTI_NO_TYPE_INFO_IMPL(_ComponentClassOrTemplate, __VA_ARGS__, _BaseClass)
+#endif

Code/Framework/AzCore/Platform/iOS/AzCore/Component/Component_Platform.inl

@@ -0,0 +1,7 @@
+/*
+ * Copyright (c) Contributors to the Open 3D Engine Project.
+ * For complete copyright and license terms please see the LICENSE at the root of this distribution.
+ *
+ * SPDX-License-Identifier: Apache-2.0 OR MIT
+ *
+ */