remove const& from struct definition

Signed-off-by: Wojciech Czerski <[email protected]>

Author: w-czerski

Gems/CsvSpawner/Code/Include/CsvSpawner/CsvSpawnerInterface.h

@@ -22,19 +22,19 @@ namespace CsvSpawner
     /**
      * @brief Flags representing the status of an CsvSpawner::Spawn() operation.
      *
-     * SpawnStatusCode provides various status indicators for entity spawning.
+     * SpawnStatus provides various status indicators for entity spawning.
      * These flags help track whether spawning was successful, stopped, or failed.
      */
-    enum class SpawnStatusCode : uint8_t
+    enum class SpawnStatus : uint8_t
     {
         Success = 0, ///< Operation succeeded.
         Fail = 1 << 0, ///< Generic failure.
-        SpawnStopped = 1 << 1, ///< Spawning was stopped prematurely but not necessarily a failure.
-        ErrorGenerated = 1 << 2, ///< An error occurred during spawning (potentially recoverable).
+        Stopped = 1 << 1, ///< Spawning was stopped prematurely but not necessarily a failure.
+        Warning = 1 << 2, ///< An warning or error occurred during spawning (potentially recoverable).
     };
 
-    /// Enable bitwise operations for SpawnStatusCode.
-    AZ_DEFINE_ENUM_BITWISE_OPERATORS(SpawnStatusCode);
+    /// Enable bitwise operations for SpawnStatus.
+    AZ_DEFINE_ENUM_BITWISE_OPERATORS(SpawnStatus);
 
     /**
      * @brief Structure holding data related to CsvSpawner entity spawning.
@@ -44,9 +44,9 @@ namespace CsvSpawner
      */
     struct SpawnInfo
     {
-        const AZStd::vector<CsvSpawnerUtils::CsvSpawnableEntityInfo>& m_entitiesToSpawn; ///< List of entities to spawn.
-        const AZStd::string& m_physicsSceneName; ///< Name of the physics scene where entities will be spawned.
-        const AZ::EntityId& m_spawnerParentEntityId; ///< Parent entity ID managing the spawn process.
+        AZStd::vector<CsvSpawnerUtils::CsvSpawnableEntityInfo> m_entitiesToSpawn; ///< List of entities to spawn.
+        AZStd::string m_physicsSceneName; ///< Name of the physics scene where entities will be spawned.
+        AZ::EntityId m_spawnerParentEntityId; ///< Parent entity ID managing the spawn process.
     };
 
     /**
@@ -73,7 +73,7 @@ namespace CsvSpawner
          * @param m_spawnInfo Struct holding information about entities to be spawned.
          * @param m_statusCode Status code indicating success, failure and warnings of the spawn.
          */
-        virtual void OnEntitiesSpawnFinished(SpawnInfo& m_spawnInfo, SpawnStatusCode& m_statusCode)
+        virtual void OnEntitiesSpawnFinished(SpawnInfo& m_spawnInfo, SpawnStatus& m_statusCode)
         {
         }
 

Gems/CsvSpawner/Code/Source/CsvSpawner/CsvSpawnerUtils.cpp

@@ -198,7 +198,7 @@ namespace CsvSpawner::CsvSpawnerUtils
     {
         SpawnInfo broadcastSpawnInfo =
             SpawnInfo{ entitiesToSpawn, physicsSceneName, parentId }; // Spawn Info used in CsvSpawner EBus notify.
-        SpawnStatusCode spawnStatusCode = SpawnStatusCode::Success; // Spawn Status Code used for CsvSpawner EBus notify - OnEntitiesSpawnFinished.
+        SpawnStatus spawnStatusCode = SpawnStatus::Success; // Spawn Status Code used for CsvSpawner EBus notify - OnEntitiesSpawnFinished.
 
         // Call CsvSpawner EBus notification - Begin
         CsvSpawnerNotificationBus::Broadcast(&CsvSpawnerInterface::OnEntitiesSpawnBegin, broadcastSpawnInfo);
@@ -233,7 +233,7 @@ namespace CsvSpawner::CsvSpawnerUtils
                 AZ_Error("CsvSpawner", false, "SpawnableAssetConfiguration %s not found", entityConfig.m_name.c_str());
 
                 // Add notify code status
-                spawnStatusCode |= SpawnStatusCode::ErrorGenerated;
+                spawnStatusCode |= SpawnStatus::Warning;
                 continue;
             }
 
@@ -264,7 +264,7 @@ namespace CsvSpawner::CsvSpawnerUtils
                 else
                 {
                     // Add notify code status
-                    spawnStatusCode |= SpawnStatusCode::ErrorGenerated;
+                    spawnStatusCode |= SpawnStatus::Warning;
 
                     continue; // Skip this entity if we can't find a valid position and
                               // place on terrain is enabled.
@@ -280,7 +280,7 @@ namespace CsvSpawner::CsvSpawnerUtils
                 if (view.empty())
                 {
                     // Add notify code status
-                    spawnStatusCode |= SpawnStatusCode::ErrorGenerated | SpawnStatusCode::SpawnStopped;
+                    spawnStatusCode |= SpawnStatus::Warning | SpawnStatus::Stopped;
 
                     return;
                 }
@@ -297,7 +297,7 @@ namespace CsvSpawner::CsvSpawnerUtils
                 if (view.empty())
                 {
                     // Add notify code status
-                    spawnStatusCode |= SpawnStatusCode::ErrorGenerated | SpawnStatusCode::SpawnStopped;
+                    spawnStatusCode |= SpawnStatus::Warning | SpawnStatus::Stopped;
 
                     return;
                 }
@@ -310,7 +310,7 @@ namespace CsvSpawner::CsvSpawnerUtils
         }
 
         // Check is success spawn
-        tickets.empty() ? spawnStatusCode |= SpawnStatusCode::Fail : spawnStatusCode |= SpawnStatusCode::Success;
+        tickets.empty() ? spawnStatusCode |= SpawnStatus::Fail : spawnStatusCode |= SpawnStatus::Success;
         // Call CsvSpawner EBus notification - Finished
         CsvSpawnerNotificationBus::Broadcast(&CsvSpawnerInterface::OnEntitiesSpawnFinished, broadcastSpawnInfo, spawnStatusCode);