Skip to content

Commit a8b8a45

Browse files
committed
remove const from bus notifies - blocking file modifications
Signed-off-by: Wojciech Czerski <[email protected]>
1 parent e164d0e commit a8b8a45

File tree

1 file changed

+20
-34
lines changed

1 file changed

+20
-34
lines changed

Gems/FPSProfiler/Code/Include/FPSProfiler/FPSProfilerBus.h

Lines changed: 20 additions & 34 deletions
Original file line numberDiff line numberDiff line change
@@ -140,25 +140,19 @@ namespace FPSProfiler
140140
* @brief Called when a new file is created.
141141
* @param config File Save Settings Configuration.
142142
*/
143-
virtual void OnFileCreated(const Configs::FileSaveSettings& config)
144-
{
145-
}
143+
virtual void OnFileCreated(Configs::FileSaveSettings& config) = 0;
146144

147145
/**
148146
* @brief Called when an existing file is updated.
149147
* @param config File Save Settings Configuration.
150148
*/
151-
virtual void OnFileUpdate(const Configs::FileSaveSettings& config)
152-
{
153-
}
149+
virtual void OnFileUpdate(Configs::FileSaveSettings& config) = 0;
154150

155151
/**
156152
* @brief Called when a file is successfully saved.
157153
* @param config File Save Settings Configuration.
158154
*/
159-
virtual void OnFileSaved(const Configs::FileSaveSettings& config)
160-
{
161-
}
155+
virtual void OnFileSaved(Configs::FileSaveSettings& config) = 0;
162156

163157
/**
164158
* @brief Called when the profiling process starts.
@@ -167,20 +161,14 @@ namespace FPSProfiler
167161
* @param debugConfig The configuration settings used for the debugging.
168162
*/
169163
virtual void OnProfileStart(
170-
const Configs::RecordSettings& recordConfig,
171-
const Configs::PrecisionSettings& precisionConfig,
172-
const Configs::DebugSettings& debugConfig)
173-
{
174-
}
164+
Configs::RecordSettings& recordConfig, Configs::PrecisionSettings& precisionConfig, Configs::DebugSettings& debugConfig) = 0;
175165

176166
/**
177167
* @brief Called when the profiling data is reset.
178168
* @param recordConfig The configuration settings used for the record session.
179169
* @param precisionConfig The configuration settings used for the precision.
180170
*/
181-
virtual void OnProfileReset(const Configs::RecordSettings& recordConfig, const Configs::PrecisionSettings& precisionConfig)
182-
{
183-
}
171+
virtual void OnProfileReset(Configs::RecordSettings& recordConfig, Configs::PrecisionSettings& precisionConfig) = 0;
184172

185173
/**
186174
* @brief Called when the profiling process stops.
@@ -190,12 +178,10 @@ namespace FPSProfiler
190178
* @param debugConfig The configuration settings used for the debugging.
191179
*/
192180
virtual void OnProfileStop(
193-
const Configs::FileSaveSettings& saveConfig,
194-
const Configs::RecordSettings& recordConfig,
195-
const Configs::PrecisionSettings& precisionConfig,
196-
const Configs::DebugSettings& debugConfig)
197-
{
198-
}
181+
Configs::FileSaveSettings& saveConfig,
182+
Configs::RecordSettings& recordConfig,
183+
Configs::PrecisionSettings& precisionConfig,
184+
Configs::DebugSettings& debugConfig) = 0;
199185
};
200186

201187
class FPSProfilerNotificationBusTraits : public AZ::EBusTraits
@@ -226,39 +212,39 @@ namespace FPSProfiler
226212
OnProfileReset,
227213
OnProfileStop);
228214

229-
void OnFileCreated(const Configs::FileSaveSettings& config) override
215+
void OnFileCreated(Configs::FileSaveSettings& config) override
230216
{
231217
Call(FN_OnFileCreated, config);
232218
}
233219

234-
void OnFileUpdate(const Configs::FileSaveSettings& config) override
220+
void OnFileUpdate(Configs::FileSaveSettings& config) override
235221
{
236222
Call(FN_OnFileUpdate, config);
237223
}
238224

239-
void OnFileSaved(const Configs::FileSaveSettings& config) override
225+
void OnFileSaved(Configs::FileSaveSettings& config) override
240226
{
241227
Call(FN_OnFileSaved, config);
242228
}
243229

244230
void OnProfileStart(
245-
const Configs::RecordSettings& recordConfig,
246-
const Configs::PrecisionSettings& precisionConfig,
247-
const Configs::DebugSettings& debugConfig) override
231+
Configs::RecordSettings& recordConfig,
232+
Configs::PrecisionSettings& precisionConfig,
233+
Configs::DebugSettings& debugConfig) override
248234
{
249235
Call(FN_OnProfileStart, recordConfig, precisionConfig, debugConfig);
250236
}
251237

252-
void OnProfileReset(const Configs::RecordSettings& recordConfig, const Configs::PrecisionSettings& precisionConfig) override
238+
void OnProfileReset(Configs::RecordSettings& recordConfig, Configs::PrecisionSettings& precisionConfig) override
253239
{
254240
Call(FN_OnProfileReset, recordConfig, precisionConfig);
255241
}
256242

257243
void OnProfileStop(
258-
const Configs::FileSaveSettings& saveConfig,
259-
const Configs::RecordSettings& recordConfig,
260-
const Configs::PrecisionSettings& precisionConfig,
261-
const Configs::DebugSettings& debugConfig) override
244+
Configs::FileSaveSettings& saveConfig,
245+
Configs::RecordSettings& recordConfig,
246+
Configs::PrecisionSettings& precisionConfig,
247+
Configs::DebugSettings& debugConfig) override
262248
{
263249
Call(FN_OnProfileStop, saveConfig, recordConfig, precisionConfig, debugConfig);
264250
}

0 commit comments

Comments
 (0)