-
Notifications
You must be signed in to change notification settings - Fork 42
Description
Description:
Currently, the msgs and srvs are defined within the main package, which can lead to circular dependencies and complicate the build process. As a best practice in ROS development, message and service definitions should be placed in a separate package (e.g., roboteq_motor_controller_driver_msgs) to improve modularity and maintainability.
Suggested Changes:
-
Create a new package (e.g., roboteq_motor_controller_driver_msgs) to house all message and service definitions.
-
Update dependencies in the CMakeLists.txt and package.xml files of the main package to depend on roboteq_motor_controller_driver_msgs instead of defining messages and services internally.
-
Refactor the code to use the new message and service package.
-
Update documentation to reflect the changes.
Benefits:
-
Avoids circular dependencies, making package management more robust.
-
Enhances modularity, allowing other packages to use the messages/services independently.
-
Simplifies future maintenance and upgrades.