Skip to content

Commit 8089ed6

Browse files
Merge pull request #5 from RobotlegsJS/improve-example
Improve example project
2 parents 153a5d3 + 1a4e26f commit 8089ed6

File tree

5 files changed

+58
-20
lines changed

5 files changed

+58
-20
lines changed

CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,8 @@
2424

2525
- Update `karma` setup to generate code coverage report only for `src` folder (see #4).
2626

27+
- Improve webpack configuration used to run example project. The `npm start` script will generate hashed files (to avoid browser cache) and open the broswer automatically (see #5).
28+
2729
- Update dev dependencies to latest version.
2830

2931
### [v0.2.0](https://github.com/RobotlegsJS/RobotlegsJS-CreateJS/releases/tag/0.2.0) - 2018-08-08

example/view/SmileyView.ts

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -47,5 +47,11 @@ export class SmileyView extends createjs.Container {
4747
private move(): void {
4848
this.x = Math.random() * 960;
4949
this.y = Math.random() * 400;
50+
51+
this.x = Math.max(this.x, this._radius);
52+
this.x = Math.min(this.x, 960 - this._radius);
53+
54+
this.y = Math.max(this.y, this._radius);
55+
this.y = Math.min(this.y, 400 - this._radius);
5056
}
5157
}

package.json

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -88,6 +88,7 @@
8888
"karma-sourcemap-writer": "^0.1.2",
8989
"karma-webpack": "^3.0.0",
9090
"mocha": "^5.2.0",
91+
"open-browser-webpack-plugin": "^0.0.5",
9192
"prettier": "^1.14.2",
9293
"publish-please": "^3.2.0",
9394
"reflect-metadata": "^0.1.12",
@@ -103,6 +104,7 @@
103104
"webpack": "^4.16.5",
104105
"webpack-cli": "^3.1.0",
105106
"webpack-concat-plugin": "^3.0.0",
106-
"webpack-dev-server": "^3.1.5"
107+
"webpack-dev-server": "^3.1.5",
108+
"webpack-simple-progress-plugin": "^0.0.4"
107109
}
108110
}

webpack.example.config.js

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,13 +2,15 @@ const webpack = require("webpack");
22
const path = require("path");
33
const HtmlWebpackPlugin = require("html-webpack-plugin");
44
const ConcatPlugin = require("webpack-concat-plugin");
5+
const OpenBrowserPlugin = require("open-browser-webpack-plugin");
6+
const SimpleProgressPlugin = require("webpack-simple-progress-plugin");
57

68
const concatPluginConfigGenerator = (name, files) => {
79
return {
810
uglify: false,
911
sourceMap: false,
1012
name: name,
11-
fileName: "[name].js",
13+
fileName: "[name].[hash].js",
1214
filesToConcat: files,
1315
injectType: "none"
1416
};
@@ -24,7 +26,7 @@ module.exports = options => {
2426

2527
output: {
2628
path: __dirname + "/dist",
27-
filename: "bundle.js"
29+
filename: "game.[hash].js"
2830
},
2931

3032
devtool: "source-map",
@@ -44,6 +46,10 @@ module.exports = options => {
4446
new ConcatPlugin(concatPluginConfigGenerator("createjs", [
4547
path.resolve(__dirname, "./node_modules/easeljs/lib/easeljs.js")
4648
])),
49+
50+
new SimpleProgressPlugin(),
51+
52+
new OpenBrowserPlugin({ url: "http://0.0.0.0:8080/webpack-dev-server/" })
4753
],
4854

4955
resolve: {

yarn.lock

Lines changed: 39 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -1558,11 +1558,10 @@ default-require-extensions@^2.0.0:
15581558
strip-bom "^3.0.0"
15591559

15601560
define-properties@^1.1.2:
1561-
version "1.1.2"
1562-
resolved "https://registry.npmjs.org/define-properties/-/define-properties-1.1.2.tgz#83a73f2fea569898fb737193c8f873caf6d45c94"
1561+
version "1.1.3"
1562+
resolved "https://registry.npmjs.org/define-properties/-/define-properties-1.1.3.tgz#cf88da6cbee26fe6db7094f61d870cbd84cee9f1"
15631563
dependencies:
1564-
foreach "^2.0.5"
1565-
object-keys "^1.0.8"
1564+
object-keys "^1.0.12"
15661565

15671566
define-property@^0.2.5:
15681567
version "0.2.5"
@@ -1895,8 +1894,8 @@ es-to-primitive@^1.1.1:
18951894
is-symbol "^1.0.1"
18961895

18971896
es5-ext@^0.10.35, es5-ext@^0.10.9, es5-ext@~0.10.14:
1898-
version "0.10.45"
1899-
resolved "https://registry.npmjs.org/es5-ext/-/es5-ext-0.10.45.tgz#0bfdf7b473da5919d5adf3bd25ceb754fccc3653"
1897+
version "0.10.46"
1898+
resolved "https://registry.npmjs.org/es5-ext/-/es5-ext-0.10.46.tgz#efd99f67c5a7ec789baa3daa7f79870388f7f572"
19001899
dependencies:
19011900
es6-iterator "~2.0.3"
19021901
es6-symbol "~3.1.1"
@@ -2349,8 +2348,8 @@ flush-write-stream@^1.0.0:
23492348
readable-stream "^2.0.4"
23502349

23512350
follow-redirects@^1.0.0:
2352-
version "1.5.2"
2353-
resolved "https://registry.npmjs.org/follow-redirects/-/follow-redirects-1.5.2.tgz#5a9d80e0165957e5ef0c1210678fc5c4acb9fb03"
2351+
version "1.5.5"
2352+
resolved "https://registry.npmjs.org/follow-redirects/-/follow-redirects-1.5.5.tgz#3c143ca599a2e22e62876687d68b23d55bad788b"
23542353
dependencies:
23552354
debug "^3.1.0"
23562355

@@ -3952,12 +3951,13 @@ log-update@^1.0.2:
39523951
cli-cursor "^1.0.2"
39533952

39543953
log4js@^3.0.0:
3955-
version "3.0.4"
3956-
resolved "https://registry.npmjs.org/log4js/-/log4js-3.0.4.tgz#dfb2fc1782766bace1aabd00008460f6d994d159"
3954+
version "3.0.5"
3955+
resolved "https://registry.npmjs.org/log4js/-/log4js-3.0.5.tgz#b80146bfebad68b430d4f3569556d8a6edfef303"
39573956
dependencies:
39583957
circular-json "^0.5.5"
39593958
date-format "^1.2.0"
39603959
debug "^3.1.0"
3960+
rfdc "^1.1.2"
39613961
streamroller "0.7.0"
39623962

39633963
loglevel@^1.4.1:
@@ -4321,8 +4321,8 @@ [email protected]:
43214321
resolved "https://registry.npmjs.org/negotiator/-/negotiator-0.6.1.tgz#2b327184e8992101177b28563fb5e7102acd0ca9"
43224322

43234323
neo-async@^2.5.0:
4324-
version "2.5.1"
4325-
resolved "https://registry.npmjs.org/neo-async/-/neo-async-2.5.1.tgz#acb909e327b1e87ec9ef15f41b8a269512ad41ee"
4324+
version "2.5.2"
4325+
resolved "https://registry.npmjs.org/neo-async/-/neo-async-2.5.2.tgz#489105ce7bc54e709d736b195f82135048c50fcc"
43264326

43274327
next-tick@1:
43284328
version "1.0.0"
@@ -4333,8 +4333,8 @@ nice-try@^1.0.4:
43334333
resolved "https://registry.npmjs.org/nice-try/-/nice-try-1.0.4.tgz#d93962f6c52f2c1558c0fbda6d512819f1efe1c4"
43344334

43354335
nise@^1.3.3:
4336-
version "1.4.2"
4337-
resolved "https://registry.npmjs.org/nise/-/nise-1.4.2.tgz#a9a3800e3994994af9e452333d549d60f72b8e8c"
4336+
version "1.4.3"
4337+
resolved "https://registry.npmjs.org/nise/-/nise-1.4.3.tgz#d1996e8d15256ceff1a0a1596e0c72bff370e37c"
43384338
dependencies:
43394339
"@sinonjs/formatio" "^2.0.0"
43404340
just-extend "^1.1.27"
@@ -4515,7 +4515,7 @@ object-inspect@~1.6.0:
45154515
version "1.6.0"
45164516
resolved "https://registry.npmjs.org/object-inspect/-/object-inspect-1.6.0.tgz#c70b6cbf72f274aab4c34c0c82f5167bf82cf15b"
45174517

4518-
object-keys@^1.0.11, object-keys@^1.0.6, object-keys@^1.0.8:
4518+
object-keys@^1.0.11, object-keys@^1.0.12, object-keys@^1.0.6:
45194519
version "1.0.12"
45204520
resolved "https://registry.npmjs.org/object-keys/-/object-keys-1.0.12.tgz#09c53855377575310cca62f55bb334abff7b3ed2"
45214521

@@ -4583,6 +4583,16 @@ onetime@^2.0.0:
45834583
dependencies:
45844584
mimic-fn "^1.0.0"
45854585

4586+
open-browser-webpack-plugin@^0.0.5:
4587+
version "0.0.5"
4588+
resolved "https://registry.npmjs.org/open-browser-webpack-plugin/-/open-browser-webpack-plugin-0.0.5.tgz#5e6dc6f8b8797331e212985de218572d84c0521f"
4589+
dependencies:
4590+
open "0.0.5"
4591+
4592+
4593+
version "0.0.5"
4594+
resolved "https://registry.npmjs.org/open/-/open-0.0.5.tgz#42c3e18ec95466b6bf0dc42f3a2945c3f0cad8fc"
4595+
45864596
opn@^5.1.0:
45874597
version "5.3.0"
45884598
resolved "https://registry.npmjs.org/opn/-/opn-5.3.0.tgz#64871565c863875f052cfdf53d3e3cb5adb53b1c"
@@ -5406,6 +5416,10 @@ ret@~0.1.10:
54065416
version "0.1.15"
54075417
resolved "https://registry.npmjs.org/ret/-/ret-0.1.15.tgz#b8a4825d5bdb1fc3f6f53c2bc33f81388681c7bc"
54085418

5419+
rfdc@^1.1.2:
5420+
version "1.1.2"
5421+
resolved "https://registry.npmjs.org/rfdc/-/rfdc-1.1.2.tgz#e6e72d74f5dc39de8f538f65e00c36c18018e349"
5422+
54095423
right-align@^0.1.1:
54105424
version "0.1.3"
54115425
resolved "https://registry.npmjs.org/right-align/-/right-align-0.1.3.tgz#61339b722fe6a3515689210d24e14c96148613ef"
@@ -6292,8 +6306,8 @@ uglify-to-browserify@~1.0.0:
62926306
resolved "https://registry.npmjs.org/uglify-to-browserify/-/uglify-to-browserify-1.0.2.tgz#6e0924d6bda6b5afe349e39a6d632850a0f882b7"
62936307

62946308
uglifyjs-webpack-plugin@^1.2.4:
6295-
version "1.2.7"
6296-
resolved "https://registry.npmjs.org/uglifyjs-webpack-plugin/-/uglifyjs-webpack-plugin-1.2.7.tgz#57638dd99c853a1ebfe9d97b42160a8a507f9d00"
6309+
version "1.3.0"
6310+
resolved "https://registry.npmjs.org/uglifyjs-webpack-plugin/-/uglifyjs-webpack-plugin-1.3.0.tgz#75f548160858163a08643e086d5fefe18a5d67de"
62976311
dependencies:
62986312
cacache "^10.0.4"
62996313
find-cache-dir "^1.0.0"
@@ -6611,6 +6625,14 @@ webpack-log@^1.0.1, webpack-log@^1.1.2:
66116625
loglevelnext "^1.0.1"
66126626
uuid "^3.1.0"
66136627

6628+
webpack-simple-progress-plugin@^0.0.4:
6629+
version "0.0.4"
6630+
resolved "https://registry.npmjs.org/webpack-simple-progress-plugin/-/webpack-simple-progress-plugin-0.0.4.tgz#c4829137429cb673dfc6a61a262b955c35cc7ba2"
6631+
dependencies:
6632+
chalk "^1.1.3"
6633+
object-assign "^4.1.0"
6634+
progress "^1.1.8"
6635+
66146636
webpack-sources@^1.0.1, webpack-sources@^1.1.0:
66156637
version "1.1.0"
66166638
resolved "https://registry.npmjs.org/webpack-sources/-/webpack-sources-1.1.0.tgz#a101ebae59d6507354d71d8013950a3a8b7a5a54"

0 commit comments

Comments
 (0)