Merge pull request #39 from RobotlegsJS/tslint

Enforce TSLint rules

Author: tiagoschenkel

.npmignore

@@ -20,6 +20,7 @@ tsconfig.json
 tsconfig.test.json
 tsfmt.json
 tslint.json
+tslint.test.json
 typings.json
 webpack.config.js
 yarn.lock

.vscode/settings.json

@@ -1,4 +1,5 @@
 // Place your settings in this file to overwrite default and user settings.
 {
-  "typescript.tsdk": "node_modules/typescript/lib"
+  "typescript.tsdk": "node_modules/typescript/lib",
+  "tslint.configFile": "tslint.test.json"
 }

CHANGELOG.md

@@ -24,6 +24,8 @@
 
 - Update TypeScript Compiler Options (see #38).
 
+- Enforce TSLint rules (see #39).
+
 - Update dev dependencies to latest version.
 
 ### [v0.0.5](https://github.com/RobotlegsJS/RobotlegsJS-Phaser-SignalCommandMap/releases/tag/0.0.5) - 2017-09-26

package.json

@@ -8,13 +8,17 @@
     "test": "karma start --single-run",
     "mocha": "mocha test/**/*.test.ts --require ts-node/register",
     "autoformat": "prettier --config .prettierrc --write {src,test}/**/*.ts",
-    "tslint-check": "tslint-config-prettier-check ./tslint.json",
+    "tslint-check:src": "tslint-config-prettier-check ./tslint.json",
+    "tslint-check:test": "tslint-config-prettier-check ./tslint.test.json",
+    "tslint:src": "tslint --project tsconfig.json",
+    "tslint:test": "tslint --config tslint.test.json --project tsconfig.test.json",
+    "tslint": "npm run tslint-check:src && npm run tslint-check:test && npm run tslint:src && npm run tslint:test",
     "clean-up": "rimraf .nyc_output && rimraf coverage && rimraf lib && rimraf dev",
     "compile:src": "tsc -d",
     "compile:test": "tsc -p tsconfig.test.json -d",
     "prepare": "npm run clean-up && npm run compile:src",
     "prepublishOnly": "publish-please guard",
-    "publish-please": "npm run autoformat && npm run clean-up && npm run test && publish-please"
+    "publish-please": "npm run tslint && npm run autoformat && npm run clean-up && npm run test && publish-please"
   },
   "repository": {
     "type": "git",

tslint.json

@@ -48,8 +48,6 @@
     "no-switch-case-fall-through": false,
     "no-this-assignment": false,
     "no-unused-expression": true,
-    "no-unused-variable": true,
-    "no-unreachable": true,
     "no-use-before-declare": true,
     "no-var-keyword": true,
     "object-literal-sort-keys": true,

tslint.test.json

@@ -0,0 +1,10 @@
+{
+  "extends": [
+    "./tslint.json"
+  ],
+  "rules": {
+    "no-implicit-dependencies": false,
+    "no-reference": false,
+    "no-submodule-imports": false
+  }
+}