Skip to content

Commit 0181e3c

Browse files
committed
enable unit test for DeluxeSignal class
1 parent 1b220dc commit 0181e3c

File tree

1 file changed

+2
-4
lines changed

1 file changed

+2
-4
lines changed

test/org/osflash/signals/DeluxeSignalWithBubblingEventTest.test.ts

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,7 @@ describe("DeluxeSignalWithBubblingEventTest", () => {
3232
});
3333

3434
afterEach(() => {
35+
theParent = null;
3536
theChild = null;
3637
theGrandChild = null;
3738
cancelTimeout = null;
@@ -57,13 +58,11 @@ describe("DeluxeSignalWithBubblingEventTest", () => {
5758
theGrandChild.completed.dispatch(event);
5859
});
5960

60-
// TODO: returning after throwing an error is not possible in TS
61-
it.skip("returning_false_from_onEventBubbled_should_stop_bubbling()", () => {
61+
it("returning_false_from_onEventBubbled_should_stop_bubbling()", () => {
6262
let bubbleHater: BubbleHater = new BubbleHater();
6363
theChild = new Child(bubbleHater, "bubblePopper");
6464
theChild.popsBubbles = true;
6565
theGrandChild = new Child(theChild, "bubbleBlower");
66-
6766
let bubblingEvent: IEvent = new GenericEvent(true);
6867
// Will only complete without error if theChild pops the bubble.
6968
theGrandChild.completed.dispatch(bubblingEvent);
@@ -77,7 +76,6 @@ describe("DeluxeSignalWithBubblingEventTest", () => {
7776
// Changing popsBubbles to false will fail the test nicely.
7877
theChild.popsBubbles = false;
7978
theGrandChild = new Child(this.theChild, "bubbleBlower");
80-
8179
let bubblingEvent: IEvent = new GenericEvent(true);
8280
// Because theChild didn"t pop the bubble, this causes bubbleHater to throw an error.
8381
theGrandChild.completed.dispatch(bubblingEvent);

0 commit comments

Comments
 (0)