improve code coverage

Author: tiagoschenkel

test/org/osflash/signals/DeluxeSignalTargetTest.test.ts

@@ -17,6 +17,16 @@ describe("DeluxeSignaltargetTest", () => {
         signal = null;
     });
 
+    it("target_should_be_empty()", () => {
+        signal = new DeluxeSignal();
+        assert.isNull(signal.target);
+    });
+
+    it("target_should_be_null()", () => {
+        signal = new DeluxeSignal(null);
+        assert.isNull(signal.target);
+    });
+
     it("set_target_should_change_target()", () => {
         let target: object = {};
         signal.target = target;

test/org/osflash/signals/DeluxeSignalValueClassesTest.test.ts

@@ -17,6 +17,16 @@ describe("DeluxeSignalValueClassesTest", () => {
         signal = null;
     });
 
+    it("constructor_should_accept_array_of_value_classes()", () => {
+        signal = new DeluxeSignal(self, [Number, String, Boolean]);
+        assert.deepEqual(signal.valueClasses, [Number, String, Boolean]);
+    });
+
+    it("constructor_should_accept_empty_value_classes()", () => {
+        signal = new DeluxeSignal(self);
+        assert.deepEqual(signal.valueClasses, []);
+    });
+
     it("get_value_classes_should_return_same_value_classes_used_in_constructor()", () => {
         assert.deepEqual(signal.valueClasses, [Number, String, Boolean]);
     });
@@ -25,6 +35,16 @@ describe("DeluxeSignalValueClassesTest", () => {
         signal.valueClasses = [Number, String, Boolean];
     });
 
+    it("set_value_classes_should_accept_null()", () => {
+        signal.valueClasses = null;
+        assert.deepEqual(signal.valueClasses, []);
+    });
+
+    it("set_value_classes_should_accept_undefined()", () => {
+        signal.valueClasses = undefined;
+        assert.deepEqual(signal.valueClasses, []);
+    });
+
     it("set_value_classes_throws_error_when_objects_are_passed()", () => {
         assert.throws(() => {
             signal.valueClasses = [0, "", false];

test/org/osflash/signals/MonoSignalValueClassesTest.test.ts

@@ -20,10 +20,25 @@ describe("MonoSignalValueClassesTest", () => {
         assert.deepEqual(signal.valueClasses, [Number, String, Boolean]);
     });
 
+    it("constructor_should_accept_array_of_value_classes()", () => {
+        signal = new MonoSignal([Number, String, Boolean]);
+        assert.deepEqual(signal.valueClasses, [Number, String, Boolean]);
+    });
+
     it("set_value_classes_should_accept_only_class_objects()", () => {
         signal.valueClasses = [Number, String, Boolean];
     });
 
+    it("set_value_classes_should_accept_null()", () => {
+        signal.valueClasses = null;
+        assert.deepEqual(signal.valueClasses, []);
+    });
+
+    it("set_value_classes_should_accept_undefined()", () => {
+        signal.valueClasses = undefined;
+        assert.deepEqual(signal.valueClasses, []);
+    });
+
     it("set_value_classes_throws_error_when_objects_are_passed()", () => {
         assert.throws(() => {
             signal.valueClasses = [0, "", false];

test/org/osflash/signals/PrioritySignalOnceTest.test.ts

@@ -105,6 +105,32 @@ describe("PrioritySignalOnceTest", () => {
         assertNumListenersEqual(prioritySignal.numListeners, 0);
     });
 
+    it("listeners_added_once_with_priority_zero_should_be_called_after_high_and_before_negative_1()", () => {
+        let expectedListenerDispatchOrder: any[] = [A, B, C];
+
+        prioritySignal.addOnceWithPriority(listenerC, -10);
+        prioritySignal.addOnceWithPriority(listenerB);
+        prioritySignal.addOnceWithPriority(listenerA, 10);
+
+        prioritySignal.dispatch();
+
+        assertArrayEqual(expectedListenerDispatchOrder, gotListenerDispatchOrder);
+        assertNumListenersEqual(prioritySignal.numListeners, 0);
+    });
+
+    it("listeners_added_once_with_priority_zero_should_be_called_after_high_and_before_negative_2()", () => {
+        let expectedListenerDispatchOrder: any[] = [A, B, C];
+
+        prioritySignal.addOnceWithPriority(listenerC, -10);
+        prioritySignal.addOnceWithPriority(listenerA, 10);
+        prioritySignal.addOnceWithPriority(listenerB);
+
+        prioritySignal.dispatch();
+
+        assertArrayEqual(expectedListenerDispatchOrder, gotListenerDispatchOrder);
+        assertNumListenersEqual(prioritySignal.numListeners, 0);
+    });
+
     function listenerA(): void {
         gotListenerDispatchOrder.push(A);
     }