Merge pull request #75 from RobotlegsJS/tsconfig

Update TypeScript Compiler Options

Author: tiagoschenkel

.gitignore

@@ -1,12 +1,11 @@
 .idea
 .nyc_output
-build
-dev
+coverage
+dist/lib
+dist-test
 lib
+lib-test
 node_modules
-typings
-coverage
-inversify.d.ts
 *.as
 *.iml
 src/**/*.js

.npmignore

@@ -2,10 +2,10 @@
 /.nyc_output
 /.vscode
 /coverage
-/dev
 /dist
+/dist-test
 /docs
-/lib/test
+/lib-test
 /not-ported-extensions
 /src
 /test
@@ -15,20 +15,14 @@ CODE_OF_CONDUCT.md
 CONTRIBUTING.md
 ISSUE_TEMPLATE.md
 PULL_REQUEST_TEMPLATE.md
-bower.json
 karma.conf.js
 tsconfig.json
 tsconfig.test.json
-tsfmt.json
 tslint.json
 tslint.test.json
-typings.json
 webpack.config.js
 yarn.lock
-.codeclimate.yml
 .editorconfig
-.eslintignore
-.eslintrc
 .gitignore
 .istanbul.yml
 .npmignore

CHANGELOG.md

@@ -24,7 +24,9 @@
 
 - Enforce TSLint rules (see #55).
 
-- Update TypeScript Compiler Options (see #53).
+- Update TypeScript Compiler Options to be more strict and to generate inline source maps (see #53, #75).
+
+- Use [tslib](https://github.com/Microsoft/tslib) library to avoid duplicated declarations (see #75).
 
 - Update dev dependencies to latest version.
 

dist/signals.min.js

@@ -1,13 +1,11 @@
 process.env.TEST = true;
-process.env.NODE_ENV = 'test';
+process.env.NODE_ENV = "test";
 
-const webpack = require("webpack");
-const path = require("path");
-const webpackConfig = require('./webpack.config.js')({ production: false, karma: true });
+const webpackConfig = require("./webpack.config.js")({ production: false, karma: true });
 
 delete webpackConfig.entry;
 
-module.exports = function(config) {
+module.exports = config => {
 
   var configuration = {
     basePath: "",
@@ -20,7 +18,7 @@ module.exports = function(config) {
     files: [
       "./test/**/**/**.test.ts",
       {
-        pattern: '**/*.map',
+        pattern: "**/*.map",
         served: true,
         included: false,
         watched: true
@@ -65,14 +63,14 @@ module.exports = function(config) {
     colors: true,
     logLevel: config.LOG_INFO,
     autoWatch: true,
-    browsers: ['Chrome']
+    browsers: []
   };
 
   if (process.env.TRAVIS) {
-    configuration.browsers = ['PhantomJS'];
+    configuration.browsers.push("PhantomJS");
     configuration.plugins.push("karma-phantomjs-launcher");
   } else {
-    configuration.browsers = ['PhantomJS'];
+    configuration.browsers.push("PhantomJS");
     configuration.plugins.push("karma-phantomjs-launcher");
   }
 

karma.conf.js

@@ -13,11 +13,12 @@
     "tslint:test": "tslint --config tslint.test.json --project tsconfig.test.json",
     "tslint": "npm run tslint-check:src && npm run tslint-check:test && npm run tslint:src && npm run tslint:test",
     "autoformat": "prettier --config .prettierrc --write {src,test}{/,/**/}{*,*.test}.ts",
-    "clean-up": "rimraf .nyc_output && rimraf coverage && rimraf lib",
-    "compile": "tsc -d",
+    "clean-up": "rimraf .nyc_output && rimraf coverage && rimraf lib && rimraf lib-test && rimraf dist-test",
+    "compile:src": "tsc -d --importHelpers",
+    "compile:test": "tsc -p tsconfig.test.json -d --importHelpers",
     "dev": "webpack",
     "build": "webpack --env.production",
-    "prepare": "npm run clean-up && npm run compile",
+    "prepare": "npm run clean-up && npm run compile:src",
     "prepublishOnly": "publish-please guard",
     "publish-please": "npm run tslint && npm run autoformat && npm run clean-up && npm run build && npm run test && publish-please"
   },
@@ -62,6 +63,9 @@
     "url": "https://github.com/RobotlegsJS/SignalsJS/issues"
   },
   "homepage": "https://github.com/RobotlegsJS/SignalsJS#readme",
+  "dependencies": {
+    "tslib": "^1.9.3"
+  },
   "devDependencies": {
     "@types/bluebird": "^3.5.23",
     "@types/chai": "^4.1.4",

package.json

@@ -2,15 +2,21 @@
   "compilerOptions": {
     "outDir": "lib",
     "target": "es5",
-    "lib": ["es6", "dom"],
+    "lib": ["es7", "dom"],
+    "sourceMap": true,
+    "inlineSources": true,
     "module": "commonjs",
     "moduleResolution": "node",
-    "declaration": true,
+    "removeComments": true,
+    "strict": false,
     "noImplicitAny": true,
-    "noUnusedParameters": false,
+    "strictNullChecks": false,
+    "noImplicitThis": false,
+    "alwaysStrict": true,
     "noUnusedLocals": true,
-    "removeComments": true,
-    "sourceMap": false
+    "noUnusedParameters": false,
+    "noImplicitReturns": true,
+    "noFallthroughCasesInSwitch": true
   },
   "include": [
     "./src/**/*.ts"

tsconfig.json

@@ -1,16 +1,7 @@
 {
+  "extends": "./tsconfig.json",
   "compilerOptions": {
-    "outDir": "lib",
-    "target": "es5",
-    "lib": ["es6", "dom"],
-    "module": "commonjs",
-    "moduleResolution": "node",
-    "declaration": true,
-    "noImplicitAny": true,
-    "noUnusedParameters": false,
-    "noUnusedLocals": true,
-    "removeComments": true,
-    "sourceMap": true
+    "outDir": "lib-test"
   },
   "include": [
     "./src/**/*.ts",

tsconfig.test.json

@@ -1,18 +1,19 @@
-const webpack = require('webpack');
-const path = require('path');
-const UglifyJSPlugin = require('uglifyjs-webpack-plugin');
+const webpack = require("webpack");
+const path = require("path");
+const UglifyJsPlugin = require("uglifyjs-webpack-plugin");
 
-module.exports = (env => {
+module.exports = env => {
 
   if (!env) env = { production: false, karma: false };
 
   let mode = env.production ? "production" : "development";
   let tsconfig = !env.karma ? "tsconfig.json" : "tsconfig.test.json";
-  let output = env.production ? "dist" : "dev";
+  let output = env.production ? "dist" : "dist-test";
   let filename = env.production ? "signals.min.js" : "signals.js";
 
   return {
     mode: mode,
+
     entry: {
       main: path.join(__dirname, "src/index.ts")
     },
@@ -48,12 +49,32 @@ module.exports = (env => {
 
     plugins: (
       (env.production)
-        ? [ new UglifyJSPlugin() ]
+        ? []
         : [ new webpack.SourceMapDevToolPlugin({ test: /\.ts$/i }) ]
     ),
 
+    optimization:
+      (env.production)
+        ? {
+            concatenateModules: true,
+            minimize: true,
+            minimizer: [
+              new UglifyJsPlugin({
+                cache: true,
+                parallel: 4,
+                uglifyOptions: {
+                  output: {
+                    comments: false
+                  }
+                }
+              })
+            ]
+          }
+        : {}
+    ,
+
     resolve: {
-      extensions: ['.ts', '.js', '.json']
+      extensions: [".ts", ".js", ".json"]
     }
   }
-});
+};

webpack.config.js

@@ -3360,9 +3360,9 @@ ip@^1.1.0, ip@^1.1.2, ip@^1.1.4, ip@^1.1.5:
   version "1.1.5"
   resolved "https://registry.npmjs.org/ip/-/ip-1.1.5.tgz#bdded70114290828c0a039e72ef25f5aaec4354a"
 
-ipaddr.js@1.6.0:
-  version "1.6.0"
-  resolved "https://registry.npmjs.org/ipaddr.js/-/ipaddr.js-1.6.0.tgz#e3fa357b773da619f26e95f049d055c72796f86b"
+ipaddr.js@1.8.0:
+  version "1.8.0"
+  resolved "https://registry.npmjs.org/ipaddr.js/-/ipaddr.js-1.8.0.tgz#eaa33d6ddd7ace8f7f6fe0c9ca0440e706738b1e"
 
 is-accessor-descriptor@^0.1.6:
   version "0.1.6"
@@ -5361,11 +5361,11 @@ promisify-event@^1.0.0:
     pinkie-promise "^2.0.0"
 
 proxy-addr@~2.0.3:
-  version "2.0.3"
-  resolved "https://registry.npmjs.org/proxy-addr/-/proxy-addr-2.0.3.tgz#355f262505a621646b3130a728eb647e22055341"
+  version "2.0.4"
+  resolved "https://registry.npmjs.org/proxy-addr/-/proxy-addr-2.0.4.tgz#ecfc733bf22ff8c6f407fa275327b9ab67e48b93"
   dependencies:
     forwarded "~0.1.2"
-    ipaddr.js "1.6.0"
+    ipaddr.js "1.8.0"
 
 proxy-agent@~3.0.0:
   version "3.0.1"
@@ -6749,7 +6749,7 @@ ts-node@^7.0.0:
     source-map-support "^0.5.6"
     yn "^2.0.0"
 
-tslib@^1.8.0, tslib@^1.8.1, tslib@^1.9.0:
+tslib@^1.8.0, tslib@^1.8.1, tslib@^1.9.0, tslib@^1.9.3:
   version "1.9.3"
   resolved "https://registry.npmjs.org/tslib/-/tslib-1.9.3.tgz#d7e4dd79245d85428c4d7e4822a79917954ca286"