Merge pull request #103 from RobotlegsJS/upgrade-dependencies

Update dependencies to latest version 🚀

Author: tiagoschenkel

.editorconfig

@@ -15,6 +15,6 @@ indent_size = 4
 indent_style = space
 indent_size = 2
 
-[{.codeclimate.yml,.eslintignore,.eslintrc,.istanbul.yml,.publishrc,.travis.yml}]
+[{.auditignore,.codeclimate.yml,.eslintignore,.eslintrc,.istanbul.yml,.prettierrc,.publishrc,.travis.yml}]
 indent_style = space
 indent_size = 2

.prettierrc

@@ -5,5 +5,19 @@
   "semi": true,
   "singleQuote": false,
   "trailingComma": "none",
-  "bracketSpacing": true
+  "bracketSpacing": true,
+  "overrides": [
+    {
+      "files": "*.json",
+      "options": {
+        "tabWidth": 2
+      }
+    },
+    {
+      "files": ".prettierrc",
+      "options": {
+        "tabWidth": 2
+      }
+    }
+  ]
 }

.vscode/settings.json

@@ -2,4 +2,24 @@
 {
   "typescript.tsdk": "node_modules/typescript/lib",
   "tslint.configFile": "tslint.test.json",
-}
+
+  // Set the default
+  "editor.formatOnSave": false,
+
+  // Enable per-language
+  "[html]": {
+    "editor.formatOnSave": true
+  },
+
+  "[json]": {
+    "editor.formatOnSave": true
+  },
+
+  "[javascript]": {
+    "editor.formatOnSave": true
+  },
+
+  "[typescript]": {
+    "editor.formatOnSave": true
+  }
+}

CHANGELOG.md

@@ -43,6 +43,14 @@ Types of changes:
 - in case of vulnerabilities.
 -->
 
+#### Changed
+
+- Improve `prettier` rules and `autoformat` script (see #103).
+
+- Enable `"editor.formatOnSave"` rule for `VS Code` (see #103).
+
+- Update dev dependencies to latest version.
+
 ## Signals 1.0.0
 
 ### [v1.0.0](https://github.com/RobotlegsJS/SignalsJS/releases/tag/1.0.0) - 2018-11-25

package.json

@@ -12,7 +12,7 @@
     "tslint:src": "tslint --project tsconfig.json",
     "tslint:test": "tslint --config tslint.test.json --project tsconfig.test.json",
     "tslint": "npm run tslint-check:src && npm run tslint-check:test && npm run tslint:src && npm run tslint:test",
-    "autoformat": "prettier --config .prettierrc --write {src,test}{/,/**/}{*,*.test}.ts",
+    "autoformat": "prettier --config .prettierrc --write --list-different \"{src,static,test,example,definitions}{/**/,/}*.{html,css,js,json,ts}\"",
     "clean-up": "rimraf .nyc_output && rimraf coverage && rimraf lib && rimraf lib-test && rimraf dist-test",
     "compile:src": "tsc -d --importHelpers",
     "compile:test": "tsc -p tsconfig.test.json -d --importHelpers",
@@ -73,11 +73,11 @@
     "tslib": "^1.9.3"
   },
   "devDependencies": {
-    "@types/bluebird": "^3.5.24",
+    "@types/bluebird": "^3.5.26",
     "@types/chai": "^4.1.7",
-    "@types/mocha": "^5.2.5",
-    "@types/sinon": "^5.0.7",
-    "@types/webpack-env": "^1.13.6",
+    "@types/mocha": "^5.2.6",
+    "@types/sinon": "^7.0.10",
+    "@types/webpack-env": "^1.13.9",
     "bluebird": "^3.5.3",
     "browserify-versionify": "^1.0.6",
     "chai": "^4.2.0",
@@ -87,10 +87,10 @@
     "imports-loader": "^0.8.0",
     "istanbul": "^0.4.5",
     "istanbul-instrumenter-loader": "^3.0.1",
-    "karma": "^3.1.1",
+    "karma": "^4.0.1",
     "karma-chai-sinon": "^0.1.5",
     "karma-chrome-launcher": "^2.2.0",
-    "karma-coverage-istanbul-reporter": "^2.0.4",
+    "karma-coverage-istanbul-reporter": "^2.0.5",
     "karma-es6-shim": "^1.0.0",
     "karma-mocha": "^1.3.0",
     "karma-mocha-reporter": "^2.2.5",
@@ -99,25 +99,25 @@
     "karma-sourcemap-loader": "^0.3.7",
     "karma-sourcemap-writer": "^0.1.2",
     "karma-webpack": "^3.0.5",
-    "mocha": "^5.2.0",
-    "nyc": "^13.1.0",
-    "prettier": "^1.15.2",
-    "publish-please": "^5.4.0",
-    "puppeteer": "^1.10.0",
-    "reflect-metadata": "^0.1.12",
-    "remap-istanbul": "^0.12.0",
-    "rimraf": "^2.6.2",
-    "sinon": "^7.1.1",
-    "sinon-chai": "^3.2.0",
-    "source-map-support": "^0.5.9",
-    "ts-loader": "^5.3.0",
-    "ts-node": "^7.0.1",
-    "tslint": "^5.11.0",
-    "tslint-config-prettier": "^1.16.0",
-    "typescript": "^3.1.6",
-    "uglifyjs-webpack-plugin": "^2.0.1",
-    "webpack": "^4.26.0",
-    "webpack-cli": "^3.1.2",
-    "webpack-dev-server": "^3.1.10"
+    "mocha": "^6.0.2",
+    "nyc": "^13.3.0",
+    "prettier": "^1.16.4",
+    "publish-please": "^5.4.3",
+    "puppeteer": "^1.13.0",
+    "reflect-metadata": "^0.1.13",
+    "remap-istanbul": "^0.13.0",
+    "rimraf": "^2.6.3",
+    "sinon": "^7.2.7",
+    "sinon-chai": "^3.3.0",
+    "source-map-support": "^0.5.11",
+    "ts-loader": "^5.3.3",
+    "ts-node": "^8.0.3",
+    "tslint": "^5.14.0",
+    "tslint-config-prettier": "^1.18.0",
+    "typescript": "^3.3.3333",
+    "uglifyjs-webpack-plugin": "^2.1.2",
+    "webpack": "^4.29.6",
+    "webpack-cli": "^3.3.0",
+    "webpack-dev-server": "^3.2.1"
   }
 }

test/org/osflash/signals/SignalDispatchNoArgsTest.test.ts

@@ -42,7 +42,7 @@ describe("SignalDispatchNoArgsTest", () => {
     });
 
     function addOnceInHandler(done: Function): void {
-        signal.addOnce(async.add(new Function(), 10, done));
+        signal.addOnce(async.add(() => {}, 10, done));
         signal.dispatch();
     }
 });

test/org/osflash/signals/SlotListTest.test.ts

@@ -93,7 +93,7 @@ describe("SlotListTest", () => {
     });
 
     it("NIL_does_not_contain_anonymous_listener", () => {
-        assert.isFalse(SlotList.NIL.contains(new Function()));
+        assert.isFalse(SlotList.NIL.contains(() => {}));
     });
 
     it("find_in_empty_list_yields_null", () => {
@@ -211,10 +211,10 @@ describe("SlotListTest", () => {
     // Issue #56
     it("insertWithPriority_adds_4_slots_without_losing_any", () => {
         let s: PrioritySignal = new PrioritySignal();
-        let l1: Function = new Function();
-        let l2: Function = new Function();
-        let l3: Function = new Function();
-        let l4: Function = new Function();
+        let l1: Function = () => {};
+        let l2: Function = () => {};
+        let l3: Function = () => {};
+        let l4: Function = () => {};
         let slot1: ISlot = new Slot(l1, s);
         let slot2: ISlot = new Slot(l2, s, false, -1);
         let slot3: ISlot = new Slot(l3, s);