Fix 0.7 messages being recorded to server demos

Always repack messages as 0.6 before recording them to server demos, as server demos should only contain 0.6 messages.

This previously caused error messages to be logged when playing server demos that contained messages sent to 0.7 players. For example, passing the first checkpoint in the Tutorial map causes `protocol7::CNetMsg_Sv_Checkpoint` to be sent, which is an invalid message in 0.6 demos.

Note that messages to individual clients are now also recorded to demos independent from the result of calling `CAntibot::OnEngineServerMessage`, which is consistent with the behavior when sending messages to all clients with client ID `-1`.

Author: Robyt3

src/engine/server/server.cpp

@@ -945,32 +945,37 @@ int CServer::SendMsg(CMsgPacker *pMsg, int Flags, int ClientId)
 	}
 	else
 	{
-		CPacker Pack;
-		if(!RepackMsg(pMsg, Pack, m_aClients[ClientId].m_Sixup))
-			return -1;
-
-		Packet.m_ClientId = ClientId;
-		Packet.m_pData = Pack.Data();
-		Packet.m_DataSize = Pack.Size();
-
-		if(Antibot()->OnEngineServerMessage(ClientId, Packet.m_pData, Packet.m_DataSize, Flags))
-		{
-			return 0;
-		}
-
 		// write message to demo recorders
-		if(!(Flags & MSGFLAG_NORECORD))
+		if(!(Flags & MSGFLAG_NORECORD) &&
+			(m_aDemoRecorder[ClientId].IsRecording() || m_aDemoRecorder[RECORDER_MANUAL].IsRecording() || m_aDemoRecorder[RECORDER_AUTO].IsRecording()))
 		{
-			if(m_aDemoRecorder[ClientId].IsRecording())
-				m_aDemoRecorder[ClientId].RecordMessage(Pack.Data(), Pack.Size());
-			if(m_aDemoRecorder[RECORDER_MANUAL].IsRecording())
-				m_aDemoRecorder[RECORDER_MANUAL].RecordMessage(Pack.Data(), Pack.Size());
-			if(m_aDemoRecorder[RECORDER_AUTO].IsRecording())
-				m_aDemoRecorder[RECORDER_AUTO].RecordMessage(Pack.Data(), Pack.Size());
+			CPacker Pack6;
+			if(RepackMsg(pMsg, Pack6, false)) // server only records 0.6 messages to demos
+			{
+				if(m_aDemoRecorder[ClientId].IsRecording())
+					m_aDemoRecorder[ClientId].RecordMessage(Pack6.Data(), Pack6.Size());
+				if(m_aDemoRecorder[RECORDER_MANUAL].IsRecording())
+					m_aDemoRecorder[RECORDER_MANUAL].RecordMessage(Pack6.Data(), Pack6.Size());
+				if(m_aDemoRecorder[RECORDER_AUTO].IsRecording())
+					m_aDemoRecorder[RECORDER_AUTO].RecordMessage(Pack6.Data(), Pack6.Size());
+			}
 		}
 
 		if(!(Flags & MSGFLAG_NOSEND))
+		{
+			CPacker Pack;
+			if(!RepackMsg(pMsg, Pack, m_aClients[ClientId].m_Sixup))
+				return -1;
+
+			Packet.m_ClientId = ClientId;
+			Packet.m_pData = Pack.Data();
+			Packet.m_DataSize = Pack.Size();
+			if(Antibot()->OnEngineServerMessage(ClientId, Packet.m_pData, Packet.m_DataSize, Flags))
+			{
+				return 0;
+			}
 			m_NetServer.Send(&Packet);
+		}
 	}
 
 	return 0;