use direct settings

Author: VipinDevelops

github/GithubApp.ts

@@ -55,9 +55,7 @@ import { isGithubLink, hasGitHubCodeSegmentLink, hasGithubPRLink } from "./helpe
 import { SendReminder } from "./handlers/SendReminder";
 import { AppSettingsEnum, settings } from "./settings/settings";
 import { ISetting } from "@rocket.chat/apps-engine/definition/settings";
-
 import { handleGithubPRLinks } from "./handlers/GithubPRlinkHandler";
-import { UpdateSetting } from "./persistance/setting";
 
 export class GithubApp extends App implements IPreMessageSentExtend {
     constructor(info: IAppInfo, logger: ILogger, accessors: IAppAccessors) {
@@ -253,12 +251,6 @@ export class GithubApp extends App implements IPreMessageSentExtend {
                     interval:"0 9 * * *"
                 }
             },
-            {
-                id:ProcessorsEnum.SETTING_UPDATE,
-                processor:async(jobContext, read, modify, http, persis)=>{
-                    await UpdateSetting(read, persis, this.getAccessors().environmentReader.getSettings())
-                },
-            }
         ]);
         configuration.api.provideApi({
             visibility: ApiVisibility.PUBLIC,
@@ -277,18 +269,12 @@ export class GithubApp extends App implements IPreMessageSentExtend {
         await sendDirectMessageOnInstall(read, modify, user, persistence);
     }
 
-    public async onEnable(environment: IEnvironmentRead, configurationModify: IConfigurationModify): Promise<boolean> {
-        await configurationModify.scheduler.scheduleOnce({id:ProcessorsEnum.SETTING_UPDATE,when:"one second"});
-        return true;
-    }
-
     public async onSettingUpdated(setting: ISetting, configurationModify: IConfigurationModify, read: IRead, http: IHttp): Promise<void> {
         const interval: string = await this.getAccessors().environmentReader.getSettings().getValueById(AppSettingsEnum.ReminderCRONjobID);
         await configurationModify.scheduler.cancelJob(ProcessorsEnum.PR_REMINDER);
         await configurationModify.scheduler.scheduleRecurring({
             id: ProcessorsEnum.PR_REMINDER,
             interval: interval,
         })
-        await configurationModify.scheduler.scheduleOnce({id:ProcessorsEnum.SETTING_UPDATE,when:"one second"});
     }
 }

github/definitions/AppSetting.ts

@@ -1,5 +1,4 @@
 export enum ProcessorsEnum {
     REMOVE_GITHUB_LOGIN = 'remove_github_token',
     PR_REMINDER = 'pr_reminder',
-    SETTING_UPDATE  = 'setting_update'
 }

github/enum/Processors.ts

@@ -2,16 +2,14 @@ import { IHttp, IModify, IPersistence, IRead } from "@rocket.chat/apps-engine/de
 import { SlashCommandContext } from "@rocket.chat/apps-engine/definition/slashcommands";
 import { ButtonStyle, TextObjectType, UIKitInteractionContext } from "@rocket.chat/apps-engine/definition/uikit";
 import { IUIKitModalViewParam } from "@rocket.chat/apps-engine/definition/uikit/UIKitInteractionResponder";
-import { AppEnum } from "../enum/App";
 import { ModalsEnum } from "../enum/Modals";
 import { GitHubApi } from "../helpers/githubSDKclass";
-import { GetSetting } from "../persistance/setting";
 import { UserInformation } from "../definitions/Userinfo";
 import {
     getInteractionRoomData,
     storeInteractionRoomData,
 } from "../persistance/roomInteraction";
-import { IAppSetting } from "../definitions/AppSetting";
+import { AppSettingsEnum } from "../settings/settings";
 
 export async function userProfileModal({
     access_token,
@@ -48,12 +46,13 @@ export async function userProfileModal({
     }
     let userInfo: UserInformation | undefined;
     try {
-        const settings:IAppSetting = await GetSetting(read);
+        let BaseHost = await read.getEnvironmentReader().getSettings().getValueById(AppSettingsEnum.BaseHostID);
+        let BaseApiHost = await read.getEnvironmentReader().getSettings().getValueById(AppSettingsEnum.BaseApiHostID);
         const gitHubApiClient = new GitHubApi(
             http,
             access_token,
-            settings!.BaseHost,
-            settings!.BaseApiHost
+            BaseHost,
+            BaseApiHost
         );
         userInfo = await gitHubApiClient.getBasicUserInfo();
     } catch (error) {