diff --git a/github/handlers/ExecuteBlockActionHandler.ts b/github/handlers/ExecuteBlockActionHandler.ts index ecf8576..a13cdee 100644 --- a/github/handlers/ExecuteBlockActionHandler.ts +++ b/github/handlers/ExecuteBlockActionHandler.ts @@ -992,23 +992,17 @@ export class ExecuteBlockActionHandler { break; } case ModalsEnum.MULTI_SHARE_ADD_GITHUB_ISSUE_ACTION:{ - let { user, room } = await context.getInteractionData(); + let { user } = await context.getInteractionData(); + let room: IRoom | undefined; let issueId: string = context.getInteractionData().value as string; - let roomId:string=""; + let roomId: string = ""; if(user?.id){ - if(room?.id){ - roomId = room.id; - }else{ - roomId = ( - await getInteractionRoomData( - this.read.getPersistenceReader(), - user.id - ) - ).roomId; - room = await this.read.getRoomReader().getById(roomId) as IRoom; - } - let githubissueStorage = new GithubRepoIssuesStorage(this.persistence,this.read.getPersistenceReader()); - let repoIssuesData: IGitHubIssueData = await githubissueStorage.getIssueData(room?.id as string,user); + roomId = (await getInteractionRoomData(this.read.getPersistenceReader(), user.id)).roomId; + room = await this.read.getRoomReader().getById(roomId) as IRoom; + + if(room){ + let githubissueStorage = new GithubRepoIssuesStorage(this.persistence,this.read.getPersistenceReader()); + let repoIssuesData: IGitHubIssueData = await githubissueStorage.getIssueData(room?.id as string,user); if(repoIssuesData?.issue_list?.length){ let index = -1; let currentIndex = 0; @@ -1037,7 +1031,8 @@ export class ExecuteBlockActionHandler { http: this.http, }) await this.modify.getUiController().updateModalView(githubIssuesModal, { triggerId: context.getInteractionData().triggerId }, context.getInteractionData().user); - } + } + } } break; } diff --git a/github/modals/getIssuesStarterModal.ts b/github/modals/getIssuesStarterModal.ts index 8fe860d..f18fd50 100644 --- a/github/modals/getIssuesStarterModal.ts +++ b/github/modals/getIssuesStarterModal.ts @@ -82,7 +82,6 @@ export async function GitHubIssuesStarterModal({ }, }), submit: block.newButtonElement({ - actionId: ModalsEnum.NEW_ISSUE_STARTER__ACTION, text: { type: TextObjectType.PLAINTEXT, emoji:true,