Skip to content

[FIX]: Fix Share Issues Bug #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+11 −17
Open

[FIX]: Fix Share Issues Bug #132

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 11 additions & 16 deletions github/handlers/ExecuteBlockActionHandler.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -992,23 +992,17 @@ export class ExecuteBlockActionHandler {
break;
}
case ModalsEnum.MULTI_SHARE_ADD_GITHUB_ISSUE_ACTION:{
let { user, room } = await context.getInteractionData();
let { user } = await context.getInteractionData();
let room: IRoom | undefined;
let issueId: string = context.getInteractionData().value as string;
let roomId:string="";
let roomId: string = "";
if(user?.id){
if(room?.id){
roomId = room.id;
}else{
roomId = (
await getInteractionRoomData(
this.read.getPersistenceReader(),
user.id
)
).roomId;
room = await this.read.getRoomReader().getById(roomId) as IRoom;
}
let githubissueStorage = new GithubRepoIssuesStorage(this.persistence,this.read.getPersistenceReader());
let repoIssuesData: IGitHubIssueData = await githubissueStorage.getIssueData(room?.id as string,user);
roomId = (await getInteractionRoomData(this.read.getPersistenceReader(), user.id)).roomId;
room = await this.read.getRoomReader().getById(roomId) as IRoom;

if(room){
let githubissueStorage = new GithubRepoIssuesStorage(this.persistence,this.read.getPersistenceReader());
let repoIssuesData: IGitHubIssueData = await githubissueStorage.getIssueData(room?.id as string,user);
if(repoIssuesData?.issue_list?.length){
let index = -1;
let currentIndex = 0;
Expand Down Expand Up @@ -1037,7 +1031,8 @@ export class ExecuteBlockActionHandler {
http: this.http,
})
await this.modify.getUiController().updateModalView(githubIssuesModal, { triggerId: context.getInteractionData().triggerId }, context.getInteractionData().user);
}
}
}
}
break;
}
Expand Down
1 change: 0 additions & 1 deletion github/modals/getIssuesStarterModal.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,6 @@ export async function GitHubIssuesStarterModal({
},
}),
submit: block.newButtonElement({
actionId: ModalsEnum.NEW_ISSUE_STARTER__ACTION,
text: {
type: TextObjectType.PLAINTEXT,
emoji:true,
Expand Down