Skip to content

[Bug]: Contextual bar actions do not work and duplicate reply names are allowed during edits #70

@sezallagwal

Description

@sezallagwal

What happened?

Overview

This issue covers two distinct bugs within the quick replies list (/quick list) and the editing flow.

Bug 1: Send, Edit, and Delete actions in quick replies list do nothing

When opening the quick replies list and clicking Send, Edit, or Delete from the overflow menu (⋮) on any reply, nothing happens — no modal opens, no error is shown.

Root Cause:
In ExecuteBlockActionHandler.ts, the room fallback uses strict equality:
if (room === undefined) {
For contextual bar block interactions, getInteractionData().room returns null (not undefined). The strict check misses null, forcing room to stay null. Following this, the if (room) guard around the Send/Edit/Delete switch evaluates to false, silently skipping the execution of all three actions.


Bug 2: Duplicate reply names allowed when editing

When editing a reply and changing its name to perfectly match another existing reply, the app accepts it and saves it instead of showing a validation error.

Root Cause:
In ReplyStorage.ts, the isUniqueReplyName method has a no-op comparison:

if (replyFound && replyId) {
    replyFound.id === replyId;  // comparison result is discarded!
    return true;                // always returns true
}

Steps to reproduce

  1. Open any channel and run /quick list.
  2. Click the overflow menu (⋮) on any reply.
  3. Click Send, Edit, or Delete.
  4. Expected: A modal opens for the selected action.
  5. Actual: Nothing happens.

Relevant ScreenShots

No response

Version

8.1.1

What browsers are you seeing the problem on?

Chrome

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions