Merge pull request #2454 from RocketChat/develop

philipbrito · web-flow · commit 4c78f18e3ab8 · 2019-08-20T15:36:01.000-03:00
[RELEASE] Merge DEVELOP into BETA
diff --git a/app/build.gradle b/app/build.gradle
@@ -18,8 +18,8 @@ android {
         applicationId "chat.rocket.android"
         minSdkVersion versions.minSdk
         targetSdkVersion versions.targetSdk
-        versionCode 2074
-        versionName "3.5.0"
+        versionCode 2075
+        versionName "3.5.1"
         testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"
         multiDexEnabled true
 
diff --git a/app/src/main/AndroidManifest.xml b/app/src/main/AndroidManifest.xml
@@ -1,6 +1,7 @@
 <?xml version="1.0" encoding="utf-8"?>
 <manifest xmlns:android="http://schemas.android.com/apk/res/android"
     xmlns:tools="http://schemas.android.com/tools"
+    android:sharedUserId="chat.rocket.android"
     package="chat.rocket.android">
 
     <uses-permission android:name="android.permission.INTERNET" />
diff --git a/app/src/main/java/chat/rocket/android/authentication/login/presentation/LoginPresenter.kt b/app/src/main/java/chat/rocket/android/authentication/login/presentation/LoginPresenter.kt
@@ -149,7 +149,9 @@ class LoginPresenter @Inject constructor(
             icon,
             logo,
             username,
-            thumb
+            thumb,
+            token?.userId,
+            token?.authToken
         )
         saveAccountInteractor.save(account)
     }
diff --git a/app/src/main/java/chat/rocket/android/authentication/loginoptions/presentation/LoginOptionsPresenter.kt b/app/src/main/java/chat/rocket/android/authentication/loginoptions/presentation/LoginOptionsPresenter.kt
@@ -190,7 +190,9 @@ class LoginOptionsPresenter @Inject constructor(
             icon,
             logo,
             username,
-            thumb
+            thumb,
+            token?.userId,
+            token?.authToken
         )
         saveAccountInteractor.save(account)
     }
diff --git a/app/src/main/java/chat/rocket/android/authentication/registerusername/presentation/RegisterUsernamePresenter.kt b/app/src/main/java/chat/rocket/android/authentication/registerusername/presentation/RegisterUsernamePresenter.kt
@@ -88,7 +88,9 @@ class RegisterUsernamePresenter @Inject constructor(
             icon,
             logo,
             username,
-            thumb
+            thumb,
+            token?.userId,
+            token?.authToken
         )
         saveAccountInteractor.save(account)
     }
diff --git a/app/src/main/java/chat/rocket/android/authentication/signup/presentation/SignupPresenter.kt b/app/src/main/java/chat/rocket/android/authentication/signup/presentation/SignupPresenter.kt
@@ -109,7 +109,9 @@ class SignupPresenter @Inject constructor(
             icon,
             logo,
             me.username!!,
-            thumb
+            thumb,
+            token?.userId,
+            token?.authToken
         )
         saveAccountInteractor.save(account)
     }
diff --git a/app/src/main/java/chat/rocket/android/authentication/twofactor/presentation/TwoFAPresenter.kt b/app/src/main/java/chat/rocket/android/authentication/twofactor/presentation/TwoFAPresenter.kt
@@ -110,7 +110,9 @@ class TwoFAPresenter @Inject constructor(
             icon,
             logo,
             me.username!!,
-            thumb
+            thumb,
+            token?.userId,
+            token?.authToken
         )
         saveAccountInteractor.save(account)
     }
diff --git a/app/src/main/java/chat/rocket/android/chatroom/ui/ChatRoomActivity.kt b/app/src/main/java/chat/rocket/android/chatroom/ui/ChatRoomActivity.kt
@@ -4,6 +4,7 @@ import DrawableHelper
 import android.content.Context
 import android.content.Intent
 import android.os.Bundle
+import android.text.method.ScrollingMovementMethod
 import android.view.View
 import androidx.appcompat.app.AppCompatActivity
 import androidx.fragment.app.Fragment
@@ -143,6 +144,7 @@ class ChatRoomActivity : AppCompatActivity(), HasSupportFragmentInjector {
             text_toolbar_title,
             DrawableHelper.getDrawableFromId(R.drawable.ic_chatroom_toolbar_expand_more_20dp, this)
         )
+        text_toolbar_title.movementMethod = ScrollingMovementMethod()
         text_toolbar_title.setOnClickListener { listener(it) }
     }
 
diff --git a/app/src/main/java/chat/rocket/android/chatroom/ui/ChatRoomFragment.kt b/app/src/main/java/chat/rocket/android/chatroom/ui/ChatRoomFragment.kt
@@ -746,8 +746,8 @@ class ChatRoomFragment : Fragment(), ChatRoomView, EmojiKeyboardListener, EmojiR
     }
 
     private fun setReactionButtonIcon(@DrawableRes drawableId: Int) {
-        button_add_reaction_or_show_keyboard.setImageResource(drawableId)
-        button_add_reaction_or_show_keyboard.tag = drawableId
+        button_add_reaction_or_show_keyboard?.setImageResource(drawableId)
+        button_add_reaction_or_show_keyboard?.tag = drawableId
     }
 
     override fun showFileSelection(filter: Array<String>?) {
@@ -929,9 +929,11 @@ class ChatRoomFragment : Fragment(), ChatRoomView, EmojiKeyboardListener, EmojiR
             }
 
             button_send.setOnClickListener {
-                var textMessage = citation ?: ""
-                textMessage += text_message.textContent
-                sendMessage(textMessage)
+                text_message.textContent.run {
+                    if(this.isNotBlank()) {
+                        sendMessage(citation ?: "" + this)
+                    }
+                }
             }
 
             button_show_attachment_options.setOnClickListener {
diff --git a/app/src/main/java/chat/rocket/android/main/presentation/MainPresenter.kt b/app/src/main/java/chat/rocket/android/main/presentation/MainPresenter.kt
@@ -2,11 +2,13 @@ package chat.rocket.android.main.presentation
 
 import chat.rocket.android.authentication.domain.model.DeepLinkInfo
 import chat.rocket.android.core.behaviours.AppLanguageView
+import chat.rocket.android.helper.UserHelper
 import chat.rocket.android.push.GroupedPush
-import chat.rocket.android.server.domain.GetCurrentLanguageInteractor
-import chat.rocket.android.server.domain.RefreshPermissionsInteractor
-import chat.rocket.android.server.domain.RefreshSettingsInteractor
+import chat.rocket.android.server.domain.*
+import chat.rocket.android.server.domain.model.Account
 import chat.rocket.android.server.infrastructure.ConnectionManagerFactory
+import chat.rocket.android.util.extensions.avatarUrl
+import chat.rocket.android.util.extensions.serverLogoUrl
 import javax.inject.Inject
 import javax.inject.Named
 
@@ -16,10 +18,16 @@ class MainPresenter @Inject constructor(
     private val appLanguageView: AppLanguageView,
     private val refreshSettingsInteractor: RefreshSettingsInteractor,
     private val refreshPermissionsInteractor: RefreshPermissionsInteractor,
+    private val getSettingsInteractor: GetSettingsInteractor,
     private val connectionManagerFactory: ConnectionManagerFactory,
     private var getLanguageInteractor: GetCurrentLanguageInteractor,
-    private val groupedPush: GroupedPush
+    private val groupedPush: GroupedPush,
+    private val tokenRepository: TokenRepository,
+    private val userHelper: UserHelper,
+    private val saveAccountInteractor: SaveAccountInteractor,
+    private val removeAccountInteractor: RemoveAccountInteractor
 ) {
+
     fun connect() = currentServer?.let {
         refreshSettingsInteractor.refreshAsync(it)
         refreshPermissionsInteractor.refreshAsync(it)
@@ -44,4 +52,39 @@ class MainPresenter @Inject constructor(
             }
         }
     }
+
+    fun removeOldAccount() = currentServer?.let {
+        removeAccountInteractor.remove(currentServer)
+    }
+
+    fun saveNewAccount() {
+        currentServer?.let { currentServer ->
+            with(getSettingsInteractor.get(currentServer)) {
+                val icon = favicon()?.let {
+                    currentServer.serverLogoUrl(it)
+                }
+                val logo = wideTile()?.let {
+                    currentServer.serverLogoUrl(it)
+                }
+                val token = tokenRepository.get(currentServer)
+                val thumb = currentServer.avatarUrl(
+                    userHelper.username() ?: "",
+                    token?.userId,
+                    token?.authToken
+                )
+
+                val account = Account(
+                    siteName() ?: currentServer,
+                    currentServer,
+                    icon,
+                    logo,
+                    userHelper.username() ?: "",
+                    thumb,
+                    token?.userId,
+                    token?.authToken
+                )
+                saveAccountInteractor.save(account)
+            }
+        }
+    }
 }
diff --git a/app/src/main/java/chat/rocket/android/main/ui/MainActivity.kt b/app/src/main/java/chat/rocket/android/main/ui/MainActivity.kt
@@ -47,6 +47,8 @@ class MainActivity : AppCompatActivity(), HasActivityInjector,
         with(presenter) {
             connect()
             getAppLanguage()
+            removeOldAccount()
+            saveNewAccount()
             intent.getStringExtra(INTENT_CHAT_ROOM_ID).let {
                 clearNotificationsForChatRoom(it)
                 showChatList(it, deepLinkInfo)
diff --git a/app/src/main/java/chat/rocket/android/profile/presentation/ProfilePresenter.kt b/app/src/main/java/chat/rocket/android/profile/presentation/ProfilePresenter.kt
@@ -98,7 +98,7 @@ class ProfilePresenter @Inject constructor(
                             username = username
                         )
                     }
-                    view.showProfileUpdateSuccessfullyMessage()
+                    view.onProfileUpdatedSuccessfully(email, name, username)
                     view.showProfile(
                         user.status.toString(),
                         serverUrl.avatarUrl(user.username!!, token?.userId, token?.authToken),
diff --git a/app/src/main/java/chat/rocket/android/profile/presentation/ProfileView.kt b/app/src/main/java/chat/rocket/android/profile/presentation/ProfileView.kt
@@ -31,7 +31,11 @@ interface ProfileView : TokenView, LoadingView, MessageView {
     fun reloadUserAvatar(avatarUrl: String)
 
     /**
-     * Shows a profile update successfully message
+     * It is called when the user profile was updated successfully.
      */
-    fun showProfileUpdateSuccessfullyMessage()
+    fun onProfileUpdatedSuccessfully(
+        updatedEmail: String,
+        updatedName: String,
+        updatedUserName: String
+    )
 }
diff --git a/app/src/main/java/chat/rocket/android/profile/ui/ProfileFragment.kt b/app/src/main/java/chat/rocket/android/profile/ui/ProfileFragment.kt
@@ -146,10 +146,13 @@ class ProfileFragment : Fragment(), ProfileView, ActionMode.Callback {
 
     override fun reloadUserAvatar(avatarUrl: String) {
         Fresco.getImagePipeline().evictFromCache(avatarUrl.toUri())
-        image_avatar.setImageURI(avatarUrl)
+        image_avatar?.setImageURI(avatarUrl)
     }
 
-    override fun showProfileUpdateSuccessfullyMessage() {
+    override fun onProfileUpdatedSuccessfully(updatedEmail: String, updatedName: String, updatedUserName: String) {
+        currentEmail = updatedEmail
+        currentName = updatedName
+        currentUsername = updatedUserName
         showMessage(getString(R.string.msg_profile_updated_successfully))
     }
 
@@ -190,22 +193,22 @@ class ProfileFragment : Fragment(), ProfileView, ActionMode.Callback {
     override fun onActionItemClicked(mode: ActionMode, menuItem: MenuItem): Boolean {
         return when (menuItem.itemId) {
             R.id.action_update_profile -> {
-                presenter.updateUserProfile(
-                    text_email.textContent,
-                    text_name.textContent,
-                    text_username.textContent
-                )
+                updateProfile()
                 mode.finish()
                 true
             }
-            else -> {
-                false
-            }
+            else -> false
         }
     }
 
     override fun onDestroyActionMode(mode: ActionMode) {
         actionMode = null
+        if (text_email.textContent != currentEmail
+            || text_username.textContent != currentUsername
+            || text_name.textContent != currentName
+        ) {
+            showChangesNotSavedDialog()
+        }
     }
 
     private fun setupToolbar() {
@@ -287,8 +290,8 @@ class ProfileFragment : Fragment(), ProfileView, ActionMode.Callback {
             text_email.asObservable()
         ) { text_name, text_username, text_email ->
             return@combineLatest (text_name.toString() != currentName ||
-                text_username.toString() != currentUsername ||
-                text_email.toString() != currentEmail)
+                    text_username.toString() != currentUsername ||
+                    text_email.toString() != currentEmail)
         }.subscribe { isValid ->
             activity?.invalidateOptionsMenu()
             if (isValid) {
@@ -375,4 +378,30 @@ class ProfileFragment : Fragment(), ProfileView, ActionMode.Callback {
             }
         }
     }
+
+    private fun showChangesNotSavedDialog() {
+        context?.let {
+            val builder = AlertDialog.Builder(it)
+            builder.setMessage(R.string.msg_changes_not_saved)
+                .setPositiveButton(R.string.msg_save) { _, _ ->
+                    updateProfile()
+                }
+                .setNegativeButton(android.R.string.cancel) { _, _ ->
+                    text_email.setText(currentEmail)
+                    text_username.setText(currentUsername)
+                    text_name.setText(currentName)
+                }
+                .create()
+                .show()
+        }
+
+    }
+
+    private fun updateProfile() {
+        presenter.updateUserProfile(
+            text_email.textContent,
+            text_name.textContent,
+            text_username.textContent
+        )
+    }
 }
diff --git a/app/src/main/java/chat/rocket/android/server/domain/model/Account.kt b/app/src/main/java/chat/rocket/android/server/domain/model/Account.kt
@@ -6,8 +6,10 @@ import se.ansman.kotshi.JsonSerializable
 data class Account(
     val serverName: String?,
     val serverUrl: String,
-    val serverLogo: String?,
-    val serverBg: String?,
+    val serverLogoUrl: String?,
+    val serverBackgroundImageUrl: String?,
     val userName: String,
-    val avatar: String?
+    val userAvatarUrl: String?,
+    val authToken: String?,
+    val userId: String?
 )
diff --git a/app/src/main/java/chat/rocket/android/servers/adapter/ServerViewHolder.kt b/app/src/main/java/chat/rocket/android/servers/adapter/ServerViewHolder.kt
@@ -12,7 +12,7 @@ class ServerViewHolder(itemView: View, private val currentServerUrl: String) :
 
     fun bind(account: Account) {
         with(itemView) {
-            Glide.with(context).load(account.serverLogo).into(image_server)
+            Glide.with(context).load(account.serverLogoUrl).into(image_server)
             text_server_name.text = account.serverName ?: account.serverUrl
             text_server_url.text = account.serverUrl
             image_check.isInvisible = currentServerUrl != account.serverUrl
diff --git a/app/src/main/java/chat/rocket/android/settings/presentation/SettingsPresenter.kt b/app/src/main/java/chat/rocket/android/settings/presentation/SettingsPresenter.kt
@@ -67,6 +67,7 @@ class SettingsPresenter @Inject constructor(
     fun setupView() {
         launchUI(strategy) {
             try {
+                view.showLoading()
                 currentServer?.let {
                     val serverInfo = retryIO(description = "serverInfo", times = 5) {
                         rocketChatClientFactory.get(it).serverInfo()
@@ -91,6 +92,8 @@ class SettingsPresenter @Inject constructor(
                 }.ifNull {
                     view.showGenericErrorMessage()
                 }
+            } finally {
+                view.hideLoading()
             }
         }
     }
diff --git a/app/src/main/java/chat/rocket/android/settings/ui/SettingsFragment.kt b/app/src/main/java/chat/rocket/android/settings/ui/SettingsFragment.kt
@@ -11,6 +11,7 @@ import android.widget.EditText
 import androidx.appcompat.app.AlertDialog
 import androidx.appcompat.app.AppCompatActivity
 import androidx.core.net.toUri
+import androidx.core.view.isInvisible
 import androidx.core.view.isVisible
 import androidx.fragment.app.Fragment
 import chat.rocket.android.BuildConfig
@@ -117,11 +118,13 @@ class SettingsFragment : Fragment(), SettingsView, AppLanguageView {
     override fun invalidateToken(token: String) = invalidateFirebaseToken(token)
 
     override fun showLoading() {
-        view_loading.isVisible = true
+        view_loading?.isVisible = true
+        group_settings?.isInvisible = true
     }
 
     override fun hideLoading() {
-        view_loading.isVisible = false
+        view_loading?.isVisible = false
+        group_settings?.isInvisible = false
     }
 
     override fun showMessage(resId: Int) {
diff --git a/app/src/main/res/layout/app_bar_chat_room.xml b/app/src/main/res/layout/app_bar_chat_room.xml
@@ -18,10 +18,15 @@
 
         <TextView
             android:id="@+id/text_toolbar_title"
+            android:scrollbars="horizontal"
+            android:singleLine="true"
+            android:ellipsize="none"
+            android:maxWidth="200dp"
             style="@style/ChatRoom.ChatName.TextView"
             android:layout_width="wrap_content"
             android:layout_height="wrap_content"
             tools:text="Product Team" />
+
     </androidx.appcompat.widget.Toolbar>
 
 </com.google.android.material.appbar.AppBarLayout>
diff --git a/app/src/main/res/layout/fragment_settings.xml b/app/src/main/res/layout/fragment_settings.xml
diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml

Original file line number	Diff line number	Diff line change
`@@ -149,7 +149,9 @@ class LoginPresenter @Inject constructor(`
`149`	`149`	`icon,`
`150`	`150`	`logo,`
`151`	`151`	`username,`
`152`		`- thumb`
	`152`	`+ thumb,`
	`153`	`+ token?.userId,`
	`154`	`+ token?.authToken`
`153`	`155`	`)`
`154`	`156`	`saveAccountInteractor.save(account)`
`155`	`157`	`}`
Original file line number	Diff line number	Diff line change
`@@ -190,7 +190,9 @@ class LoginOptionsPresenter @Inject constructor(`
`190`	`190`	`icon,`
`191`	`191`	`logo,`
`192`	`192`	`username,`
`193`		`- thumb`
	`193`	`+ thumb,`
	`194`	`+ token?.userId,`
	`195`	`+ token?.authToken`
`194`	`196`	`)`
`195`	`197`	`saveAccountInteractor.save(account)`
`196`	`198`	`}`
Original file line number	Diff line number	Diff line change
`@@ -88,7 +88,9 @@ class RegisterUsernamePresenter @Inject constructor(`
`88`	`88`	`icon,`
`89`	`89`	`logo,`
`90`	`90`	`username,`
`91`		`- thumb`
	`91`	`+ thumb,`
	`92`	`+ token?.userId,`
	`93`	`+ token?.authToken`
`92`	`94`	`)`
`93`	`95`	`saveAccountInteractor.save(account)`
`94`	`96`	`}`
Original file line number	Diff line number	Diff line change
`@@ -109,7 +109,9 @@ class SignupPresenter @Inject constructor(`
`109`	`109`	`icon,`
`110`	`110`	`logo,`
`111`	`111`	`me.username!!,`
`112`		`- thumb`
	`112`	`+ thumb,`
	`113`	`+ token?.userId,`
	`114`	`+ token?.authToken`
`113`	`115`	`)`
`114`	`116`	`saveAccountInteractor.save(account)`
`115`	`117`	`}`
Original file line number	Diff line number	Diff line change
`@@ -110,7 +110,9 @@ class TwoFAPresenter @Inject constructor(`
`110`	`110`	`icon,`
`111`	`111`	`logo,`
`112`	`112`	`me.username!!,`
`113`		`- thumb`
	`113`	`+ thumb,`
	`114`	`+ token?.userId,`
	`115`	`+ token?.authToken`
`114`	`116`	`)`
`115`	`117`	`saveAccountInteractor.save(account)`
`116`	`118`	`}`
Original file line number	Diff line number	Diff line change
`@@ -4,6 +4,7 @@ import DrawableHelper`
`4`	`4`	`import android.content.Context`
`5`	`5`	`import android.content.Intent`
`6`	`6`	`import android.os.Bundle`
	`7`	`+import android.text.method.ScrollingMovementMethod`
`7`	`8`	`import android.view.View`
`8`	`9`	`import androidx.appcompat.app.AppCompatActivity`
`9`	`10`	`import androidx.fragment.app.Fragment`
`@@ -143,6 +144,7 @@ class ChatRoomActivity : AppCompatActivity(), HasSupportFragmentInjector {`
`143`	`144`	`text_toolbar_title,`
`144`	`145`	`DrawableHelper.getDrawableFromId(R.drawable.ic_chatroom_toolbar_expand_more_20dp, this)`
`145`	`146`	`)`
	`147`	`+ text_toolbar_title.movementMethod = ScrollingMovementMethod()`
`146`	`148`	`text_toolbar_title.setOnClickListener { listener(it) }`
`147`	`149`	`}`
`148`	`150`
Original file line number	Diff line number	Diff line change
`@@ -746,8 +746,8 @@ class ChatRoomFragment : Fragment(), ChatRoomView, EmojiKeyboardListener, EmojiR`
`746`	`746`	`}`
`747`	`747`
`748`	`748`	`private fun setReactionButtonIcon(@DrawableRes drawableId: Int) {`
`749`		`- button_add_reaction_or_show_keyboard.setImageResource(drawableId)`
`750`		`- button_add_reaction_or_show_keyboard.tag = drawableId`
	`749`	`+ button_add_reaction_or_show_keyboard?.setImageResource(drawableId)`
	`750`	`+ button_add_reaction_or_show_keyboard?.tag = drawableId`
`751`	`751`	`}`
`752`	`752`
`753`	`753`	`override fun showFileSelection(filter: Array<String>?) {`
`@@ -929,9 +929,11 @@ class ChatRoomFragment : Fragment(), ChatRoomView, EmojiKeyboardListener, EmojiR`
`929`	`929`	`}`
`930`	`930`
`931`	`931`	`button_send.setOnClickListener {`
`932`		`- var textMessage = citation ?: ""`
`933`		`- textMessage += text_message.textContent`
`934`		`- sendMessage(textMessage)`
	`932`	`+ text_message.textContent.run {`
	`933`	`+ if(this.isNotBlank()) {`
	`934`	`+ sendMessage(citation ?: "" + this)`
	`935`	`+ }`
	`936`	`+ }`
`935`	`937`	`}`
`936`	`938`
`937`	`939`	`button_show_attachment_options.setOnClickListener {`