fix: interval for metrics kept subprocess alive

RocketChat/Rocket.Chat#34894

Author: d-gubert

deno-runtime/lib/metricsCollector.ts

@@ -1,5 +1,5 @@
-import { writeAll } from "https://deno.land/[email protected]/io/write_all.ts";
-import { Queue } from "./messenger.ts";
+import { writeAll } from 'https://deno.land/[email protected]/io/write_all.ts';
+import { Queue } from './messenger.ts';
 
 export function collectMetrics() {
     return {
@@ -15,17 +15,3 @@ export async function sendMetrics() {
 
     await writeAll(Deno.stderr, encoder.encode(JSON.stringify(metrics)));
 }
-
-let intervalId: number;
-
-export function startMetricsReport(frequencyInMs = 5000) {
-    if (intervalId) {
-        throw new Error('There is already an active metrics report');
-    }
-
-    intervalId = setInterval(sendMetrics, frequencyInMs);
-}
-
-export function abortMetricsReport() {
-    clearInterval(intervalId);
-}

deno-runtime/main.ts

@@ -22,8 +22,7 @@ import apiHandler from './handlers/api-handler.ts';
 import handleApp from './handlers/app/handler.ts';
 import handleScheduler from './handlers/scheduler-handler.ts';
 import registerErrorListeners from './error-handlers.ts';
-import { startMetricsReport } from './lib/metricsCollector.ts';
-import { parseArgs } from './lib/parseArgs.ts';
+import { sendMetrics } from './lib/metricsCollector.ts';
 
 type Handlers = {
     app: typeof handleApp;
@@ -105,7 +104,8 @@ async function main() {
         try {
             // Process PING command first as it is not JSON RPC
             if (message === COMMAND_PING) {
-                Messenger.pongResponse();
+                void Messenger.pongResponse();
+                void sendMetrics();
                 continue;
             }
 
@@ -129,10 +129,6 @@ async function main() {
     }
 }
 
-const mainArgs = parseArgs(Deno.args);
-
 registerErrorListeners();
 
 main();
-
-startMetricsReport(mainArgs.metricsReportFrequencyInMs);