fix: type error in RoomSubscription (#6696)

OtavioStasiak · web-flow · commit 4711030967e2 · 2025-10-06T12:46:48.000-03:00
* fix: activities as undefined

* chore: code improvements

* chore: code improvements

* chore: code improvements
diff --git a/app/lib/methods/subscriptions/room.ts b/app/lib/methods/subscriptions/room.ts
@@ -134,10 +134,10 @@ export default class RoomSubscription {
 			const [name, activities] = ddpMessage.fields.args;
 			const key = UI_Use_Real_Name ? 'name' : 'username';
 			if (name !== user[key]) {
-				if (activities.includes('user-typing')) {
+				if (!!activities && activities.includes('user-typing')) {
 					reduxStore.dispatch(addUserTyping(name));
 				}
-				if (!activities.length) {
+				if (!activities?.length) {
 					reduxStore.dispatch(removeUserTyping(name));
 				}
 			}

Original file line number	Diff line number	Diff line change
`@@ -134,10 +134,10 @@ export default class RoomSubscription {`
`134`	`134`	`const [name, activities] = ddpMessage.fields.args;`
`135`	`135`	`const key = UI_Use_Real_Name ? 'name' : 'username';`
`136`	`136`	`if (name !== user[key]) {`
`137`		`- if (activities.includes('user-typing')) {`
	`137`	`+ if (!!activities && activities.includes('user-typing')) {`
`138`	`138`	`reduxStore.dispatch(addUserTyping(name));`
`139`	`139`	`}`
`140`		`- if (!activities.length) {`
	`140`	`+ if (!activities?.length) {`
`141`	`141`	`reduxStore.dispatch(removeUserTyping(name));`
`142`	`142`	`}`
`143`	`143`	`}`