Skip to content

Commit 4fa9396

Browse files
feat(a11y): inline errors RegisterView (#6291)
* feat: start multi fields experience test * feat: added new i18n translation * fix: accessibility label of formTextInpout * fix: lint * fix: tests * action: organized translations * fix: controlled text input * adjust formTextInput style * fix: password must match * fix: tests * chore: clean comments * fix: password validation * fix: translation * chore: improve password validation * fix: remove verifyPassword conditional --------- Co-authored-by: OtavioStasiak <[email protected]>
1 parent 3cd133f commit 4fa9396

File tree

27 files changed

+175
-25
lines changed

27 files changed

+175
-25
lines changed

app/containers/TextInput/FormTextInput.tsx

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,6 +79,7 @@ export interface IRCTextInputProps extends TextInputProps {
7979
left?: JSX.Element;
8080
bottomSheet?: boolean;
8181
onClearInput?: () => void;
82+
showErrorMessage?: boolean;
8283
}
8384

8485
const getInputError = (error: unknown): string => {
@@ -108,6 +109,7 @@ export const FormTextInput = ({
108109
bottomSheet,
109110
placeholder,
110111
accessibilityLabel,
112+
showErrorMessage = true,
111113
...inputProps
112114
}: IRCTextInputProps): React.ReactElement => {
113115
const { colors } = useTheme();
@@ -224,7 +226,7 @@ export const FormTextInput = ({
224226
) : null}
225227
{left}
226228
</View>
227-
{inputError ? (
229+
{showErrorMessage && inputError ? (
228230
<View accessible={false} style={styles.errorContainer}>
229231
<CustomIcon accessible={false} name='warning' size={16} color={colors.fontDanger} />
230232
<Text accessible={false} style={{ ...styles.error, color: colors.fontDanger }}>

app/i18n/locales/ar.json

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -92,6 +92,7 @@
9292
"Code_required": "الكود مطلوب",
9393
"Collaborative": "تعاونية",
9494
"Confirm": "تأكيد",
95+
"Confirm_password": "تأكيد كلمة المرور",
9596
"Confirm_Password": "تأكيد كلمة المرور",
9697
"Connect": "اتصال",
9798
"Connect_to_server_as_user": "اتصل بـ {{serverUrl}} كـ {{user}}",
@@ -194,6 +195,8 @@
194195
"Favorite": "مفضل",
195196
"Favorites": "مفضلات",
196197
"Fetch_image_from_URL": "جلب الصورة من الرابط",
198+
"Field_are_required": "{{field}} مطلوبة",
199+
"Field_is_required": "{{field}} مطلوب",
197200
"File_description": "وصف الملف",
198201
"Files": "ملفات",
199202
"Filter": "مرشح",
@@ -381,6 +384,7 @@
381384
"Password": "كلمة المرور",
382385
"Password_Tip_Error": "الشرط غير محقق.",
383386
"Password_Tip_Success": "تم استيفاء الشرط.",
387+
"Passwords_do_not_match": "كلمات المرور غير متطابقة",
384388
"Pause": "توقف مؤقت",
385389
"Permalink_copied_to_clipboard": "تم نسخ الرابط الثابت إلى الحافظة!",
386390
"Phone": "الهاتف",
@@ -565,6 +569,7 @@
565569
"User_Info": "معلومات المستخدم",
566570
"User_sent_an_attachment": "{{user}} أرسل مرفقًا",
567571
"Username": "اسم المستخدم",
572+
"Username_is_already_in_use": "اسم المستخدم قيد الاستخدام بالفعل.",
568573
"Username_not_available": "اسم المستخدم غير متاح",
569574
"Username_or_email": "اسم المستخدم أو البريد الالكتروني",
570575
"Username_required": "اسم المستخدم مطلوب",

app/i18n/locales/bn-IN.json

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -143,6 +143,7 @@
143143
"Condensed": "সংকোচিত",
144144
"conference_call": "কনফারেন্স কল",
145145
"Confirm": "কনফার্ম",
146+
"Confirm_password": "পাসওয়ার্ড নিশ্চিত করুন",
146147
"Confirm_Password": "পাসওয়ার্ড নিশ্চিত করুন",
147148
"Confirmation": "নিশ্চিতকরণ",
148149
"Connect": "সংযোগ করুন",
@@ -301,6 +302,8 @@
301302
"Favorite": "প্রিয়",
302303
"Favorites": "প্রিয়সমূহ",
303304
"Fetch_image_from_URL": "URL থেকে ছবি আনুন",
305+
"Field_are_required": "{{field}} প্রয়োজনীয়।",
306+
"Field_is_required": "{{field}} প্রয়োজনীয়",
304307
"File_description": "ফাইল বর্ণনা",
305308
"Files": "ফাইলসমূহ",
306309
"FileUpload_Error": "ফাইল আপলোড ত্রুটি",
@@ -550,6 +553,7 @@
550553
"Password": "পাসওয়ার্ড",
551554
"Password_Tip_Error": "শর্ত পূরণ হয়নি।",
552555
"Password_Tip_Success": "শর্ত পূরণ হয়েছে।",
556+
"Passwords_do_not_match": "পাসওয়ার্ডগুলি মেলে না।",
553557
"Pause": "থামা",
554558
"Permalink_copied_to_clipboard": "পারমালিঙ্ক ক্লিপবোর্ডে কপি করা হয়েছে!",
555559
"Person_or_channel": "ব্যক্তি বা চ্যানেল",
@@ -815,6 +819,7 @@
815819
"User_left_this_channel": "চ্যানেল ছেড়ে দিয়েছে",
816820
"User_sent_an_attachment": "{{user}} একটি সংযুক্তি পাঠিয়েছে",
817821
"Username": "ব্যবহারকারীর নাম",
822+
"Username_is_already_in_use": "ব্যবহারকারীর নাম ইতিমধ্যে ব্যবহৃত হচ্ছে।",
818823
"Username_not_available": "ব্যবহারকারীর নাম পাওয়া যাচ্ছে না",
819824
"Username_or_email": "ব্যবহারকারীর নাম বা ইমেল",
820825
"Username_required": "ইউজারনেম প্রয়োজন",

app/i18n/locales/cs.json

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -152,6 +152,7 @@
152152
"Condensed": "Zhuštěný",
153153
"conference_call": "Konferenční hovor",
154154
"Confirm": "Potvrdit",
155+
"Confirm_password": "Potvrdit heslo",
155156
"Confirm_Password": "Potvrďte heslo",
156157
"Confirmation": "Potvrzení",
157158
"Connect": "Připojit",
@@ -320,6 +321,8 @@
320321
"Favorite": "Oblíbený",
321322
"Favorites": "Oblíbené",
322323
"Fetch_image_from_URL": "Načíst obrázek z URL",
324+
"Field_are_required": "{{field}} jsou povinné.",
325+
"Field_is_required": "{{field}} je povinný.",
323326
"File_description": "Popis souboru",
324327
"Files": "Soubory",
325328
"FileUpload_Error": "Chyba nahrávání souboru",
@@ -588,6 +591,7 @@
588591
"Password": "Heslo",
589592
"Password_Tip_Error": "Podmínka nesplněna.",
590593
"Password_Tip_Success": "Podmínka splněna.",
594+
"Passwords_do_not_match": "Hesla se neshodují",
591595
"Pause": "Pauza",
592596
"Permalink_copied_to_clipboard": "Trvalý odkaz zkopírován do schránky!",
593597
"Person_or_channel": "Osoba nebo kanál",
@@ -883,6 +887,7 @@
883887
"User_not_found_or": "Uživatel nenalezen nebo nesprávné heslo",
884888
"User_sent_an_attachment": "{{user}} poslal přílohu",
885889
"Username": "Uživatelské jméno",
890+
"Username_is_already_in_use": "Uživatelské jméno je již používáno.",
886891
"Username_not_available": "Uživatelské jméno není k dispozici.",
887892
"Username_or_email": "Uživatelské jméno nebo email",
888893
"Username_required": "Je vyžadováno uživatelské jméno.",

app/i18n/locales/de.json

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -137,6 +137,7 @@
137137
"Collaborative": "Kollaborativ",
138138
"Condensed": "Komprimiert",
139139
"Confirm": "Bestätigen",
140+
"Confirm_password": "Passwort bestätigen",
140141
"Confirm_Password": "Passwort bestätigen",
141142
"Confirmation": "Bestätigung",
142143
"Connect": "Verbinden",
@@ -295,6 +296,8 @@
295296
"Favorite": "Lieblings-",
296297
"Favorites": "Favoriten",
297298
"Fetch_image_from_URL": "Bild von URL abrufen",
299+
"Field_are_required": "{{field}} sind erforderlich",
300+
"Field_is_required": "{{field}} ist erforderlich",
298301
"File_description": "Dateibeschreibung",
299302
"Files": "Dateien",
300303
"FileUpload_Error": "Fehler bei Datei-Upload",
@@ -539,6 +542,7 @@
539542
"Password": "Passwort",
540543
"Password_Tip_Error": "Bedingung nicht erfüllt.",
541544
"Password_Tip_Success": "Bedingung erfüllt.",
545+
"Passwords_do_not_match": "Passwörter stimmen nicht überein",
542546
"Pause": "Pause",
543547
"Permalink_copied_to_clipboard": "Permalink in die Zwischenablage kopiert!",
544548
"Phone": "Telefon",
@@ -809,6 +813,7 @@
809813
"User_left_this_channel": "hat den Kanal verlassen",
810814
"User_sent_an_attachment": "{{user}}: eine Datei gesendet",
811815
"Username": "Benutzername",
816+
"Username_is_already_in_use": "Der Benutzername ist bereits vergeben.",
812817
"Username_not_available": "Benutzername nicht verfügbar",
813818
"Username_or_email": "Benutzername oder E-Mail-Adresse",
814819
"Username_required": "Benutzername erforderlich",

app/i18n/locales/en.json

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -154,6 +154,7 @@
154154
"Condensed": "Condensed",
155155
"conference_call": "Conference call",
156156
"Confirm": "Confirm",
157+
"Confirm_password": "Confirm password",
157158
"Confirm_Password": "Confirm Password",
158159
"Confirm_your_password": "Confirm your password",
159160
"Confirmation": "Confirmation",
@@ -279,7 +280,6 @@
279280
"Edit_Invite": "Edit invite",
280281
"Edit_Room_Photo": "Edit room photo",
281282
"Edit_Status": "Edit status",
282-
"email": "Email",
283283
"Email": "Email",
284284
"Email_associated_with_another_user": "Email associated with another user",
285285
"Email_must_be_a_valid_email": "Email must be a valid email",
@@ -341,6 +341,8 @@
341341
"Favorite": "Favorite",
342342
"Favorites": "Favorites",
343343
"Fetch_image_from_URL": "Fetch image from URL",
344+
"Field_are_required": "{{field}} are required",
345+
"Field_is_required": "{{field}} is required",
344346
"File_description": "File description",
345347
"Files": "Files",
346348
"FileUpload_Error": "File upload error",
@@ -611,6 +613,7 @@
611613
"Password": "Password",
612614
"Password_Tip_Error": "Condition not met.",
613615
"Password_Tip_Success": "Condition met.",
616+
"Passwords_do_not_match": "Passwords do not match",
614617
"Pause": "Pause",
615618
"Permalink_copied_to_clipboard": "Permalink copied to clipboard!",
616619
"Person_or_channel": "Person or channel",
@@ -913,6 +916,7 @@
913916
"User_not_found_or": "User not found or incorrect password",
914917
"User_sent_an_attachment": "{{user}} sent an attachment",
915918
"Username": "Username",
919+
"Username_is_already_in_use": "Username is already in use.",
916920
"Username_not_available": "Username not available",
917921
"Username_or_email": "Username or email",
918922
"Username_required": "Username required",

app/i18n/locales/es.json

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -76,6 +76,7 @@
7676
"Code_required": "Código requerido",
7777
"Collaborative": "Colaborativo",
7878
"Confirm": "Confirmar",
79+
"Confirm_password": "Confirmar contraseña",
7980
"Confirm_Password": "confirmar Contraseña",
8081
"Connect": "Conectar",
8182
"Connect_to_server_as_user": "Conéctate a {{serverUrl}} como {{user}}",
@@ -148,6 +149,8 @@
148149
"Favorite": "Favorito",
149150
"Favorites": "Favoritos",
150151
"Fetch_image_from_URL": "Obtener imagen desde URL",
152+
"Field_are_required": "{{field}} son obligatorios",
153+
"Field_is_required": "{{field}} es obligatorio",
151154
"File_description": "Descripción del archivo",
152155
"Files": "Archivos",
153156
"Filter": "Filtro",
@@ -255,6 +258,7 @@
255258
"Password": "Contraseña",
256259
"Password_Tip_Error": "Condición no cumplida.",
257260
"Password_Tip_Success": "Condición cumplida.",
261+
"Passwords_do_not_match": "Las contraseñas no coinciden.",
258262
"Pause": "Pausa",
259263
"Permalink_copied_to_clipboard": "¡Enlace permanente copiado al portapapeles!",
260264
"Pin": "Fijar",
@@ -398,6 +402,7 @@
398402
"User_has_been_key": "El usuario ha sido {{key}}",
399403
"User_sent_an_attachment": "{{user}} envío un adjunto",
400404
"Username": "Nombre de usuario",
405+
"Username_is_already_in_use": "El nombre de usuario ya está en uso.",
401406
"Username_not_available": "Nombre de usuario no disponible",
402407
"Username_or_email": "Nombre de usuario o email",
403408
"Username_required": "Nombre de usuario requerido",

app/i18n/locales/fi.json

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -127,6 +127,7 @@
127127
"Collaborative": "Yhteistyö",
128128
"Condensed": "Tiivistetty",
129129
"Confirm": "Vahvista",
130+
"Confirm_password": "Vahvista salasana",
130131
"Confirm_Password": "Vahvista salasana",
131132
"Confirmation": "Vahvistus",
132133
"Connect": "Yhdistä",
@@ -280,6 +281,8 @@
280281
"Favorite": "Suosikki",
281282
"Favorites": "Suosikit",
282283
"Fetch_image_from_URL": "Hae kuva URL-osoitteesta",
284+
"Field_are_required": "{{field}} ovat pakollisia.",
285+
"Field_is_required": "{{field}} on pakollinen",
283286
"File_description": "Tiedoston kuvaus",
284287
"Files": "Tiedostot",
285288
"FileUpload_Error": "Tiedoston latausvirhe",
@@ -516,6 +519,7 @@
516519
"Password": "Salasana",
517520
"Password_Tip_Error": "Ehto ei täyty.",
518521
"Password_Tip_Success": "Ehto täytetty.",
522+
"Passwords_do_not_match": "Salasanat eivät täsmää",
519523
"Pause": "Tauko",
520524
"Permalink_copied_to_clipboard": "Pysyvä linkki kopioitu leikepöydälle!",
521525
"Phone": "Puhelin",
@@ -783,6 +787,7 @@
783787
"User_left_this_channel": "poistui kanavalta",
784788
"User_sent_an_attachment": "{{user}} lähetti liitteen",
785789
"Username": "Käyttäjätunnus",
790+
"Username_is_already_in_use": "Käyttäjänimi on jo käytössä.",
786791
"Username_not_available": "Käyttäjänimi ei ole saatavilla",
787792
"Username_or_email": "Sähköpostiosoite tai käyttäjätunnus",
788793
"Username_required": "Käyttäjänimi vaaditaan",

app/i18n/locales/fr.json

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -105,6 +105,7 @@
105105
"Collaborative": "Collaboratif",
106106
"Condensed": "Condensé",
107107
"Confirm": "Confirmer",
108+
"Confirm_password": "Confirmer le mot de passe",
108109
"Confirm_Password": "Confirmez le mot de passe",
109110
"Confirmation": "Confirmation",
110111
"Connect": "Connecter",
@@ -246,6 +247,8 @@
246247
"Favorite": "Favori",
247248
"Favorites": "Favoris",
248249
"Fetch_image_from_URL": "Récupérer l'image depuis l'URL",
250+
"Field_are_required": "Les {{field}} sont requis.",
251+
"Field_is_required": "Le champ {{field}} est requis.",
249252
"File_description": "Description du fichier",
250253
"Files": "Fichiers",
251254
"Filter": "Filtrer",
@@ -476,6 +479,7 @@
476479
"Password": "Mot de passe",
477480
"Password_Tip_Error": "Condition non remplie.",
478481
"Password_Tip_Success": "Condition remplie.",
482+
"Passwords_do_not_match": "Les mots de passe ne correspondent pas.",
479483
"Pause": "Pause",
480484
"Permalink_copied_to_clipboard": "Lien permanent copié dans le presse-papiers !",
481485
"Phone": "Téléphone",
@@ -705,6 +709,7 @@
705709
"User_Info": "Info d'utilisateur",
706710
"User_sent_an_attachment": "{{user}} a envoyé une pièce jointe",
707711
"Username": "Nom d'utilisateur",
712+
"Username_is_already_in_use": "Nom d'utilisateur déjà utilisé.",
708713
"Username_not_available": "Nom d'utilisateur non disponible",
709714
"Username_or_email": "Nom d'utilisateur ou e-mail",
710715
"Username_required": "Nom d'utilisateur requis",

app/i18n/locales/hi-IN.json

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -143,6 +143,7 @@
143143
"Condensed": "संक्षेपित",
144144
"conference_call": "कॉन्फ़्रेंस कॉल",
145145
"Confirm": "पुष्टि करें",
146+
"Confirm_password": "पासवर्ड की पुष्टि करें",
146147
"Confirm_Password": "पासवर्ड की पुष्टि कीजिये",
147148
"Confirmation": "पुष्टि",
148149
"Connect": "कनेक्ट करें",
@@ -301,6 +302,8 @@
301302
"Favorite": "पसंदीदा",
302303
"Favorites": "पसंदीदा",
303304
"Fetch_image_from_URL": "URL से छवि प्राप्त करें",
305+
"Field_are_required": "{{field}} आवश्यक हैं।",
306+
"Field_is_required": "{{field}} आवश्यक है।",
304307
"File_description": "फ़ाइल विवरण",
305308
"Files": "फ़ाइलें",
306309
"FileUpload_Error": "फ़ाइल अपलोड त्रुटि",
@@ -550,6 +553,7 @@
550553
"Password": "पासवर्ड",
551554
"Password_Tip_Error": "शर्त पूरी नहीं हुई।",
552555
"Password_Tip_Success": "शर्त पूरी हुई।",
556+
"Passwords_do_not_match": "पासवर्ड मेल नहीं खाते हैं।",
553557
"Pause": "विराम",
554558
"Permalink_copied_to_clipboard": "पर्मालिंक क्लिपबोर्ड पर कॉपी किया गया!",
555559
"Person_or_channel": "व्यक्ति या चैनल",
@@ -815,6 +819,7 @@
815819
"User_left_this_channel": "चैनल छोड़ गया",
816820
"User_sent_an_attachment": "{{user}} ने एक अटैचमेंट भेजा",
817821
"Username": "उपयोगकर्ता नाम",
822+
"Username_is_already_in_use": "उपयोगकर्ता नाम पहले से ही उपयोग में है।",
818823
"Username_not_available": "उपयोगकर्ता नाम उपलब्ध नहीं है।",
819824
"Username_or_email": "उपयोगकर्ता नाम या ईमेल",
820825
"Username_required": "उपयोगकर्ता नाम आवश्यक है।",

0 commit comments

Comments
 (0)