Skip to content

Commit 950347d

Browse files
diegolmellodiegolmello
authored
fix(security): Stop saving cookies on AuthenticationWebView (#6578)
1 parent c0134e5 commit 950347d

File tree

32 files changed

+12
-148
lines changed

32 files changed

+12
-148
lines changed

‎app/actions/login.ts‎

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@ interface ICredentials {
1212
interface ILoginRequest extends Action {
1313
credentials: any;
1414
logoutOnError?: boolean;
15-
isFromWebView?: boolean;
1615
registerCustomFields?: any;
1716
}
1817

@@ -57,14 +56,12 @@ export type TActionsLogin = ILoginRequest &
5756
export function loginRequest(
5857
credentials: Partial<ICredentials>,
5958
logoutOnError?: boolean,
60-
isFromWebView?: boolean,
6159
registerCustomFields?: any
6260
): ILoginRequest {
6361
return {
6462
type: types.LOGIN.REQUEST,
6563
credentials,
6664
logoutOnError,
67-
isFromWebView,
6865
registerCustomFields
6966
};
7067
}

‎app/definitions/ILoggedUser.ts‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@ export interface ILoggedUser {
1919
roles?: string[];
2020
avatarETag?: string;
2121
showMessageInMainThread?: boolean;
22-
isFromWebView?: boolean;
2322
enableMessageParserEarlyAdoption: boolean;
2423
alsoSendThreadToChannel: 'default' | 'always' | 'never';
2524
bio?: string;

‎app/i18n/locales/ar.json‎

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -84,10 +84,6 @@
8484
"Clear": "مسح",
8585
"Clear_cache": "امسح ذاكرة التخزين المؤقتة للخادم",
8686
"Clear_cache_loading": "يتم مسح ذاكرة التخزين",
87-
"Clear_cookies_alert": "هل تريد حذف جميع ملفات تعريف الإرتباط؟",
88-
"Clear_cookies_desc": "هذا الإجراء سيحذف ملفات تعريف الإرتباط الخاصة بتسجيل الدخول مما يسمح بتسجيل الدخول لحسابات أخرى",
89-
"Clear_cookies_no": "لا، احتفظ بملفات تعريف الإرتباط",
90-
"Clear_cookies_yes": "نعم، مسح ملفات الإرتباط",
9187
"Click_to_join": "انقر للانضمام!",
9288
"Close": "إغلاق",
9389
"Code_or_password_invalid": "الرمز أو كلمة المرور خاطئة",

‎app/i18n/locales/bn-IN.json‎

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -132,10 +132,6 @@
132132
"Clear": "পরিষ্কার",
133133
"Clear_cache": "লোকাল কাজকর্ম ক্যাশ মুছুন",
134134
"Clear_cache_loading": "ক্যাশ মোছা হচ্ছে।",
135-
"Clear_cookies_alert": "আপনি সব কুকি মুছতে চান?",
136-
"Clear_cookies_desc": "এই অ্যাকশনটি সমস্ত লগইন কুকিগুলি মুছে ফেলবে, যা আপনাকে অন্য অ্যাকাউন্টে লগইন করতে অনুমতি দেবে।",
137-
"Clear_cookies_no": "না, কুকি রাখুন",
138-
"Clear_cookies_yes": "হ্যাঁ, কুকি মুছুন",
139135
"Click_to_join": "যোগ দিতে ক্লিক করুন!",
140136
"Close": "বন্ধ করুন",
141137
"Close_Chat": "চ্যাট বন্ধ করুন",

‎app/i18n/locales/cs.json‎

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -139,10 +139,6 @@
139139
"Clear": "Průhledná",
140140
"Clear_cache": "Vymazat místní mezipaměť pracovního prostoru",
141141
"Clear_cache_loading": "Vymazání mezipaměti.",
142-
"Clear_cookies_alert": "Chcete vymazat všechny soubory cookie?",
143-
"Clear_cookies_desc": "Tato akce vymaže všechny přihlašovací soubory cookie, což vám umožní přihlásit se k jiným účtům.",
144-
"Clear_cookies_no": "Ne, ponechat si cookies",
145-
"Clear_cookies_yes": "Ano, vymazat soubory cookie",
146142
"Click_to_join": "Kliknutím se připojte!",
147143
"Close": "Zavřít",
148144
"Close_Chat": "Zavřít chat",

‎app/i18n/locales/de.json‎

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -127,10 +127,6 @@
127127
"Clear": "Löschen",
128128
"Clear_cache": "Lokalen Server-Cache leeren",
129129
"Clear_cache_loading": "Leere Cache.",
130-
"Clear_cookies_alert": "Möchten Sie alle Cookies löschen?",
131-
"Clear_cookies_desc": "Diese Aktion wird alle Login-Cookies löschen und erlaubt es Ihnen, sich mit einem anderen Konto anzumelden.",
132-
"Clear_cookies_no": "Nein, Cookies behalten",
133-
"Clear_cookies_yes": "Ja, Cookies löschen",
134130
"Click_to_join": "Klicken um beizutreten!",
135131
"Close": "Schließen",
136132
"Close_Chat": "Chat schließen",

‎app/i18n/locales/en.json‎

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -141,10 +141,6 @@
141141
"Clear": "Clear",
142142
"Clear_cache": "Clear local workspace cache",
143143
"Clear_cache_loading": "Clearing cache.",
144-
"Clear_cookies_alert": "Do you want to clear all cookies?",
145-
"Clear_cookies_desc": "This action will clear all login cookies, allowing you to login into other accounts.",
146-
"Clear_cookies_no": "No, keep cookies",
147-
"Clear_cookies_yes": "Yes, clear cookies",
148144
"Click_to_join": "Click to join!",
149145
"Close": "Close",
150146
"Close_Chat": "Close chat",

‎app/i18n/locales/fi.json‎

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -117,10 +117,6 @@
117117
"Clear": "Tyhjennä",
118118
"Clear_cache": "Tyhjennä paikallisen palvelimen välimuisti",
119119
"Clear_cache_loading": "Tyhjennetään välimuistia.",
120-
"Clear_cookies_alert": "Haluatko tyhjentää kaikki evästeet?",
121-
"Clear_cookies_desc": "Tämä toiminto tyhjentää kaikki kirjautumisevästeet, joten voit kirjautua muille tileille.",
122-
"Clear_cookies_no": "Ei, säilytä evästeet",
123-
"Clear_cookies_yes": "Kyllä, tyhjennä evästeet",
124120
"Click_to_join": "Liity napsauttamalla!",
125121
"Close": "Sulje",
126122
"Close_Chat": "Sulje keskustelu",

‎app/i18n/locales/fr.json‎

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -96,10 +96,6 @@
9696
"Clear": "Effacer",
9797
"Clear_cache": "Effacer le cache du serveur local",
9898
"Clear_cache_loading": "Effacement du cache.",
99-
"Clear_cookies_alert": "Voulez-vous effacer tous les cookies ?",
100-
"Clear_cookies_desc": "Cette action effacera tous les cookies de connexion ce qui vous permettra de vous connecter à d'autres comptes.",
101-
"Clear_cookies_no": "Non, gardez les cookies",
102-
"Clear_cookies_yes": "Oui, effacez les cookies",
10399
"Click_to_join": "Cliquez pour rejoindre !",
104100
"Close": "Fermer",
105101
"Code_or_password_invalid": "Code ou mot de passe invalide",

‎app/i18n/locales/hi-IN.json‎

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -132,10 +132,6 @@
132132
"Clear": "स्पष्ट",
133133
"Clear_cache": "स्थानीय कार्यस्थान कैश साफ करें",
134134
"Clear_cache_loading": "कैश साफ हो रहा है।",
135-
"Clear_cookies_alert": "क्या आप सभी कुकीज़ को हटाना चाहते हैं?",
136-
"Clear_cookies_desc": "यह क्रिया सभी लॉगिन कुकीज़ को हटा देगी, जिससे आप अन्य खातों में लॉगिन कर सकते हैं।",
137-
"Clear_cookies_no": "नहीं, कुकीज़ रखें",
138-
"Clear_cookies_yes": "हाँ, कुकीज़ साफ करें",
139135
"Click_to_join": "शामिल होने के लिए क्लिक करें!",
140136
"Close": "बंद करें",
141137
"Close_Chat": "चैट बंद करें",

0 commit comments

Comments
 (0)