chore: Enforce consistent type imports (#6727)

Author: diegolmello

.eslintrc.js

@@ -11,6 +11,17 @@ module.exports = {
 		},
 		'import/parsers': {
 			'@typescript-eslint/parser': ['.ts', '.tsx']
+			// plugins: ['@typescript-eslint'],
+			// rules: {
+			// 	'@typescript-eslint/consistent-type-imports': [
+			// 		'error',
+			// 		{
+			// 			prefer: 'type-imports', // enforce `import type`
+			// 			disallowTypeAnnotations: true // disallow `import { type Foo }`
+			// 			// fixStyle: 'inline-type-imports' // keeps type imports inline rather than grouped
+			// 		}
+			// 	]
+			// }
 		}
 	},
 	parser: '@babel/eslint-parser',
@@ -219,6 +230,14 @@ module.exports = {
 						ignoreRestSiblings: true
 					}
 				],
+				'@typescript-eslint/consistent-type-imports': [
+					'error',
+					{
+						prefer: 'type-imports',
+						disallowTypeAnnotations: true,
+						fixStyle: 'inline-type-imports'
+					}
+				],
 				'new-cap': 'off',
 				'lines-between-class-members': 'off',
 				'react-hooks/rules-of-hooks': 'error',

app/AppContainer.tsx

@@ -3,7 +3,7 @@ import { NavigationContainer } from '@react-navigation/native';
 import { createNativeStackNavigator } from '@react-navigation/native-stack';
 import { connect } from 'react-redux';
 
-import { SetUsernameStackParamList, StackParamList } from './definitions/navigationTypes';
+import type { SetUsernameStackParamList, StackParamList } from './definitions/navigationTypes';
 import Navigation from './lib/navigation/appNavigation';
 import { defaultHeader, getActiveRouteName, navigationTheme } from './lib/methods/helpers/navigation';
 import { RootEnum } from './definitions';

app/actions/activeUsers.ts

@@ -1,6 +1,6 @@
-import { Action } from 'redux';
+import { type Action } from 'redux';
 
-import { IActiveUsers } from '../reducers/activeUsers';
+import { type IActiveUsers } from '../reducers/activeUsers';
 import { ACTIVE_USERS } from './actionsTypes';
 
 interface ISetActiveUsers extends Action {

app/actions/app.ts

@@ -1,7 +1,7 @@
-import { Action } from 'redux';
-import { NetInfoStateType } from '@react-native-community/netinfo';
+import { type Action } from 'redux';
+import { type NetInfoStateType } from '@react-native-community/netinfo';
 
-import { RootEnum } from '../definitions';
+import { type RootEnum } from '../definitions';
 import { APP } from './actionsTypes';
 
 interface IAppStart extends Action {

app/actions/connect.ts

@@ -1,4 +1,4 @@
-import { Action } from 'redux';
+import { type Action } from 'redux';
 
 import * as types from './actionsTypes';
 

app/actions/createChannel.ts

@@ -1,6 +1,6 @@
-import { Action } from 'redux';
+import { type Action } from 'redux';
 
-import { TCreateChannelResult } from '../reducers/createChannel';
+import { type TCreateChannelResult } from '../reducers/createChannel';
 import { CREATE_CHANNEL } from './actionsTypes';
 
 interface ICreateChannelRequest extends Action {

app/actions/createDiscussion.ts

@@ -1,4 +1,4 @@
-import { Action } from 'redux';
+import { type Action } from 'redux';
 
 import { CREATE_DISCUSSION } from './actionsTypes';
 

app/actions/customEmojis.ts

@@ -1,7 +1,7 @@
-import { Action } from 'redux';
+import { type Action } from 'redux';
 
 import { SET_CUSTOM_EMOJIS } from './actionsTypes';
-import { ICustomEmojis } from '../definitions';
+import { type ICustomEmojis } from '../definitions';
 
 export interface ISetCustomEmojis extends Action {
 	emojis: ICustomEmojis;

app/actions/deepLinking.ts

@@ -1,4 +1,4 @@
-import { Action } from 'redux';
+import { type Action } from 'redux';
 
 import { DEEP_LINKING } from './actionsTypes';
 

app/actions/encryption.ts

@@ -1,6 +1,6 @@
-import { Action } from 'redux';
+import { type Action } from 'redux';
 
-import { IBanner } from '../reducers/encryption';
+import { type IBanner } from '../reducers/encryption';
 import { ENCRYPTION } from './actionsTypes';
 
 export interface IEncryptionSet extends Action {