Skip to content

Commit fc73bf3

Browse files
authored
fix: show correct toast message on star and unstar (#6658)
1 parent c927193 commit fc73bf3

File tree

1 file changed

+6
-5
lines changed

1 file changed

+6
-5
lines changed

app/containers/MessageActions/index.tsx

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -291,11 +291,12 @@ const MessageActions = React.memo(
291291
}
292292
};
293293

294-
const handleStar = async (message: TAnyMessageModel) => {
295-
logEvent(message.starred ? events.ROOM_MSG_ACTION_UNSTAR : events.ROOM_MSG_ACTION_STAR);
294+
const handleStar = async (messageId: string, starred: boolean) => {
295+
logEvent(starred ? events.ROOM_MSG_ACTION_UNSTAR : events.ROOM_MSG_ACTION_STAR);
296296
try {
297-
await Services.toggleStarMessage(message.id, message.starred as boolean); // TODO: reevaluate `message.starred` type on IMessage
298-
EventEmitter.emit(LISTENER, { message: message.starred ? I18n.t('Message_unstarred') : I18n.t('Message_starred') });
297+
await Services.toggleStarMessage(messageId, starred);
298+
299+
EventEmitter.emit(LISTENER, { message: starred ? I18n.t('Message_unstarred') : I18n.t('Message_starred') });
299300
} catch (e) {
300301
logEvent(events.ROOM_MSG_ACTION_STAR_F);
301302
log(e);
@@ -485,7 +486,7 @@ const MessageActions = React.memo(
485486
options.push({
486487
title: I18n.t(message.starred ? 'Unstar' : 'Star'),
487488
icon: message.starred ? 'star-filled' : 'star',
488-
onPress: () => handleStar(message)
489+
onPress: () => handleStar(message.id, message.starred || false)
489490
});
490491
}
491492

0 commit comments

Comments
 (0)