chore(settings): Move settings client API (#36844)

Author: tassoevan

apps/meteor/app/autotranslate/client/lib/autotranslate.ts

@@ -11,13 +11,13 @@ import mem from 'mem';
 import { Meteor } from 'meteor/meteor';
 import { Tracker } from 'meteor/tracker';
 
+import { settings } from '../../../../client/lib/settings';
 import { Messages, Subscriptions } from '../../../../client/stores';
 import {
 	hasTranslationLanguageInAttachments,
 	hasTranslationLanguageInMessage,
 } from '../../../../client/views/room/MessageList/lib/autoTranslate';
 import { hasPermission } from '../../../authorization/client';
-import { settings } from '../../../settings/client';
 import { sdk } from '../../../utils/client/lib/SDKClient';
 
 let userLanguage = 'en';
@@ -103,7 +103,7 @@ export const AutoTranslate = {
 
 		Tracker.autorun(async (c) => {
 			const uid = Meteor.userId();
-			if (!settings.get('AutoTranslate_Enabled') || !uid || !hasPermission('auto-translate')) {
+			if (!settings.watch('AutoTranslate_Enabled') || !uid || !hasPermission('auto-translate')) {
 				return;
 			}
 

apps/meteor/app/lib/client/OAuthProxy.ts

@@ -1,18 +1,18 @@
 import { OAuth } from 'meteor/oauth';
 
-import { settings } from '../../settings/client';
+import { settings } from '../../../client/lib/settings';
 
 OAuth.launchLogin = ((func) =>
 	function (options) {
-		const proxy = settings.get('Accounts_OAuth_Proxy_services').replace(/\s/g, '').split(',');
+		const proxy = settings.peek('Accounts_OAuth_Proxy_services').replace(/\s/g, '').split(',');
 		if (proxy.includes(options.loginService)) {
 			const redirectUri = options.loginUrl.match(/(&redirect_uri=)([^&]+|$)/)?.[2];
 			options.loginUrl = options.loginUrl.replace(
 				/(&redirect_uri=)([^&]+|$)/,
-				`$1${encodeURIComponent(settings.get('Accounts_OAuth_Proxy_host'))}/oauth_redirect`,
+				`$1${encodeURIComponent(settings.peek('Accounts_OAuth_Proxy_host') ?? '')}/oauth_redirect`,
 			);
 			options.loginUrl = options.loginUrl.replace(/(&state=)([^&]+|$)/, `$1${redirectUri}!$2`);
-			options.loginUrl = `${settings.get('Accounts_OAuth_Proxy_host')}/redirect/${encodeURIComponent(options.loginUrl)}`;
+			options.loginUrl = `${settings.peek('Accounts_OAuth_Proxy_host')}/redirect/${encodeURIComponent(options.loginUrl)}`;
 		}
 
 		return func(options);

apps/meteor/app/lib/client/methods/sendMessage.ts

@@ -3,11 +3,11 @@ import type { ServerMethods } from '@rocket.chat/ddp-client';
 import { Meteor } from 'meteor/meteor';
 
 import { onClientMessageReceived } from '../../../../client/lib/onClientMessageReceived';
+import { settings } from '../../../../client/lib/settings';
 import { dispatchToastMessage } from '../../../../client/lib/toast';
 import { Messages, Rooms } from '../../../../client/stores';
 import { callbacks } from '../../../../lib/callbacks';
 import { trim } from '../../../../lib/utils/stringUtils';
-import { settings } from '../../../settings/client';
 import { t } from '../../../utils/lib/i18n';
 
 Meteor.methods<ServerMethods>({
@@ -31,7 +31,7 @@ Meteor.methods<ServerMethods>({
 			name: user.name || '',
 		};
 		message.temp = true;
-		if (settings.get('Message_Read_Receipt_Enabled')) {
+		if (settings.peek('Message_Read_Receipt_Enabled')) {
 			message.unread = true;
 		}
 

apps/meteor/app/livechat/client/lib/stream/queueManager.ts

@@ -3,9 +3,9 @@ import type { ILivechatDepartment, ILivechatInquiryRecord, IOmnichannelAgent, Se
 import { useLivechatInquiryStore } from '../../../../../client/hooks/useLivechatInquiryStore';
 import { queryClient } from '../../../../../client/lib/queryClient';
 import { roomsQueryKeys } from '../../../../../client/lib/queryKeys';
+import { settings } from '../../../../../client/lib/settings';
 import { callWithErrorHandling } from '../../../../../client/lib/utils/callWithErrorHandling';
 import { mapMessageFromApi } from '../../../../../client/lib/utils/mapMessageFromApi';
-import { settings } from '../../../../settings/client';
 import { sdk } from '../../../../utils/client/lib/SDKClient';
 
 const departments = new Set();
@@ -58,7 +58,7 @@ const removeInquiry = async (inquiry: ILivechatInquiryRecord) => {
 };
 
 const getInquiriesFromAPI = async () => {
-	const count = settings.get('Livechat_guest_pool_max_number_incoming_livechats_displayed') ?? 0;
+	const count = settings.peek('Livechat_guest_pool_max_number_incoming_livechats_displayed') ?? 0;
 	const { inquiries } = await sdk.rest.get('/v1/livechat/inquiries.queuedForUser', { count });
 	return inquiries;
 };

apps/meteor/app/settings/client/index.ts

@@ -1,7 +1,7 @@
-import { settings } from '../../settings/client';
+import { settings } from '../../../client/lib/settings';
 import { slashCommands } from '../../utils/client/slashCommand';
 
-settings.onload('SlackBridge_Enabled', (_key, value) => {
+settings.observe('SlackBridge_Enabled', (_key, value) => {
 	if (value) {
 		slashCommands.add({
 			command: 'slackbridge-import',

apps/meteor/app/settings/client/lib/settings.ts

@@ -5,7 +5,7 @@ import { flushSync } from 'react-dom';
 
 import AddLinkComposerActionModal from './AddLinkComposerActionModal';
 import type { ComposerAPI } from '../../../../client/lib/chats/ChatAPI';
-import { settings } from '../../../settings/client';
+import { settings } from '../../../../client/lib/settings';
 
 type FormattingButtonDefault = { label: TranslationKey; condition?: () => boolean };
 
@@ -90,17 +90,17 @@ export const formattingButtons: ReadonlyArray<FormattingButton> = [
 		label: 'KaTeX' as TranslationKey,
 		icon: 'katex',
 		text: () => {
-			if (!settings.get('Katex_Enabled')) {
+			if (!settings.peek('Katex_Enabled')) {
 				return;
 			}
-			if (settings.get('Katex_Dollar_Syntax')) {
+			if (settings.peek('Katex_Dollar_Syntax')) {
 				return '$$KaTeX$$';
 			}
-			if (settings.get('Katex_Parenthesis_Syntax')) {
+			if (settings.peek('Katex_Parenthesis_Syntax')) {
 				return '\\[KaTeX\\]';
 			}
 		},
 		link: 'https://khan.github.io/KaTeX/function-support.html',
-		condition: () => settings.get('Katex_Enabled'),
+		condition: () => settings.watch('Katex_Enabled') ?? true,
 	},
 ] as const;

apps/meteor/app/settings/lib/settings.ts

@@ -3,8 +3,8 @@ import { Emitter } from '@rocket.chat/emitter';
 import { debounce } from 'lodash';
 import { Meteor } from 'meteor/meteor';
 
+import { settings } from '../../../../client/lib/settings';
 import { Users } from '../../../../client/stores';
-import { settings } from '../../../settings/client';
 import { sdk } from '../../../utils/client/lib/SDKClient';
 
 const TIMEOUT = 15000;
@@ -32,7 +32,7 @@ const shownName = function (user: IUser | null | undefined): string | undefined
 	if (!user) {
 		return;
 	}
-	if (settings.get('UI_Use_Real_Name')) {
+	if (settings.peek('UI_Use_Real_Name')) {
 		return user.name;
 	}
 	return user.username;