test: Reorg omnichannel admin page objects (#37972)

Co-authored-by: Júlia Jaeger Foresti <60678893+juliajforesti@users.noreply.github.com>

Author: dougfabris

apps/meteor/client/views/admin/customUserStatus/CustomUserStatusTable/CustomUserStatusRow.tsx

@@ -17,15 +17,7 @@ const CustomUserStatusRow = ({ status, onClick }: CustomUserStatusRowProps): Rea
 	const { t } = useTranslation();
 
 	return (
-		<GenericTableRow
-			key={_id}
-			onKeyDown={(): void => onClick(_id)}
-			onClick={(): void => onClick(_id)}
-			tabIndex={0}
-			role='link'
-			action
-			qa-user-id={_id}
-		>
+		<GenericTableRow key={_id} onKeyDown={() => onClick(_id)} onClick={() => onClick(_id)} tabIndex={0} action>
 			<GenericTableCell fontScale='p2' color='default' style={style}>
 				<MarkdownText content={name} parseEmoji={true} variant='inline' />
 			</GenericTableCell>

apps/meteor/client/views/omnichannel/agents/AgentEdit.tsx

@@ -164,13 +164,7 @@ const AgentEdit = ({ agentData, agentDepartments }: AgentEditProps) => {
 										name='status'
 										control={control}
 										render={({ field }) => (
-											<Select
-												id={statusField}
-												data-qa-id='agent-edit-status'
-												{...field}
-												options={statusOptions}
-												placeholder={t('Select_an_option')}
-											/>
+											<Select id={statusField} {...field} options={statusOptions} placeholder={t('Select_an_option')} />
 										)}
 									/>
 								</FieldRow>
@@ -185,7 +179,7 @@ const AgentEdit = ({ agentData, agentDepartments }: AgentEditProps) => {
 					<Button type='reset' disabled={!isDirty} onClick={() => reset()}>
 						{t('Reset')}
 					</Button>
-					<Button form={formId} primary type='submit' data-qa-id='agent-edit-save' disabled={!isDirty}>
+					<Button form={formId} primary type='submit' disabled={!isDirty}>
 						{t('Save')}
 					</Button>
 				</ButtonGroup>

apps/meteor/client/views/omnichannel/agents/AgentInfoAction.tsx

@@ -9,7 +9,7 @@ type AgentInfoActionProps = {
 } & Omit<HTMLAttributes<HTMLElement>, 'is'>;
 
 const AgentInfoAction = ({ icon, label, ...props }: AgentInfoActionProps) => (
-	<Button icon={icon} data-qa={`agent-info-action-${label?.toLowerCase()}`} title={label} {...props}>
+	<Button icon={icon} title={label} {...props}>
 		{label}
 	</Button>
 );

apps/meteor/client/views/omnichannel/agents/AgentsTable/AgentsTable.tsx

@@ -96,9 +96,9 @@ const AgentsTable = () => {
 			)}
 			{isSuccess && data?.users.length > 0 && (
 				<>
-					<GenericTable aria-busy={isLoading} data-qa-id='agents-table'>
+					<GenericTable aria-label={t('Agents')} aria-busy={isLoading}>
 						<GenericTableHeader>{headers}</GenericTableHeader>
-						<GenericTableBody data-qa='GenericTableAgentInfoBody'>
+						<GenericTableBody>
 							{data?.users.map((user) => <AgentsTableRow key={user._id} user={user} mediaQuery={mediaQuery} />)}
 						</GenericTableBody>
 					</GenericTable>

apps/meteor/client/views/omnichannel/agents/AgentsTable/AgentsTableRow.tsx

@@ -27,7 +27,7 @@ const AgentsTableRow = ({
 	const handleDelete = useRemoveAgent(_id);
 
 	return (
-		<GenericTableRow data-qa-id={username} action onClick={() => router.navigate(`/omnichannel/agents/info/${_id}`)}>
+		<GenericTableRow action onClick={() => router.navigate(`/omnichannel/agents/info/${_id}`)}>
 			<GenericTableCell>
 				<Box display='flex' alignItems='center'>
 					{username && <UserAvatar size={mediaQuery ? 'x28' : 'x40'} title={username} username={username} etag={avatarETag} />}

apps/meteor/client/views/omnichannel/agents/hooks/useRemoveAgent.tsx

@@ -30,15 +30,7 @@ export const useRemoveAgent = (uid: ILivechatAgent['_id']) => {
 			}
 		};
 
-		setModal(
-			<GenericModal
-				data-qa-id='remove-agent-modal'
-				variant='danger'
-				onConfirm={onDeleteAgent}
-				onCancel={() => setModal()}
-				confirmText={t('Delete')}
-			/>,
-		);
+		setModal(<GenericModal variant='danger' onConfirm={onDeleteAgent} onCancel={() => setModal()} confirmText={t('Delete')} />);
 	});
 
 	return handleDelete;

apps/meteor/client/views/omnichannel/businessHours/BusinessHoursRow.tsx

@@ -27,7 +27,7 @@ const BusinessHoursRow = ({ _id, name, timezone, workHours, active, type }: Seri
 	const openDays = useMemo(() => workHours.filter(({ open }) => !!open).map(({ day }) => day), [workHours]);
 
 	return (
-		<GenericTableRow key={_id} role='link' action tabIndex={0} onClick={handleClick} onKeyDown={handleKeyDown}>
+		<GenericTableRow key={_id} action tabIndex={0} onClick={handleClick} onKeyDown={handleKeyDown}>
 			<GenericTableCell withTruncatedText>{name || t('Default')}</GenericTableCell>
 			<GenericTableCell withTruncatedText>{t(timezone.name as TranslationKey)}</GenericTableCell>
 			<GenericTableCell withTruncatedText>{openDays.join(', ')}</GenericTableCell>

apps/meteor/client/views/omnichannel/businessHours/BusinessHoursTable.tsx

@@ -65,7 +65,7 @@ const BusinessHoursTable = () => {
 			{isSuccess && data?.businessHours.length === 0 && <GenericNoResults />}
 			{isSuccess && data?.businessHours.length > 0 && (
 				<>
-					<GenericTable>
+					<GenericTable aria-label={t('Business_Hours')}>
 						<GenericTableHeader>{headers}</GenericTableHeader>
 						<GenericTableBody>
 							{data?.businessHours.map((businessHour) => <BusinessHoursRow key={businessHour._id} {...businessHour} />)}

apps/meteor/client/views/omnichannel/cannedResponses/modals/CannedResponsesTable.tsx

@@ -152,7 +152,7 @@ const CannedResponsesTable = () => {
 						<GenericTableHeader>{headers}</GenericTableHeader>
 						<GenericTableBody>
 							{data?.cannedResponses.map(({ _id, shortcut, scope, createdBy, _createdAt, tags = [] }) => (
-								<GenericTableRow key={_id} tabIndex={0} role='link' onClick={onRowClick(_id, scope)} action qa-user-id={_id}>
+								<GenericTableRow key={_id} tabIndex={0} role='link' onClick={onRowClick(_id, scope)} action>
 									<GenericTableCell withTruncatedText>{shortcut}</GenericTableCell>
 									<GenericTableCell withTruncatedText>{defaultOptions[scope as Scope]}</GenericTableCell>
 									<GenericTableCell withTruncatedText>

apps/meteor/client/views/omnichannel/customFields/CustomFieldsPage.tsx

@@ -21,9 +21,7 @@ const CustomFieldsPage = () => {
 		<Page flexDirection='row'>
 			<Page>
 				<PageHeader title={t('Custom_Fields')}>
-					<Button data-qa-id='CustomFieldPageBtnNew' onClick={() => router.navigate('/omnichannel/customfields/new')}>
-						{t('Create_custom_field')}
-					</Button>
+					<Button onClick={() => router.navigate('/omnichannel/customfields/new')}>{t('Create_custom_field')}</Button>
 				</PageHeader>
 				<PageContent>
 					<CustomFieldsTable />