fix: executeSaveUserProfile does not trigger username stream (#36385)

Co-authored-by: Pierre Lehnen <55164754+pierre-lehnen-rc@users.noreply.github.com>

Author: ggazzo

.changeset/angry-years-learn.md

@@ -0,0 +1,5 @@
+---
+"@rocket.chat/meteor": patch
+---
+
+fixes: v1/updateOwnBasicInfo does not trigger user stream

apps/meteor/app/lib/server/functions/setUsername.ts

@@ -7,9 +7,6 @@ import { Meteor } from 'meteor/meteor';
 import type { ClientSession } from 'mongodb';
 import _ from 'underscore';
 
-import { hasPermissionAsync } from '../../../authorization/server/functions/hasPermission';
-import { settings } from '../../../settings/server';
-import { RateLimiter } from '../lib';
 import { addUserToRoom } from './addUserToRoom';
 import { checkUsernameAvailability } from './checkUsernameAvailability';
 import { getAvatarSuggestionForUser } from './getAvatarSuggestionForUser';
@@ -20,6 +17,7 @@ import { validateUsername } from './validateUsername';
 import { callbacks } from '../../../../lib/callbacks';
 import { onceTransactionCommitedSuccessfully } from '../../../../server/database/utils';
 import { SystemLogger } from '../../../../server/lib/logger/system';
+import { settings } from '../../../settings/server';
 import { notifyOnUserChange } from '../lib/notifyListener';
 
 export const setUsernameWithValidation = async (userId: string, username: string, joinDefaultChannelsSilenced?: boolean): Promise<void> => {
@@ -151,10 +149,3 @@ export const _setUsername = async function (
 
 	return user;
 };
-
-export const setUsername = RateLimiter.limitFunction(_setUsername, 1, 60000, {
-	async 0() {
-		const userId = Meteor.userId();
-		return !userId || !(await hasPermissionAsync(userId, 'edit-other-user-info'));
-	},
-});

apps/meteor/server/methods/saveUserProfile.ts

@@ -7,9 +7,11 @@ import { Match, check } from 'meteor/check';
 import { Meteor } from 'meteor/meteor';
 
 import { twoFactorRequired } from '../../app/2fa/server/twoFactorRequired';
+import { getUserInfo } from '../../app/api/server/helpers/getUserInfo';
 import { saveCustomFields } from '../../app/lib/server/functions/saveCustomFields';
 import { validateUserEditing } from '../../app/lib/server/functions/saveUser';
 import { saveUserIdentity } from '../../app/lib/server/functions/saveUserIdentity';
+import { notifyOnUserChange } from '../../app/lib/server/lib/notifyListener';
 import { passwordPolicy } from '../../app/lib/server/lib/passwordPolicy';
 import { setEmailFunction } from '../../app/lib/server/methods/setEmail';
 import { settings as rcSettings } from '../../app/settings/server';
@@ -158,6 +160,14 @@ async function saveUserProfile(
 
 	// App IPostUserUpdated event hook
 	const updatedUser = await Users.findOneById(this.userId);
+
+	// This should never happen, but since `Users.findOneById` might return null, we'll handle it just in case
+	if (!updatedUser) {
+		throw new Error('Unexpected error after saving user profile: user not found');
+	}
+
+	void notifyOnUserChange({ clientAction: 'updated', id: updatedUser._id, diff: getUserInfo(updatedUser) });
+
 	await Apps.self?.triggerEvent(AppEvents.IPostUserUpdated, { user: updatedUser, previousUser: user });
 
 	return true;