rename accept subscription model

Author: sampaiodiego

apps/meteor/app/lib/server/functions/acceptRoomInvite.ts

@@ -14,6 +14,9 @@ import { notifyOnSubscriptionChangedById } from '../lib/notifyListener';
  * safe callbacks, ensuring no propagation loops are created during external event
  * processing.
  */
+
+// TODO this funcion is pretty much the same as the one in addUserToRoom.ts, we should probably
+// unify them at some point
 export const performAcceptRoomInvite = async (
 	room: IRoom,
 	subscription: ISubscription,
@@ -38,7 +41,7 @@ export const performAcceptRoomInvite = async (
 		throw error;
 	}
 
-	await Subscriptions.markInviteAsAccepted(subscription._id);
+	await Subscriptions.acceptInvitationById(subscription._id);
 
 	void notifyOnSubscriptionChangedById(subscription._id, 'updated');
 

packages/model-typings/src/models/ISubscriptionsModel.ts

@@ -337,5 +337,5 @@ export interface ISubscriptionsModel extends IBaseModel<ISubscription> {
 	countUsersInRoles(roles: IRole['_id'][], rid: IRoom['_id'] | undefined): Promise<number>;
 	findUserFederatedRoomIds(userId: IUser['_id']): AggregationCursor<{ _id: IRoom['_id']; externalRoomId: string }>;
 	findInvitedSubscription(roomId: ISubscription['rid'], userId: ISubscription['u']['_id']): Promise<Pick<ISubscription, '_id'> | null>;
-	markInviteAsAccepted(subscriptionId: ISubscription['_id']): Promise<UpdateResult>;
+	acceptInvitationById(subscriptionId: ISubscription['_id']): Promise<UpdateResult>;
 }

packages/models/src/models/Subscriptions.ts

@@ -2101,7 +2101,7 @@ export class SubscriptionsRaw extends BaseRaw<ISubscription> implements ISubscri
 		);
 	}
 
-	async markInviteAsAccepted(subscriptionId: string): Promise<UpdateResult> {
+	async acceptInvitationById(subscriptionId: string): Promise<UpdateResult> {
 		return this.updateOne(
 			{ _id: subscriptionId },
 			{