chore: update version validation checks (#38149)

Co-authored-by: Guilherme Gazzo <guilherme@gazzo.xyz>

Author: sampaiodiego

apps/meteor/app/api/server/ApiClass.ts

@@ -57,7 +57,7 @@ const logger = new Logger('API');
 // We have some breaking changes planned to the API.
 // To avoid conflicts or missing something during the period we are adopting a 'feature flag approach'
 // TODO: MAJOR check if this is still needed
-const applyBreakingChanges = shouldBreakInVersion('8.0.0');
+const applyBreakingChanges = shouldBreakInVersion('9.0.0');
 type MinimalRoute = {
 	method: 'GET' | 'POST' | 'PUT' | 'DELETE';
 	path: string;

apps/meteor/app/lib/server/functions/saveUser/saveUser.ts

@@ -235,16 +235,15 @@ const _saveUser = (session?: ClientSession) =>
 		return true;
 	};
 
-const isBroken = shouldBreakInVersion('8.0.0');
+const isBroken = shouldBreakInVersion('9.0.0');
 export const saveUser = (() => {
-	if (isBroken) {
-		throw new Error('DEBUG_DISABLE_USER_AUDIT flag is deprecated and should be removed');
-	}
-
 	if (!process.env.DEBUG_DISABLE_USER_AUDIT) {
 		return wrapInSessionTransaction(_saveUser);
 	}
 
+	if (isBroken) {
+		throw new Error('DEBUG_DISABLE_USER_AUDIT flag is deprecated and should be removed');
+	}
 	const saveUserNoSession = _saveUser();
 	return function saveUser(userId: IUser['_id'], userData: SaveUserData, _options?: any) {
 		return saveUserNoSession(userId, userData);

apps/meteor/server/lib/shouldBreakInVersion.ts

@@ -1,5 +1,6 @@
 import semver from 'semver';
 
+import type { DeprecationLoggerNextPlannedVersion } from '../../app/lib/server/lib/deprecationWarningLogger';
 import { Info } from '../../app/utils/rocketchat.info';
 
-export const shouldBreakInVersion = (version: string) => semver.gte(Info.version, version);
+export const shouldBreakInVersion = (version: DeprecationLoggerNextPlannedVersion) => semver.gte(Info.version, version);