refactor: add format filtering along with validateFederatedUsers

Author: ricardogarim

apps/meteor/app/lib/server/functions/createRoom.ts

@@ -192,7 +192,11 @@ export const createRoom = async <T extends RoomType>(
 
 		// validate external users (network + user existence checks)
 		try {
-			await FederationMatrix.validateFederatedUsersBeforeRoomCreation(members);
+			// TODO: Use common function to extract and validate federated users
+			const federatedUsers = members
+				.filter((member: string | IUser) => (typeof member === 'string' ? member.includes(':') : member.username?.includes(':')))
+				.map((member: string | IUser) => (typeof member === 'string' ? member : member.username!));
+			await FederationMatrix.validateFederatedUsers(federatedUsers);
 		} catch (error) {
 			if (error instanceof FederationValidationError) {
 				throw new Meteor.Error(error.error, error.userMessage, { method: 'createRoom' });

apps/meteor/ee/server/hooks/federation/index.ts

@@ -214,7 +214,8 @@ callbacks.add(
 			}
 
 			try {
-				await FederationMatrix.validateFederatedUsersBeforeRoomCreation(members);
+				const federatedUsers = members.filter((username) => username.includes(':'));
+				await FederationMatrix.validateFederatedUsers(federatedUsers);
 			} catch (error) {
 				if (error instanceof FederationValidationError) {
 					throw new Meteor.Error(error.error, error.userMessage);

ee/packages/federation-matrix/src/FederationMatrix.ts

@@ -208,7 +208,7 @@ export class FederationMatrix extends ServiceClass implements IFederationMatrixS
 		this.processEDUPresence = (await Settings.getValueById<boolean>('Federation_Service_EDU_Process_Presence')) || false;
 	}
 
-	static async validateFederatedUsersBeforeRoomCreation(usernames: string[]): Promise<void> {
+	static async validateFederatedUsers(usernames: string[]): Promise<void> {
 		const hasInvalidFederatedUsername = usernames.some((username) => !validateFederatedUsername(username));
 		if (hasInvalidFederatedUsername) {
 			throw new FederationValidationError(