chore(eslint): Relax naming convention for Storybook's Story parameter

tassoevan · tassoevan · commit 932ae6a6b3a6 · 2025-07-08T12:53:28.000-03:00
diff --git a/apps/meteor/.eslintrc.json b/apps/meteor/.eslintrc.json
@@ -62,6 +62,14 @@
 						"modifiers": ["unused"],
 						"leadingUnderscore": "require"
 					},
+					{
+						"selector": "parameter",
+						"format": null,
+						"filter": {
+							"regex": "^Story$",
+							"match": true
+						}
+					},
 					{
 						"selector": ["interface"],
 						"format": ["PascalCase"],
diff --git a/apps/meteor/client/views/audit/components/AppInfoField.spec.tsx b/apps/meteor/client/views/audit/components/AppInfoField.spec.tsx
@@ -1,4 +1,3 @@
-/* eslint-disable @typescript-eslint/naming-convention */
 import { mockAppRoot } from '@rocket.chat/mock-providers';
 import { composeStories } from '@storybook/react';
 import { render } from '@testing-library/react';
diff --git a/apps/meteor/client/views/audit/components/SecurityLogDisplayModal.spec.tsx b/apps/meteor/client/views/audit/components/SecurityLogDisplayModal.spec.tsx
@@ -1,4 +1,3 @@
-/* eslint-disable @typescript-eslint/naming-convention */
 import { mockAppRoot } from '@rocket.chat/mock-providers';
 import { composeStories } from '@storybook/react';
 import { render } from '@testing-library/react';
diff --git a/apps/meteor/client/views/marketplace/AppDetailsPage/tabs/AppLogs/AppLogsItem.spec.tsx b/apps/meteor/client/views/marketplace/AppDetailsPage/tabs/AppLogs/AppLogsItem.spec.tsx
@@ -1,4 +1,3 @@
-/* eslint-disable @typescript-eslint/naming-convention */
 import { mockAppRoot } from '@rocket.chat/mock-providers';
 import { composeStories } from '@storybook/react';
 import { render } from '@testing-library/react';
diff --git a/apps/meteor/client/views/room/contextualBar/RoomMembers/InviteUsers/InviteUsers.spec.tsx b/apps/meteor/client/views/room/contextualBar/RoomMembers/InviteUsers/InviteUsers.spec.tsx
@@ -1,4 +1,3 @@
-/* eslint-disable @typescript-eslint/naming-convention */
 import { composeStories } from '@storybook/react';
 import { render } from '@testing-library/react';
 import { axe } from 'jest-axe';
diff --git a/ee/packages/pdf-worker/.storybook/preview.tsx b/ee/packages/pdf-worker/.storybook/preview.tsx
@@ -13,7 +13,6 @@ export const parameters: Parameters = {
 };
 
 export const decorators: Decorator[] = [
-	// eslint-disable-next-line @typescript-eslint/naming-convention
 	(Story) => (
 		<div>
 			<style>{`
diff --git a/packages/eslint-config/standard/index.js b/packages/eslint-config/standard/index.js
@@ -63,6 +63,14 @@ module.exports = {
 						format: ['camelCase', 'PascalCase'],
 						leadingUnderscore: 'allowSingleOrDouble',
 					},
+					{
+						selector: 'parameter',
+						format: null,
+						filter: {
+							regex: '^Story$',
+							match: true,
+						},
+					},
 					{
 						selector: 'parameter',
 						format: ['camelCase'],
diff --git a/packages/gazzodown/src/Markup.stories.tsx b/packages/gazzodown/src/Markup.stories.tsx
@@ -4,7 +4,7 @@ import colors from '@rocket.chat/fuselage-tokens/colors.json';
 import { Options, parse } from '@rocket.chat/message-parser';
 import type { Meta, StoryFn } from '@storybook/react';
 import outdent from 'outdent';
-import { ReactElement, Suspense } from 'react';
+import { Suspense } from 'react';
 
 import Markup from './Markup';
 import { MarkupInteractionContext } from './MarkupInteractionContext';
@@ -13,7 +13,7 @@ export default {
 	title: 'Markup',
 	component: Markup,
 	decorators: [
-		(Story): ReactElement => (
+		(Story) => (
 			<Suspense fallback={null}>
 				<MarkupInteractionContext.Provider value={{ enableTimestamp: true }}>
 					<MessageContainer>
diff --git a/packages/storybook-config/src/preview.tsx b/packages/storybook-config/src/preview.tsx
@@ -1,4 +1,3 @@
-/* eslint-disable @typescript-eslint/naming-convention */
 import { PaletteStyleTag } from '@rocket.chat/fuselage';
 import surface from '@rocket.chat/fuselage-tokens/dist/surface.json';
 import type { Parameters, Decorator } from '@storybook/react';
diff --git a/packages/ui-composer/.storybook/preview.tsx b/packages/ui-composer/.storybook/preview.tsx
@@ -1,7 +1,6 @@
 import { Decorator, Parameters } from '@storybook/react';
 import '../../../apps/meteor/app/theme/client/main.css';
 import 'highlight.js/styles/github.css';
-import { ReactElement } from 'react';
 
 export const parameters: Parameters = {
 	controls: {
@@ -13,7 +12,7 @@ export const parameters: Parameters = {
 };
 
 export const decorators: Decorator[] = [
-	(Story): ReactElement => (
+	(Story) => (
 		<div>
 			<style>{`
 				body {
diff --git a/packages/ui-video-conf/.storybook/preview.tsx b/packages/ui-video-conf/.storybook/preview.tsx
@@ -1,5 +1,4 @@
 import type { Decorator } from '@storybook/react';
-import type { ReactElement } from 'react';
 
 import '../../../apps/meteor/app/theme/client/main.css';
 import 'highlight.js/styles/github.css';
@@ -15,7 +14,7 @@ export const parameters = {
 };
 
 export const decorators: Decorator[] = [
-	(Story): ReactElement => (
+	(Story) => (
 		<div>
 			<style>{`
 				body {
diff --git a/packages/ui-video-conf/src/VideoConfMessage/VideoConfMessage.stories.tsx b/packages/ui-video-conf/src/VideoConfMessage/VideoConfMessage.stories.tsx
@@ -1,6 +1,5 @@
 import { MessageDivider, Message, Avatar, Box } from '@rocket.chat/fuselage';
 import type { Meta, StoryFn } from '@storybook/react';
-import type { ReactElement } from 'react';
 
 import { VideoConfMessage, VideoConfMessageIcon, VideoConfMessageRow, VideoConfMessageText } from '.';
 import VideoConfMessageAction from './VideoConfMessageAction';
@@ -16,7 +15,7 @@ export default {
 	title: 'Components/VideoConfMessage',
 	component: VideoConfMessage,
 	decorators: [
-		(Story): ReactElement => (
+		(Story) => (
 			<Box>
 				<MessageDivider>May, 24, 2020</MessageDivider>
 				<Message className='customclass'>
diff --git a/packages/ui-video-conf/src/VideoConfPopup/VideoConfPopup.stories.tsx b/packages/ui-video-conf/src/VideoConfPopup/VideoConfPopup.stories.tsx
@@ -1,7 +1,6 @@
 import { Avatar, Icon } from '@rocket.chat/fuselage';
 import { action } from '@storybook/addon-actions';
 import type { Meta, StoryFn } from '@storybook/react';
-import type { ReactElement } from 'react';
 
 import VideoConfButton from '../VideoConfButton';
 import VideoConfController from '../VideoConfController';
@@ -19,7 +18,7 @@ export default {
 	title: 'Components/VideoConfPopup',
 	component: VideoConfPopup,
 	decorators: [
-		(Story): ReactElement => (
+		(Story) => (
 			<VideoConfPopupBackdrop>
 				<Story />
 			</VideoConfPopupBackdrop>
diff --git a/packages/ui-voip/src/components/VoipActionButton/VoipActionButton.stories.tsx b/packages/ui-voip/src/components/VoipActionButton/VoipActionButton.stories.tsx
@@ -1,12 +1,10 @@
 import type { Meta, StoryFn } from '@storybook/react';
-import type { ReactElement } from 'react';
 
 import VoipActionButton from './VoipActionButton';
 
 export default {
 	title: 'Components/VoipActionButton',
 	component: VoipActionButton,
-	decorators: [(Story): ReactElement => <Story />],
 } satisfies Meta<typeof VoipActionButton>;
 
 export const SuccessButton: StoryFn<typeof VoipActionButton> = () => {
diff --git a/packages/ui-voip/src/components/VoipActions/VoipActions.stories.tsx b/packages/ui-voip/src/components/VoipActions/VoipActions.stories.tsx
@@ -1,5 +1,4 @@
 import type { Meta, StoryFn } from '@storybook/react';
-import type { ReactElement } from 'react';
 
 import VoipActions from './VoipActions';
 
@@ -8,7 +7,6 @@ const noop = () => undefined;
 export default {
 	title: 'Components/VoipActions',
 	component: VoipActions,
-	decorators: [(Story): ReactElement => <Story />],
 } satisfies Meta<typeof VoipActions>;
 
 export const IncomingActions: StoryFn<typeof VoipActions> = () => {
diff --git a/packages/ui-voip/src/components/VoipContactId/VoipContactId.stories.tsx b/packages/ui-voip/src/components/VoipContactId/VoipContactId.stories.tsx
@@ -1,15 +1,14 @@
 import { Box } from '@rocket.chat/fuselage';
 import type { Meta, StoryFn } from '@storybook/react';
 import { QueryClient, QueryClientProvider } from '@tanstack/react-query';
-import type { ReactElement } from 'react';
 
 import VoipContactId from './VoipContactId';
 
 export default {
 	title: 'Components/VoipContactId',
 	component: VoipContactId,
 	decorators: [
-		(Story): ReactElement => (
+		(Story) => (
 			<QueryClientProvider client={new QueryClient()}>
 				<Box maxWidth={200}>
 					<Story />
diff --git a/packages/ui-voip/src/components/VoipDialPad/VoipDialPad.stories.tsx b/packages/ui-voip/src/components/VoipDialPad/VoipDialPad.stories.tsx
@@ -1,14 +1,13 @@
 import { Box } from '@rocket.chat/fuselage';
 import type { Meta, StoryFn } from '@storybook/react';
-import type { ReactElement } from 'react';
 
 import VoipDialPad from './VoipDialPad';
 
 export default {
 	title: 'Components/VoipDialPad',
 	component: VoipDialPad,
 	decorators: [
-		(Story): ReactElement => (
+		(Story) => (
 			<Box maxWidth={248}>
 				<Story />
 			</Box>
diff --git a/packages/ui-voip/src/components/VoipPopup/VoipPopup.stories.tsx b/packages/ui-voip/src/components/VoipPopup/VoipPopup.stories.tsx
@@ -1,5 +1,4 @@
 import type { Meta, StoryFn } from '@storybook/react';
-import type { ReactElement } from 'react';
 
 import VoipPopup from './VoipPopup';
 import { createMockVoipProviders } from '../../tests/mocks';
@@ -10,7 +9,7 @@ export default {
 	title: 'Components/VoipPopup',
 	component: VoipPopup,
 	decorators: [
-		(Story): ReactElement => (
+		(Story) => (
 			<MockedProviders>
 				<Story />
 			</MockedProviders>

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,3 @@`
`1`		`-/* eslint-disable @typescript-eslint/naming-convention */`
`2`	`1`	`import { mockAppRoot } from '@rocket.chat/mock-providers';`
`3`	`2`	`import { composeStories } from '@storybook/react';`
`4`	`3`	`import { render } from '@testing-library/react';`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,3 @@`
`1`		`-/* eslint-disable @typescript-eslint/naming-convention */`
`2`	`1`	`import { PaletteStyleTag } from '@rocket.chat/fuselage';`
`3`	`2`	`import surface from '@rocket.chat/fuselage-tokens/dist/surface.json';`
`4`	`3`	`import type { Parameters, Decorator } from '@storybook/react';`