feat: native federation (#36970)

Co-authored-by: Ricardo Garim <rswarovsky@gmail.com>
Co-authored-by: Marcos Spessatto Defendi <marcos.defendi@rocket.chat>
Co-authored-by: Debdut Chakraborty <debdutdeb@outlook.com>
Co-authored-by: Debdut Chakraborty <debdut.chakraborty@rocket.chat>
Co-authored-by: Diego Sampaio <chinello@gmail.com>
Co-authored-by: Marcos Spessatto Defendi <marcos.defendicc@rede.ulbra.br>
Co-authored-by: Rodrigo Nascimento <rodrigoknascimento@gmail.com>

Author: 7 people

.github/workflows/ci-test-storybook.yml

@@ -22,9 +22,10 @@ jobs:
     runs-on: ubuntu-24.04
 
     name: Test Storybook
-    
+
     steps:
       - uses: actions/checkout@v4
+
       - name: Setup NodeJS
         uses: ./.github/actions/setup-node
         with:
@@ -54,4 +55,3 @@ jobs:
           flags: unit
           verbose: true
           token: ${{ secrets.CODECOV_TOKEN }}
-  

.gitignore

@@ -59,3 +59,5 @@ registration.yaml
 
 storybook-static
 development/tempo-data/
+
+.env

apps/meteor/app/channel-settings/server/functions/saveRoomName.ts

@@ -96,6 +96,6 @@ export async function saveRoomName(
 		await Message.saveSystemMessage('r', rid, displayName, user);
 	}
 
-	await callbacks.run('afterRoomNameChange', { room, name: displayName, oldName: room.name, userId: user._id });
+	await callbacks.run('afterRoomNameChange', { room, name: displayName, oldName: room.name, user });
 	return displayName;
 }

apps/meteor/app/channel-settings/server/functions/saveRoomTopic.ts

@@ -5,15 +5,15 @@ import { Meteor } from 'meteor/meteor';
 
 import { callbacks } from '../../../../lib/callbacks';
 
-export const saveRoomTopic = async function (
+export const saveRoomTopic = async (
 	rid: string,
 	roomTopic: string | undefined,
 	user: {
 		username: string;
 		_id: string;
 	},
 	sendMessage = true,
-) {
+) => {
 	if (!Match.test(rid, String)) {
 		throw new Meteor.Error('invalid-room', 'Invalid room', {
 			function: 'RocketChat.saveRoomTopic',
@@ -28,6 +28,6 @@ export const saveRoomTopic = async function (
 	if (update && sendMessage) {
 		await Message.saveSystemMessage('room_changed_topic', rid, roomTopic || '', user);
 	}
-	await callbacks.run('afterRoomTopicChange', { rid, topic: roomTopic });
+	await callbacks.run('afterRoomTopicChange', undefined, { room, topic: roomTopic, user });
 	return update;
 };

apps/meteor/app/discussion/server/hooks/propagateDiscussionMetadata.ts

@@ -48,7 +48,7 @@ callbacks.add(
 
 callbacks.add(
 	'afterDeleteMessage',
-	async (message, { _id, prid }) => {
+	async (message, { room: { _id, prid } }) => {
 		if (prid) {
 			const room = await Rooms.findOneById(_id, {
 				projection: {

apps/meteor/app/lib/server/functions/addUserToRoom.ts

@@ -1,7 +1,7 @@
 import { Apps, AppEvents } from '@rocket.chat/apps';
 import { AppsEngineException } from '@rocket.chat/apps-engine/definition/exceptions';
 import { Message, Team } from '@rocket.chat/core-services';
-import type { IUser } from '@rocket.chat/core-typings';
+import { type IUser } from '@rocket.chat/core-typings';
 import { Subscriptions, Users, Rooms } from '@rocket.chat/models';
 import { Meteor } from 'meteor/meteor';
 
@@ -19,7 +19,7 @@ import { notifyOnRoomChangedById, notifyOnSubscriptionChangedById } from '../lib
  * Caution - It does not validates if the user has permission to join room
  */
 
-export const addUserToRoom = async function (
+export const addUserToRoom = async (
 	rid: string,
 	user: Pick<IUser, '_id' | 'username'> | string,
 	inviter?: Pick<IUser, '_id' | 'username'>,
@@ -32,7 +32,7 @@ export const addUserToRoom = async function (
 		skipAlertSound?: boolean;
 		createAsHidden?: boolean;
 	} = {},
-): Promise<boolean | undefined> {
+): Promise<boolean | undefined> => {
 	const now = new Date();
 	const room = await Rooms.findOneById(rid);
 
@@ -57,7 +57,7 @@ export const addUserToRoom = async function (
 	}
 
 	try {
-		await beforeAddUserToRoom.run({ user: userToBeAdded, inviter }, room);
+		await beforeAddUserToRoom.run({ user: userToBeAdded, inviter: (inviter && (await Users.findOneById(inviter._id))) || undefined }, room);
 	} catch (error) {
 		throw new Meteor.Error((error as any)?.message);
 	}

apps/meteor/app/lib/server/functions/createDirectRoom.ts

@@ -42,10 +42,11 @@ const getName = (members: IUser[]): string => members.map(({ username }) => user
 
 export async function createDirectRoom(
 	members: IUser[] | string[],
-	roomExtraData = {},
+	roomExtraData: Partial<IRoom> = {},
 	options: {
 		creator?: string;
 		subscriptionExtra?: ISubscriptionExtraData;
+		federatedRoomId?: string;
 	},
 ): Promise<ICreatedRoom> {
 	const maxUsers = settings.get<number>('DirectMesssage_maxUsers') || 1;
@@ -59,17 +60,17 @@ export async function createDirectRoom(
 		);
 	}
 
-	await callbacks.run('beforeCreateDirectRoom', members);
-
 	const membersUsernames: string[] = members
 		.map((member) => {
 			if (typeof member === 'string') {
-				return member.replace('@', '');
+				return member;
 			}
 			return member.username;
 		})
 		.filter(isTruthy);
 
+	await callbacks.run('beforeCreateDirectRoom', membersUsernames, roomExtraData);
+
 	const roomMembers: IUser[] = await Users.findUsersByUsernames(membersUsernames, {
 		projection: { _id: 1, name: 1, username: 1, settings: 1, customFields: 1 },
 	}).toArray();
@@ -179,7 +180,11 @@ export async function createDirectRoom(
 	if (isNewRoom) {
 		const insertedRoom = await Rooms.findOneById(rid);
 
-		await callbacks.run('afterCreateDirectRoom', insertedRoom, { members: roomMembers, creatorId: options?.creator });
+		await callbacks.run('afterCreateDirectRoom', insertedRoom, {
+			members: roomMembers,
+			creatorId: options?.creator,
+			mrid: options?.federatedRoomId,
+		});
 
 		void Apps.self?.triggerEvent(AppEvents.IPostRoomCreate, insertedRoom);
 	}

apps/meteor/app/lib/server/functions/createRoom.ts

@@ -68,6 +68,7 @@ async function createUsersSubscriptions({
 
 	const membersCursor = Users.findUsersByUsernames(members);
 
+	// TODO: Check re new federation-service - should we add them here or keep on createRoom inside of homeserver?!
 	for await (const member of membersCursor) {
 		try {
 			await beforeAddUserToRoom.run({ user: member, inviter: owner }, room);
@@ -131,7 +132,25 @@ export const createRoom = async <T extends RoomType>(
 		rid: string;
 	}
 > => {
-	const { teamId, ...extraData } = roomExtraData || ({} as IRoom);
+	const { teamId, ...optionalExtraData } = roomExtraData || ({} as IRoom);
+
+	const hasFederatedMembers = members.some((member) => {
+		if (typeof member === 'string') {
+			return member.includes(':') && member.includes('@');
+		}
+		return member.username?.includes(':') && member.username?.includes('@');
+	});
+
+	const extraData = {
+		...optionalExtraData,
+		...((hasFederatedMembers || optionalExtraData.federated) && {
+			federated: true,
+			federation: {
+				version: 1,
+				// TODO we should be able to provide all values from here, currently we update on callback afterCreateRoom
+			},
+		}),
+	};
 
 	await prepareCreateRoomCallback.run({
 		type,
@@ -265,6 +284,7 @@ export const createRoom = async <T extends RoomType>(
 		callbacks.runAsync('afterCreatePrivateGroup', owner, room);
 	}
 	callbacks.runAsync('afterCreateRoom', owner, room);
+
 	if (shouldBeHandledByFederation) {
 		callbacks.runAsync('federation.afterCreateFederatedRoom', room, { owner, originalMemberList: members, options });
 	}

apps/meteor/app/lib/server/functions/deleteMessage.ts

@@ -93,7 +93,7 @@ export async function deleteMessage(message: IMessage, user: IUser): Promise<voi
 		await Rooms.decreaseMessageCountById(message.rid, 1);
 	}
 
-	await callbacks.run('afterDeleteMessage', deletedMsg, room);
+	await callbacks.run('afterDeleteMessage', deletedMsg, { room, user });
 
 	void notifyOnRoomChangedById(message.rid);
 

apps/meteor/app/lib/server/functions/setUserActiveStatus.ts

@@ -1,7 +1,6 @@
-import { Federation, FederationEE, License } from '@rocket.chat/core-services';
 import type { IUser, IUserEmail } from '@rocket.chat/core-typings';
 import { isUserFederated, isDirectMessageRoom } from '@rocket.chat/core-typings';
-import { Rooms, Users, Subscriptions, MatrixBridgedUser } from '@rocket.chat/models';
+import { Rooms, Users, Subscriptions } from '@rocket.chat/models';
 import { Accounts } from 'meteor/accounts-base';
 import { check } from 'meteor/check';
 import { Meteor } from 'meteor/meteor';
@@ -71,22 +70,6 @@ export async function setUserActiveStatus(
 		});
 	}
 
-	if (user.active !== active) {
-		const remoteUser = await MatrixBridgedUser.getExternalUserIdByLocalUserId(userId);
-
-		if (remoteUser) {
-			if (active) {
-				throw new Meteor.Error('error-not-allowed', 'Deactivated federated users can not be re-activated', {
-					method: 'setUserActiveStatus',
-				});
-			}
-
-			const federation = (await License.hasValidLicense()) ? FederationEE : Federation;
-
-			await federation.deactivateRemoteUser(remoteUser);
-		}
-	}
-
 	// Users without username can't do anything, so there is no need to check for owned rooms
 	if (user.username != null && !active) {
 		const userAdmin = await Users.findOneAdmin(userId || '');