fix: Livechat conversation not closing due to cross-tab interference (#35168)

Author: aleksandernsilva

.changeset/rude-llamas-pay.md

@@ -0,0 +1,5 @@
+---
+"@rocket.chat/livechat": patch
+---
+
+Fixes Livechat conversation not closing in a few scenarios due to cross-tab interference

packages/livechat/src/lib/room.js

@@ -24,12 +24,7 @@ export const closeChat = async ({ transcriptRequested } = {}) => {
 		await handleTranscript();
 	}
 
-	const { room, department, config: { settings: { clearLocalStorageWhenChatEnded } = {} } = {} } = store.state;
-
-	if (!room) {
-		console.warn('closeChat called without a room');
-		return;
-	}
+	const { department, config: { settings: { clearLocalStorageWhenChatEnded } = {} } = {} } = store.state;
 
 	await store.setState({ room: null, renderedTriggers: [] });
 

packages/livechat/src/routes/Chat/container.js

@@ -2,6 +2,7 @@ import { Component } from 'preact';
 import { route } from 'preact-router';
 import { withTranslation } from 'react-i18next';
 
+import Chat from './component';
 import { Livechat } from '../../api';
 import { ModalManager } from '../../components/Modal';
 import { getAvatarUrl } from '../../helpers/baseUrl';
@@ -22,9 +23,8 @@ import constants from '../../lib/constants';
 import { getLastReadMessage, loadConfig, processUnread, shouldMarkAsUnread } from '../../lib/main';
 import { parentCall, runCallbackEventEmitter } from '../../lib/parentCall';
 import { createToken } from '../../lib/random';
-import { initRoom, closeChat, loadMessages, loadMoreMessages, defaultRoomParams, getGreetingMessages } from '../../lib/room';
+import { initRoom, loadMessages, loadMoreMessages, defaultRoomParams, getGreetingMessages } from '../../lib/room';
 import store from '../../store';
-import Chat from './component';
 
 const ChatWrapper = ({ children, rid }) => {
 	useRoomMessagesSubscription(rid);
@@ -254,7 +254,6 @@ class ChatContainer extends Component {
 			await dispatch({ alerts: (alerts.push(alert), alerts) });
 		} finally {
 			await dispatch({ loading: false });
-			await closeChat();
 		}
 	};