fix: Default priorities name not being translated in sidebar room menu (#36813)

Author: dougfabris

.changeset/metal-jobs-learn.md

@@ -0,0 +1,5 @@
+---
+'@rocket.chat/meteor': patch
+---
+
+Fixes an issue where the omnichannel default priorities are not being translated in the sidebar room menu

.changeset/slow-ants-divide.md

@@ -2,4 +2,4 @@
 '@rocket.chat/meteor': patch
 ---
 
-Fixes an issue where the omnichannel default priorities are not being translated
+Fixes an issue where the omnichannel default priorities are not being translated in priorities list

apps/meteor/client/omnichannel/hooks/useOmnichannelPrioritiesMenu.tsx

@@ -37,7 +37,7 @@ export const useOmnichannelPrioritiesMenu = (rid: IRoom['_id']) => {
 		};
 
 		const options = priorities.map(({ _id: priorityId, name, i18n, dirty, sortItem }) => {
-			const label = dirty && name ? name : i18n;
+			const label = dirty && name ? name : t(i18n);
 
 			return {
 				id: priorityId,
@@ -49,5 +49,5 @@ export const useOmnichannelPrioritiesMenu = (rid: IRoom['_id']) => {
 		});
 
 		return priorities.length ? [unprioritizedOption, ...options] : [];
-	}, [t, priorities, updateRoomPriority, removeRoomPriority, queryClient, rid]);
+	}, [t, priorities, updateRoomPriority, removeRoomPriority, queryClient, rid, dispatchToastMessage]);
 };

apps/meteor/client/sidebar/hooks/useRoomMenuActions.ts

@@ -58,7 +58,7 @@ export const useRoomMenuActions = ({
 	const menuOptions = useMemo(
 		() =>
 			!hideDefaultOptions
-				? [
+				? ([
 						!isOmnichannelRoom && {
 							id: 'hideRoom',
 							icon: 'eye-off',
@@ -83,7 +83,7 @@ export const useRoomMenuActions = ({
 							content: t('Leave_room'),
 							onClick: handleLeave,
 						},
-					]
+					].filter(Boolean) as GenericMenuItemProps[])
 				: [],
 		[
 			hideDefaultOptions,
@@ -102,10 +102,10 @@ export const useRoomMenuActions = ({
 
 	if (isOmnichannelRoom && prioritiesMenu.length > 0) {
 		return [
-			{ title: '', items: menuOptions.filter(Boolean) as GenericMenuItemProps[] },
-			{ title: t('Priorities'), items: prioritiesMenu },
+			...(menuOptions.length > 0 ? [{ title: '', items: menuOptions }] : []),
+			...(prioritiesMenu.length > 0 ? [{ title: t('Priorities'), items: prioritiesMenu }] : []),
 		];
 	}
 
-	return [{ title: '', items: menuOptions.filter(Boolean) as GenericMenuItemProps[] }];
+	return menuOptions.length > 0 ? [{ title: '', items: menuOptions }] : [];
 };