test: add end-to-end tests for inviting user from a remote server to a room and verifying member list

Author: ggazzo

ee/packages/federation-matrix/tests/end-to-end/room.spec.ts

@@ -9,6 +9,7 @@ import {
 	addUserToRoomSlashCommand,
 	acceptRoomInvite,
 	rejectRoomInvite,
+	getRoomMembers,
 } from '../../../../../apps/meteor/tests/data/rooms.helper';
 import { type IRequestConfig, getRequestConfig, createUser, deleteUser } from '../../../../../apps/meteor/tests/data/users.helper';
 import { IS_EE } from '../../../../../apps/meteor/tests/e2e/config/constants';
@@ -1563,14 +1564,59 @@ import { SynapseClient } from '../helper/synapse-client';
 					// RC view: Admin tries to accept rc1User1's invitation
 					const response = await acceptRoomInvite(federatedChannel._id, rc1AdminRequestConfig);
 					expect(response.success).toBe(false);
-					expect(response.error).toBe('Failed to handle invite: No subscription found or user does not have permission to accept or reject this invite');
+					expect(response.error).toBe(
+						'Failed to handle invite: No subscription found or user does not have permission to accept or reject this invite',
+					);
 				});
 
 				it('It should not allow admin to reject invitation on behalf of another user', async () => {
 					// RC view: Admin tries to reject rc1User1's invitation
 					const response = await rejectRoomInvite(federatedChannel._id, rc1AdminRequestConfig);
 					expect(response.success).toBe(false);
-					expect(response.error).toBe('Failed to handle invite: No subscription found or user does not have permission to accept or reject this invite');
+					expect(response.error).toBe(
+						'Failed to handle invite: No subscription found or user does not have permission to accept or reject this invite',
+					);
+				});
+			});
+		});
+
+		describe('Inviting a RC user from Synapse', () => {
+			describe('Room that already contains previous events', () => {
+				it('It should reflect all the members and messagens on the rocket.chat side', async () => {
+					let roomId: string;
+					let channelName: string;
+
+					beforeAll(async () => {
+						channelName = `federated-channel-invite-single-${Date.now()}`;
+						roomId = await hs1AdminApp.createRoom(channelName);
+
+						await hs1AdminApp.sendTextMessage(roomId, 'Message from admin');
+						await hs1AdminApp.inviteUserToRoom(roomId, federationConfig.rc1.additionalUser1.matrixUserId);
+						await hs1User1App.acceptInvitationForRoomName(channelName);
+						await hs1User1App.sendTextMessage(roomId, 'Message from user1');
+
+						await hs1AdminApp.inviteUserToRoom(roomId, federationConfig.rc1.adminUser);
+
+						await acceptRoomInvite(roomId, rc1User1RequestConfig);
+					}, 15000);
+
+					it('It should show all the three users in the members list', async () => {
+						const members = await getRoomMembers(roomId, rc1AdminRequestConfig);
+						expect(members.members.length).toBe(3);
+						expect(members.members.find((member: IUser) => member.username === federationConfig.rc1.adminUser)).not.toBeNull();
+						expect(
+							members.members.find((member: IUser) => member.username === federationConfig.rc1.additionalUser1.username),
+						).not.toBeNull();
+						expect(members.members.find((member: IUser) => member.username === federationConfig.hs1.adminMatrixUserId)).not.toBeNull();
+						// RC view: Check in RC
+						const rc1AdminUserInRC = await findRoomMember(roomId, federationConfig.rc1.adminUser, {}, rc1AdminRequestConfig);
+						const rc1User1InRC = await findRoomMember(roomId, federationConfig.rc1.additionalUser1.username, {}, rc1AdminRequestConfig);
+						const hs1AdminUserInRC = await findRoomMember(roomId, federationConfig.hs1.adminMatrixUserId, {}, rc1AdminRequestConfig);
+
+						expect(rc1AdminUserInRC).not.toBeNull();
+						expect(rc1User1InRC).not.toBeNull();
+						expect(hs1AdminUserInRC).not.toBeNull();
+					});
 				});
 			});
 		});

ee/packages/federation-matrix/tests/helper/synapse-client.ts

@@ -7,7 +7,7 @@
 import * as fs from 'fs';
 import * as path from 'path';
 
-import { createClient, type MatrixClient, KnownMembership, type Room, type RoomMember } from 'matrix-js-sdk';
+import { createClient, type MatrixClient, KnownMembership, type Room, type RoomMember, Visibility } from 'matrix-js-sdk';
 
 /**
  * Creates a promise that resolves after the specified delay.
@@ -132,6 +132,26 @@ export class SynapseClient {
 		throw new Error(`No room found with name ${roomName}`);
 	}
 
+	async createRoom(roomName: string, visibility: Visibility = Visibility.Private): Promise<string> {
+		if (!this.matrixClient) {
+			throw new Error('Matrix client is not initialized');
+		}
+
+		const room = await this.matrixClient.createRoom({
+			name: roomName,
+			visibility,
+		});
+
+		return room.room_id;
+	}
+
+	async inviteUserToRoom(roomId: string, userId: string): Promise<void> {
+		if (!this.matrixClient) {
+			throw new Error('Matrix client is not initialized');
+		}
+		await this.matrixClient.invite(userId, roomId);
+	}
+
 	/**
 	 * Finds a room by name and membership status.
 	 *